Files
rippled/src/xrpld/rpc/detail/PathRequestManager.cpp
Pratik Mankawde e8bbc36265 perf(rpc): compile out the pathfind update_all span with telemetry off
updateAll's update_all span is wholly telemetry: the optional guard, the
empty-requests test that decides whether to emit at all, and the two
attributes have no reader outside the span. It runs on every ledger close, so
with telemetry compiled out the function still constructed a stub guard and
discarded pathfind_ledger_index and pathfind_num_requests once a close for
nothing. Everything the rest of updateAll depends on, including the
isNewPathRequest() flag reset, is outside the block and unchanged.

No span object exists to test before it is created, so the guard is an #ifdef
over the whole block. The three includes it was the sole user of --
PathFindSpanNames.h, SpanGuard.h and <optional> -- are gated the same way,
because otherwise they would be unused includes in that build and
clang-tidy's misc-include-cleaner would reject them.
2026-08-26 19:49:09 +01:00

339 lines
11 KiB
C++

#include <xrpld/rpc/detail/PathRequestManager.h>
#include <xrpld/app/ledger/LedgerMaster.h>
#include <xrpld/app/main/Application.h>
#include <xrpld/rpc/detail/AssetCache.h>
#include <xrpld/rpc/detail/PathRequest.h>
#include <xrpl/basics/Log.h>
#include <xrpl/core/Job.h>
#include <xrpl/core/JobQueue.h>
#include <xrpl/json/json_value.h>
#include <xrpl/ledger/ReadView.h>
#include <xrpl/protocol/ErrorCodes.h>
#include <xrpl/protocol/RPCErr.h>
#include <xrpl/protocol/jss.h>
#include <xrpl/resource/Consumer.h>
#include <xrpl/server/InfoSub.h>
#include <algorithm>
#include <cstdint>
#include <functional>
#include <memory>
#include <mutex>
#include <utility>
#include <vector>
// Needed only by the update_all span in updateAll(), which is compiled out when
// telemetry is off. Without the same guard here they would be unused includes in
// that build, which clang-tidy's misc-include-cleaner rejects.
#ifdef XRPL_ENABLE_TELEMETRY
#include <xrpld/rpc/detail/PathFindSpanNames.h>
#include <xrpl/telemetry/SpanGuard.h>
#include <optional>
#endif // XRPL_ENABLE_TELEMETRY
namespace xrpl {
/**
* Get the current AssetCache, updating it if necessary.
* Get the correct ledger to use.
*/
std::shared_ptr<AssetCache>
PathRequestManager::getAssetCache(std::shared_ptr<ReadView const> const& ledger, bool authoritative)
{
std::scoped_lock const sl(lock_);
auto assetCache = assetCache_.lock();
std::uint32_t const lineSeq = assetCache ? assetCache->getLedger()->seq() : 0;
std::uint32_t const lgrSeq = ledger->seq();
JLOG(journal_.debug()) << "getLineCache has cache for " << lineSeq << ", considering "
<< lgrSeq;
if ((lineSeq == 0) || // no ledger
(authoritative && (lgrSeq > lineSeq)) || // newer authoritative ledger
(authoritative && ((lgrSeq + 8) < lineSeq)) || // we jumped way back for some reason
(lgrSeq > (lineSeq + 8))) // we jumped way forward for some reason
{
JLOG(journal_.debug()) << "getLineCache creating new cache for " << lgrSeq;
// Assign to the local before the member, because the member is a
// weak_ptr, and will immediately discard it if there are no other
// references.
assetCache_ = assetCache =
std::make_shared<AssetCache>(ledger, app_.getJournal("AssetCache"));
}
return assetCache;
}
void
PathRequestManager::updateAll(std::shared_ptr<ReadView const> const& inLedger)
{
auto event = app_.getJobQueue().makeLoadEvent(JtPathFind, "PathRequest::updateAll");
std::vector<PathRequest::wptr> requests;
std::shared_ptr<AssetCache> cache;
// Get the ledger and cache we should be using
{
std::scoped_lock const sl(lock_);
requests = requests_;
cache = getAssetCache(inLedger, true);
}
#ifdef XRPL_ENABLE_TELEMETRY
using namespace telemetry;
// Nothing outside telemetry reads this block, and updateAll runs on every
// ledger close, so it is compiled out entirely when telemetry is off rather
// than left to construct a stub guard and discard two attributes per close.
// No span object exists to test here, so the guard has to be an #ifdef.
//
// Skip span emission when there are no active path subscriptions, to avoid
// a steady stream of empty spans at mainnet close cadence. All other work
// still runs unchanged (notably the isNewPathRequest() flag reset below).
//
// Scoped, so the pathfind.compute spans that doUpdate() creates below on
// this thread nest under it. std::optional because ScopedSpanGuard is
// deliberately non-movable, so it cannot be produced by a ternary.
std::optional<ScopedSpanGuard> span;
if (!requests.empty())
{
span.emplace(
TraceCategory::Rpc, pathfind_span::prefix::pathfind, pathfind_span::op::updateAll);
span->setAttribute(pathfind_span::attr::ledgerIndex, static_cast<int64_t>(inLedger->seq()));
span->setAttribute(pathfind_span::attr::numRequests, static_cast<int64_t>(requests.size()));
}
#endif // XRPL_ENABLE_TELEMETRY
bool newRequests = app_.getLedgerMaster().isNewPathRequest();
bool mustBreak = false;
JLOG(journal_.trace()) << "updateAll seq=" << cache->getLedger()->seq() << ", "
<< requests.size() << " requests";
int processed = 0, removed = 0;
auto getSubscriber = [](PathRequest::pointer const& request) -> InfoSub::pointer {
if (auto ipSub = request->getSubscriber(); ipSub && ipSub->getRequest() == request)
{
return ipSub;
}
request->doAborting();
return nullptr;
};
do
{
JLOG(journal_.trace()) << "updateAll looping";
for (auto const& wr : requests)
{
if (app_.getJobQueue().isStopping())
break;
auto request = wr.lock();
bool remove = true;
JLOG(journal_.trace()) << "updateAll request " << (request ? "" : "not ") << "found";
if (request)
{
auto continueCallback = [&getSubscriber, &request]() {
// This callback is used by doUpdate to determine whether to
// continue working. If getSubscriber returns null, that
// indicates that this request is no longer relevant.
return (bool)getSubscriber(request);
};
if (!request->needsUpdate(newRequests, cache->getLedger()->seq()))
{
remove = false;
}
else
{
if (auto ipSub = getSubscriber(request))
{
if (!ipSub->getConsumer().warn())
{
// Release the shared ptr to the subscriber so that
// it can be freed if the client disconnects, and
// thus fail to lock later.
ipSub.reset();
json::Value update = request->doUpdate(cache, false, continueCallback);
request->updateComplete();
update[jss::type] = "path_find";
ipSub = getSubscriber(request);
if (ipSub)
{
ipSub->send(update, false);
remove = false;
++processed;
}
}
}
else if (request->hasCompletion())
{
// One-shot request with completion function
request->doUpdate(cache, false);
request->updateComplete();
++processed;
}
}
}
if (remove)
{
std::scoped_lock const sl(lock_);
// Remove any dangling weak pointers or weak
// pointers that refer to this path request.
auto ret = std::ranges::remove_if(requests_, [&removed, &request](auto const& wl) {
auto r = wl.lock();
if (r && r != request)
return false;
++removed;
return true;
});
requests_.erase(ret.begin(), ret.end());
}
mustBreak = !newRequests && app_.getLedgerMaster().isNewPathRequest();
// We weren't handling new requests and then
// there was a new request
if (mustBreak)
break;
}
if (mustBreak)
{ // a new request came in while we were working
newRequests = true;
}
else if (newRequests)
{ // we only did new requests, so we always need a last pass
newRequests = app_.getLedgerMaster().isNewPathRequest();
}
else
{ // if there are no new requests, we are done
newRequests = app_.getLedgerMaster().isNewPathRequest();
if (!newRequests)
break;
}
// Hold on to the line cache until after the lock is released, so it can
// be destroyed outside of the lock
std::shared_ptr<AssetCache> lastCache;
{
// Get the latest requests, cache, and ledger for next pass
std::scoped_lock const sl(lock_);
if (requests_.empty())
break;
requests = requests_;
lastCache = cache;
cache = getAssetCache(cache->getLedger(), false);
}
} while (!app_.getJobQueue().isStopping());
JLOG(journal_.debug()) << "updateAll complete: " << processed << " processed and " << removed
<< " removed";
}
bool
PathRequestManager::requestsPending() const
{
std::scoped_lock const sl(lock_);
return !requests_.empty();
}
void
PathRequestManager::insertPathRequest(PathRequest::pointer const& req)
{
std::scoped_lock const sl(lock_);
// Insert after any older unserviced requests but before
// any serviced requests
auto ret = std::ranges::find_if(requests_, [](auto const& wl) {
auto r = wl.lock();
// We come before handled requests
return r && !r->isNew();
});
requests_.emplace(ret, req);
}
// Make a new-style path_find request
json::Value
PathRequestManager::makePathRequest(
std::shared_ptr<InfoSub> const& subscriber,
std::shared_ptr<ReadView const> const& inLedger,
json::Value const& requestJson)
{
auto req = std::make_shared<PathRequest>(app_, subscriber, ++lastIdentifier_, *this, journal_);
auto [valid, jvRes] = req->doCreate(getAssetCache(inLedger, false), requestJson);
if (valid)
{
subscriber->setRequest(req);
insertPathRequest(req);
app_.getLedgerMaster().newPathRequest();
}
return std::move(jvRes);
}
// Make an old-style ripple_path_find request
json::Value
PathRequestManager::makeLegacyPathRequest(
PathRequest::pointer& req,
std::function<void(void)> completion,
resource::Consumer& consumer,
std::shared_ptr<ReadView const> const& inLedger,
json::Value const& request)
{
// This assignment must take place before the
// completion function is called
req = std::make_shared<PathRequest>(
app_, completion, consumer, ++lastIdentifier_, *this, journal_);
auto [valid, jvRes] = req->doCreate(getAssetCache(inLedger, false), request);
if (!valid)
{
req.reset();
}
else
{
insertPathRequest(req);
if (!app_.getLedgerMaster().newPathRequest())
{
// The newPathRequest failed. Tell the caller.
jvRes = rpcError(RpcTooBusy);
req.reset();
}
}
return std::move(jvRes);
}
json::Value
PathRequestManager::doLegacyPathRequest(
resource::Consumer& consumer,
std::shared_ptr<ReadView const> const& inLedger,
json::Value const& request)
{
auto cache = std::make_shared<AssetCache>(inLedger, app_.getJournal("AssetCache"));
auto req =
std::make_shared<PathRequest>(app_, [] {}, consumer, ++lastIdentifier_, *this, journal_);
auto [valid, jvRes] = req->doCreate(cache, request);
if (valid)
jvRes = req->doUpdate(cache, false);
return std::move(jvRes);
}
} // namespace xrpl