mirror of
https://github.com/XRPLF/rippled.git
synced 2026-07-30 10:30:22 +00:00
2a5b1b4e17
- Rename MantissaRange::Get to MantissaRange::Access. The name doesn't really matter, but since the intent of the class is to control access to one function, this works. - Exclude the MantissaScale enum from linting for readability-enum-initial-value. clang-tidy was complaining that "error: initial values in enum 'xrpl::MantissaRange::MantissaScale' are not consistent, consider explicit initialization of all, none or only the first enumerator", but I don't care. I just need Large to match the last value. - Add a static_assert in setCurrentTransactionRules, so that if another MantissaScale is added (and Large is properly updated), the engineer won't forget to add a case for it there.
Basics
Utility functions and classes.
The module xrpl/basics should contain no dependencies on other modules.
Choosing an xrpld container.
-
std::vector- For ordered containers with most insertions or erases at the end.
-
std::deque- For ordered containers with most insertions or erases at the start or end.
-
std::list- For ordered containers with inserts and erases to the middle.
- For containers with iterators stable over insert and erase.
- Generally slower and bigger than
std::vectororstd::dequeexcept for those cases.
-
std::set- For sorted containers.
-
xrpl::hash_set- Where inserts and contains need to be O(1).
- For "small" sets,
std::setmight be faster and smaller.
-
xrpl::hardened_hash_set- For data sets where the key could be manipulated by an attacker in an attempt to mount an algorithmic complexity attack: see http://en.wikipedia.org/wiki/Algorithmic_complexity_attack
The following container is deprecated
std::unordered_set- Use
xrpl::hash_setinstead, which uses a better hashing algorithm. - Or use
xrpl::hardened_hash_setto prevent algorithmic complexity attacks.