mirror of
https://github.com/XRPLF/rippled.git
synced 2025-12-06 17:27:55 +00:00
78076a6903
The API would allow seeds (and public keys) to be used in place of accounts at several locations in the API. For example, when calling account_info, you could pass `"account": "foo"`. The string "foo" is treated like a seed, so the method returns `actNotFound` (instead of `actMalformed`, as most developers would expect). In the early days, this was a convenience to make testing easier. However, it allows for poor security practices, so it is no longer a good idea. Allowing a secret or passphrase is now considered a bug. Previously, it was controlled by the `strict` option on some methods. With this commit, since the API does not interpret `account` as `seed`, the option `strict` is no longer needed and is removed. Removing this behavior from the API is a [breaking change](https://xrpl.org/request-formatting.html#breaking-changes). One could argue that it shouldn't be done without bumping the API version; however, in this instance, there is no evidence that anyone is using the API in the "legacy" way. Furthermore, it is a potential security hole, as it allows users to send secrets to places where they are not needed, where they could end up in logs, error messages, etc. There's no reason to take such a risk with a seed/secret, since only the public address is needed. Resolves: #3329, #3330, #4337 BREAKING CHANGE: Remove non-strict account parsing (#3330)
223 lines
8.0 KiB
C++
223 lines
8.0 KiB
C++
//------------------------------------------------------------------------------
|
|
/*
|
|
This file is part of rippled: https://github.com/ripple/rippled
|
|
Copyright (c) 2017 Ripple Labs Inc.
|
|
|
|
Permission to use, copy, modify, and/or distribute this software for any
|
|
purpose with or without fee is hereby granted, provided that the above
|
|
copyright notice and this permission notice appear in all copies.
|
|
|
|
THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
|
|
WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
|
|
MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
|
|
ANY SPECIAL , DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
|
|
WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
|
|
ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
|
|
OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
|
|
*/
|
|
//==============================================================================
|
|
#include <test/jtx.h>
|
|
|
|
#include <ripple/beast/unit_test.h>
|
|
#include <ripple/protocol/AccountID.h>
|
|
#include <ripple/protocol/STAmount.h>
|
|
#include <ripple/protocol/jss.h>
|
|
|
|
namespace ripple {
|
|
|
|
class OwnerInfo_test : public beast::unit_test::suite
|
|
{
|
|
void
|
|
testBadInput()
|
|
{
|
|
testcase("Bad input to owner_info");
|
|
|
|
using namespace test::jtx;
|
|
Env env{*this};
|
|
|
|
auto const alice = Account{"alice"};
|
|
env.fund(XRP(10000), alice);
|
|
env.close();
|
|
|
|
{ // missing account field
|
|
auto const result =
|
|
env.rpc("json", "owner_info", "{}")[jss::result];
|
|
BEAST_EXPECT(result[jss::error] == "invalidParams");
|
|
BEAST_EXPECT(
|
|
result[jss::error_message] == "Missing field 'account'.");
|
|
}
|
|
|
|
{ // ask for empty account
|
|
Json::Value params;
|
|
params[jss::account] = "";
|
|
auto const result =
|
|
env.rpc("json", "owner_info", to_string(params))[jss::result];
|
|
if (BEAST_EXPECT(
|
|
result.isMember(jss::accepted) &&
|
|
result.isMember(jss::current)))
|
|
{
|
|
BEAST_EXPECT(
|
|
result[jss::accepted][jss::error] == "actMalformed");
|
|
BEAST_EXPECT(
|
|
result[jss::accepted][jss::error_message] ==
|
|
"Account malformed.");
|
|
BEAST_EXPECT(
|
|
result[jss::current][jss::error] == "actMalformed");
|
|
BEAST_EXPECT(
|
|
result[jss::current][jss::error_message] ==
|
|
"Account malformed.");
|
|
}
|
|
}
|
|
|
|
{ // ask for nonexistent account
|
|
// this seems like it should be an error, but current impl
|
|
// (deprecated) does not return an error, just empty fields.
|
|
Json::Value params;
|
|
params[jss::account] = Account{"bob"}.human();
|
|
auto const result =
|
|
env.rpc("json", "owner_info", to_string(params))[jss::result];
|
|
BEAST_EXPECT(result[jss::accepted] == Json::objectValue);
|
|
BEAST_EXPECT(result[jss::current] == Json::objectValue);
|
|
BEAST_EXPECT(result[jss::status] == "success");
|
|
}
|
|
}
|
|
|
|
void
|
|
testBasic()
|
|
{
|
|
testcase("Basic request for owner_info");
|
|
|
|
using namespace test::jtx;
|
|
Env env{*this};
|
|
|
|
auto const alice = Account{"alice"};
|
|
auto const gw = Account{"gateway"};
|
|
env.fund(XRP(10000), alice, gw);
|
|
auto const USD = gw["USD"];
|
|
auto const CNY = gw["CNY"];
|
|
env(trust(alice, USD(1000)));
|
|
env(trust(alice, CNY(1000)));
|
|
env(offer(alice, USD(1), XRP(1000)));
|
|
env.close();
|
|
|
|
env(pay(gw, alice, USD(50)));
|
|
env(pay(gw, alice, CNY(50)));
|
|
env(offer(alice, CNY(2), XRP(1000)));
|
|
|
|
Json::Value params;
|
|
params[jss::account] = alice.human();
|
|
auto const result =
|
|
env.rpc("json", "owner_info", to_string(params))[jss::result];
|
|
if (!BEAST_EXPECT(
|
|
result.isMember(jss::accepted) &&
|
|
result.isMember(jss::current)))
|
|
{
|
|
return;
|
|
}
|
|
|
|
// accepted ledger entry
|
|
if (!BEAST_EXPECT(result[jss::accepted].isMember(jss::ripple_lines)))
|
|
return;
|
|
auto lines = result[jss::accepted][jss::ripple_lines];
|
|
if (!BEAST_EXPECT(lines.isArray() && lines.size() == 2))
|
|
return;
|
|
|
|
BEAST_EXPECT(
|
|
lines[0u][sfBalance.fieldName] ==
|
|
(STAmount{Issue{to_currency("CNY"), noAccount()}, 0}
|
|
.value()
|
|
.getJson(JsonOptions::none)));
|
|
BEAST_EXPECT(
|
|
lines[0u][sfHighLimit.fieldName] ==
|
|
alice["CNY"](1000).value().getJson(JsonOptions::none));
|
|
BEAST_EXPECT(
|
|
lines[0u][sfLowLimit.fieldName] ==
|
|
gw["CNY"](0).value().getJson(JsonOptions::none));
|
|
|
|
BEAST_EXPECT(
|
|
lines[1u][sfBalance.fieldName] ==
|
|
(STAmount{Issue{to_currency("USD"), noAccount()}, 0}
|
|
.value()
|
|
.getJson(JsonOptions::none)));
|
|
BEAST_EXPECT(
|
|
lines[1u][sfHighLimit.fieldName] ==
|
|
alice["USD"](1000).value().getJson(JsonOptions::none));
|
|
BEAST_EXPECT(
|
|
lines[1u][sfLowLimit.fieldName] ==
|
|
USD(0).value().getJson(JsonOptions::none));
|
|
|
|
if (!BEAST_EXPECT(result[jss::accepted].isMember(jss::offers)))
|
|
return;
|
|
auto offers = result[jss::accepted][jss::offers];
|
|
if (!BEAST_EXPECT(offers.isArray() && offers.size() == 1))
|
|
return;
|
|
|
|
BEAST_EXPECT(offers[0u][jss::Account] == alice.human());
|
|
BEAST_EXPECT(
|
|
offers[0u][sfTakerGets.fieldName] ==
|
|
XRP(1000).value().getJson(JsonOptions::none));
|
|
BEAST_EXPECT(
|
|
offers[0u][sfTakerPays.fieldName] ==
|
|
USD(1).value().getJson(JsonOptions::none));
|
|
|
|
// current ledger entry
|
|
if (!BEAST_EXPECT(result[jss::current].isMember(jss::ripple_lines)))
|
|
return;
|
|
lines = result[jss::current][jss::ripple_lines];
|
|
if (!BEAST_EXPECT(lines.isArray() && lines.size() == 2))
|
|
return;
|
|
|
|
BEAST_EXPECT(
|
|
lines[0u][sfBalance.fieldName] ==
|
|
(STAmount{Issue{to_currency("CNY"), noAccount()}, -50}
|
|
.value()
|
|
.getJson(JsonOptions::none)));
|
|
BEAST_EXPECT(
|
|
lines[0u][sfHighLimit.fieldName] ==
|
|
alice["CNY"](1000).value().getJson(JsonOptions::none));
|
|
BEAST_EXPECT(
|
|
lines[0u][sfLowLimit.fieldName] ==
|
|
gw["CNY"](0).value().getJson(JsonOptions::none));
|
|
|
|
BEAST_EXPECT(
|
|
lines[1u][sfBalance.fieldName] ==
|
|
(STAmount{Issue{to_currency("USD"), noAccount()}, -50}
|
|
.value()
|
|
.getJson(JsonOptions::none)));
|
|
BEAST_EXPECT(
|
|
lines[1u][sfHighLimit.fieldName] ==
|
|
alice["USD"](1000).value().getJson(JsonOptions::none));
|
|
BEAST_EXPECT(
|
|
lines[1u][sfLowLimit.fieldName] ==
|
|
gw["USD"](0).value().getJson(JsonOptions::none));
|
|
|
|
if (!BEAST_EXPECT(result[jss::current].isMember(jss::offers)))
|
|
return;
|
|
offers = result[jss::current][jss::offers];
|
|
// 1 additional offer in current, (2 total)
|
|
if (!BEAST_EXPECT(offers.isArray() && offers.size() == 2))
|
|
return;
|
|
|
|
BEAST_EXPECT(offers[1u] == result[jss::accepted][jss::offers][0u]);
|
|
BEAST_EXPECT(offers[0u][jss::Account] == alice.human());
|
|
BEAST_EXPECT(
|
|
offers[0u][sfTakerGets.fieldName] ==
|
|
XRP(1000).value().getJson(JsonOptions::none));
|
|
BEAST_EXPECT(
|
|
offers[0u][sfTakerPays.fieldName] ==
|
|
CNY(2).value().getJson(JsonOptions::none));
|
|
}
|
|
|
|
public:
|
|
void
|
|
run() override
|
|
{
|
|
testBadInput();
|
|
testBasic();
|
|
}
|
|
};
|
|
|
|
BEAST_DEFINE_TESTSUITE(OwnerInfo, app, ripple);
|
|
|
|
} // namespace ripple
|