mirror of
https://github.com/XRPLF/rippled.git
synced 2025-12-06 17:27:55 +00:00
Artifactory support was added to the `nix` builds with #4556. This extends that support to the Windows build. Now the Windows build works; CI will build and test a Windows release build. This only affects CI and does not change any C++ code. * Copy the remote setup step outcome fix from #4716 discussion * Allow the Windows job to succeed if tests fail: * Currently the tests do not always pass, even on a single threaded run on the GitHub runners. So we are using parallel runs and mark the test step as allowed to fail (continue-on-error). * At this point, it's more important that the build succeeds than that the tests succeed, because: * We've got plenty of test coverage on the other jobs. * Test failures are much rarer than build failures because of cross-platform issues. * Having a test failure locally doesn't interrupt a workflow nearly as much as a build failure. Note that Conan Center cannot hold the binaries we need. They do not build the configurations we need, and they will not add them. ## Future Tasks This introduces a new bottleneck since the build and test takes over an hour. Speed up the job by: * Making this job run on heavy Windows runners. * Increasing the number of hardware threads.
101 lines
3.8 KiB
YAML
101 lines
3.8 KiB
YAML
name: windows
|
|
|
|
on: [push, pull_request]
|
|
|
|
# https://docs.github.com/en/actions/using-jobs/using-concurrency
|
|
concurrency:
|
|
group: ${{ github.workflow }}-${{ github.ref }}
|
|
cancel-in-progress: true
|
|
|
|
jobs:
|
|
|
|
test:
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
generator:
|
|
- Visual Studio 16 2019
|
|
configuration:
|
|
- Release
|
|
# Github hosted runners tend to hang when running Debug unit tests.
|
|
# Instead of trying to work around it, disable the Debug job until
|
|
# something beefier (i.e. a heavy self-hosted runner) becomes
|
|
# available.
|
|
# - Debug
|
|
runs-on: windows-2019
|
|
env:
|
|
build_dir: .build
|
|
steps:
|
|
- name: checkout
|
|
uses: actions/checkout@v3
|
|
- name: choose Python
|
|
uses: actions/setup-python@v3
|
|
with:
|
|
python-version: 3.9
|
|
- name: learn Python cache directory
|
|
id: pip-cache
|
|
shell: bash
|
|
run: |
|
|
pip install --upgrade pip
|
|
echo "dir=$(pip cache dir)" | tee ${GITHUB_OUTPUT}
|
|
- name: restore Python cache directory
|
|
uses: actions/cache@v3
|
|
with:
|
|
path: ${{ steps.pip-cache.outputs.dir }}
|
|
key: ${{ runner.os }}-${{ hashFiles('.github/workflows/windows.yml') }}
|
|
- name: install Conan
|
|
run: pip install wheel 'conan<2'
|
|
- name: check environment
|
|
run: |
|
|
$env:PATH -split ';'
|
|
python --version
|
|
conan --version
|
|
cmake --version
|
|
dir env:
|
|
- name: configure Conan
|
|
shell: bash
|
|
env:
|
|
CONAN_URL: http://18.143.149.228:8081/artifactory/api/conan/conan-non-prod
|
|
run: |
|
|
conan profile new default --detect
|
|
conan profile update settings.compiler.runtime=MT${{ matrix.configuration == 'Debug' && 'd' || '' }} default
|
|
# Do not quote the URL. An empty string will be accepted (with
|
|
# a non-fatal warning), but a missing argument will not.
|
|
conan remote add ripple ${{ env.CONAN_URL }} --insert 0
|
|
- name: try to authenticate to ripple Conan remote
|
|
shell: bash
|
|
id: remote
|
|
run: |
|
|
echo outcome=$(conan user --remote ripple ${{ secrets.CONAN_USERNAME }} \
|
|
--password ${{ secrets.CONAN_TOKEN }} >&2 && echo success || \
|
|
echo failure) | tee ${GITHUB_OUTPUT}
|
|
- name: list missing binaries
|
|
id: binaries
|
|
shell: bash
|
|
# Print the list of dependencies that would need to be built locally.
|
|
# A non-empty list means we have "failed" to cache binaries remotely.
|
|
run: |
|
|
echo missing=$(conan info . --build missing --settings build_type=${{ matrix.configuration }} --json 2>/dev/null | grep '^\[') | tee ${GITHUB_OUTPUT}
|
|
- name: build dependencies
|
|
uses: ./.github/actions/dependencies
|
|
with:
|
|
configuration: ${{ matrix.configuration }}
|
|
- name: upload dependencies to remote
|
|
if: (steps.binaries.outputs.missing != '[]') && (steps.remote.outputs.outcome == 'success')
|
|
run: conan upload --remote ripple '*' --all --parallel --confirm
|
|
- name: build
|
|
uses: ./.github/actions/build
|
|
with:
|
|
generator: '${{ matrix.generator }}'
|
|
configuration: ${{ matrix.configuration }}
|
|
# Hard code for now. Move to the matrix if varied options are needed
|
|
cmake-args: '-Dassert=ON -Dreporting=OFF -Dunity=OFF'
|
|
- name: test (permitted to silently fail)
|
|
shell: bash
|
|
# Github runners are resource limited, which causes unit tests to fail
|
|
# (e.g. OOM). To allow forward progress until self-hosted runners are
|
|
# up and running reliably, allow the job to succeed even if tests fail.
|
|
continue-on-error: true
|
|
run: |
|
|
${build_dir}/${{ matrix.configuration }}/rippled --unittest --unittest-jobs $(nproc)
|