mirror of
https://github.com/XRPLF/rippled.git
synced 2026-06-05 09:46:53 +00:00
097e0349fe
Move the invariant-check orchestration out of ApplyContext and Transactor into a free function xrpl::checkInvariants(ApplyContext&, TER, XRPAmount, optional<reference_wrapper<InvariantCheck>>). The two previously separate traversals (one in ApplyContext driving the protocol tuple fold, one in Transactor driving the tx-specific check) are merged into a single ctx.visit walk. Per-layer try/catch inside the lambda isolates collection faults: a throw in one layer stops only that layer from visiting further entries while the other continues. A layer whose collection faulted skips its finalize phase. ApplyContext loses checkInvariants/checkInvariantsHelper/failInvariantCheck. Transactor delegates to the free runner via a private InvariantCheckAdapter that bridges visitInvariantEntry+finalizeInvariants into the InvariantCheck interface. A SkipTxInvariants::Yes/No enum makes the fee-claim-reset call site explicit about omitting the tx-specific check. Protocol checks remain duck-typed in the InvariantChecks tuple (static dispatch, no vtable on the hot path). InvariantCheck is the runtime interface used only by InvariantCheckAdapter.
73 lines
1.8 KiB
C++
73 lines
1.8 KiB
C++
#include <xrpl/tx/ApplyContext.h>
|
|
|
|
#include <xrpl/basics/Log.h>
|
|
#include <xrpl/basics/base_uint.h>
|
|
#include <xrpl/beast/utility/Journal.h>
|
|
#include <xrpl/beast/utility/instrumentation.h>
|
|
#include <xrpl/core/ServiceRegistry.h>
|
|
#include <xrpl/json/to_string.h>
|
|
#include <xrpl/ledger/ApplyView.h>
|
|
#include <xrpl/ledger/OpenView.h>
|
|
#include <xrpl/protocol/STTx.h>
|
|
#include <xrpl/protocol/TER.h>
|
|
#include <xrpl/protocol/TxMeta.h>
|
|
#include <xrpl/protocol/XRPAmount.h>
|
|
|
|
#include <cstddef>
|
|
#include <functional>
|
|
#include <optional>
|
|
|
|
namespace xrpl {
|
|
|
|
ApplyContext::ApplyContext(
|
|
ServiceRegistry& registry,
|
|
OpenView& base,
|
|
std::optional<uint256 const> const& parentBatchId,
|
|
STTx const& tx,
|
|
TER preclaimResult,
|
|
XRPAmount baseFee,
|
|
ApplyFlags flags,
|
|
beast::Journal journal)
|
|
: registry(registry)
|
|
, tx(tx)
|
|
, preclaimResult(preclaimResult)
|
|
, baseFee(baseFee)
|
|
, journal(journal)
|
|
, base_(base)
|
|
, flags_(flags)
|
|
, parentBatchId_(parentBatchId)
|
|
{
|
|
XRPL_ASSERT(
|
|
parentBatchId.has_value() == ((flags_ & TapBatch) == TapBatch),
|
|
"Parent Batch ID should be set if batch apply flag is set");
|
|
view_.emplace(&base_, flags_);
|
|
}
|
|
|
|
void
|
|
ApplyContext::discard()
|
|
{
|
|
view_.emplace(&base_, flags_);
|
|
}
|
|
|
|
std::optional<TxMeta>
|
|
ApplyContext::apply(TER ter)
|
|
{
|
|
// NOLINTNEXTLINE(bugprone-unchecked-optional-access) view_ emplaced in constructor
|
|
return view_->apply(base_, tx, ter, parentBatchId_, (flags_ & TapDryRun) != 0u, journal);
|
|
}
|
|
|
|
std::size_t
|
|
ApplyContext::size()
|
|
{
|
|
return view_->size(); // NOLINT(bugprone-unchecked-optional-access)
|
|
}
|
|
|
|
void
|
|
ApplyContext::visit(
|
|
std::function<void(uint256 const&, bool, SLE::const_ref, SLE::const_ref)> const& func)
|
|
{
|
|
view_->visit(base_, func); // NOLINT(bugprone-unchecked-optional-access)
|
|
}
|
|
|
|
} // namespace xrpl
|