mirror of
https://github.com/XRPLF/rippled.git
synced 2026-06-05 01:37:00 +00:00
87eb3fcf3b
IOUAmount::normalize() previously built a Number (one normalize pass to the default Large range) and then re-normalized down to the narrower IOU range via fromNumber (a second pass) -- two full passes where one would do. Add a static Number::normalizeToRange<Min,Max>(mantissa, exponent) that normalizes raw integers straight to a target range in a single pass, building no intermediate Number. Refactor the existing const member overload to share one implementation, so both paths have a single source of truth. Rewire the getSTNumberSwitchover()-true branch of IOUAmount::normalize() to call the new primitive. The result is bit-identical to the old two-pass path: an intermediate pass to a strictly wider range cannot change the final narrower-range result. Equivalence is proven by new GTests that sweep mantissa/exponent boundaries, negatives, int64 extremes, rounding cusps, and all four rounding modes against the prior two-pass result, plus exact-value assertions on hand-computed cases. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Basics
Utility functions and classes.
The module xrpl/basics should contain no dependencies on other modules.
Choosing an xrpld container.
-
std::vector- For ordered containers with most insertions or erases at the end.
-
std::deque- For ordered containers with most insertions or erases at the start or end.
-
std::list- For ordered containers with inserts and erases to the middle.
- For containers with iterators stable over insert and erase.
- Generally slower and bigger than
std::vectororstd::dequeexcept for those cases.
-
std::set- For sorted containers.
-
xrpl::hash_set- Where inserts and contains need to be O(1).
- For "small" sets,
std::setmight be faster and smaller.
-
xrpl::hardened_hash_set- For data sets where the key could be manipulated by an attacker in an attempt to mount an algorithmic complexity attack: see http://en.wikipedia.org/wiki/Algorithmic_complexity_attack
The following container is deprecated
std::unordered_set- Use
xrpl::hash_setinstead, which uses a better hashing algorithm. - Or use
xrpl::hardened_hash_setto prevent algorithmic complexity attacks.