Pratik Mankawde
f4a454c099
fix: Address code review comments regarding boost::coroutine2 ( #6977 )
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-05-04 10:13:54 -04:00
Bart
3054fb8852
refactor: Apply various minor improvements and corrections ( #7045 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-05-04 10:13:54 -04:00
Zhiyuan Wang
4da46d31ac
fix: Store Delegate object in delegating and authorized account directories for proper deletion ( #6681 )
2026-05-04 10:13:54 -04:00
Alex Kremer
1c6fab8345
chore: Enable clang-tidy v21 new checks ( #7031 )
2026-05-04 10:13:54 -04:00
Jingchen
60fc9da97e
feat: Create new transaction testing framework TxTest ( #6537 )
...
Signed-off-by: JCW <a1q123456@users.noreply.github.com >
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
Co-authored-by: Copilot <copilot@github.com >
2026-05-04 10:13:54 -04:00
Vito Tumas
168bc7bdc7
feat: Add cleanup amendment for 3.2.0 ( #7037 )
2026-05-04 10:13:54 -04:00
Pratik Mankawde
62c49eb1b4
fix: Fix ubsan flagged issues ( #6151 )
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com >
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-05-04 10:13:54 -04:00
Alex Kremer
917acc59e0
chore: Enable clang-tidy modernize-use-nodiscard check ( #7015 )
2026-05-04 10:13:53 -04:00
Pratik Mankawde
47c620cc04
fix: Resolve MSVC Debug build failure in JobQueue.h; re-enable _CRTDBG_MAP_ALLOC in CI ( #6993 )
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
Co-authored-by: Ed Hennis <ed@ripple.com >
2026-05-04 10:13:53 -04:00
Mayukha Vadari
b8792e2422
fix: Make assorted Payments fixes ( #6585 )
2026-05-04 10:13:53 -04:00
Mayukha Vadari
f42915d61b
refactor: Move LendingHelpers into libxrpl/ledger/helpers ( #6638 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-05-04 10:13:53 -04:00
Alex Kremer
7345de6c67
fix: Remaining clang-tidy unchecked optionals ( #6979 )
2026-05-04 10:13:53 -04:00
Jingchen
3f9a83be41
refactor: Remove seq from TMGetObjectByHash ( #6976 )
2026-05-04 10:13:52 -04:00
Mayukha Vadari
2a30934bb1
fix: More clang-tidy issues ( #6992 )
2026-05-04 10:13:52 -04:00
Vito Tumas
998daf6e20
refactor: Add transaction-specific invariant checking ( #6551 )
2026-05-04 10:13:52 -04:00
Alex Kremer
dab0ceaf8b
chore: Enable clang-tidy modernize checks ( #6975 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-05-04 10:13:51 -04:00
Alex Kremer
394c7cab80
fix: Add rounding to Vault invariants ( #6217 ) ( #6955 )
...
Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com >
Co-authored-by: Ed Hennis <ed@ripple.com >
2026-05-04 10:13:51 -04:00
Zhiyuan Wang
6c9244e810
fix: Check for empty sfAdditionalBooks array in hybrid offer invariant ( #6716 )
2026-05-04 10:13:51 -04:00
Alex Kremer
9e8ac41983
chore: Enable clang-tidy include cleaner ( #6947 )
2026-05-04 10:13:50 -04:00
Alex Kremer
3e67c0f71d
chore: Enable clang-tidy readability checks ( #6930 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-05-04 10:13:49 -04:00
Sergey Kuznetsov
392c87349f
chore: Move codegen venv setup into build stage ( #6617 )
...
Co-authored-by: JCW <a1q123456@users.noreply.github.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-05-04 10:13:49 -04:00
Alex Kremer
09ea87c12e
chore: Enable most clang-tidy bugprone checks ( #6929 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-05-04 10:13:49 -04:00
Bart
f85e2d5bbe
refactor: Improve exception handling ( #6540 ) ( #6735 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-05-04 10:13:48 -04:00
Zhiyuan Wang
5a1db481df
refactor: Remove unused notTooManyOffers function from NFTokenUtils ( #6737 )
2026-05-04 10:13:48 -04:00
yinyiqian1
058ccb4da6
fix: Address AI reviewer comments for Permission Delegation ( #6675 )
2026-05-04 10:13:48 -04:00
Mayukha Vadari
70b770f99b
refactor: Combine AMMHelpers and AMMUtils ( #6733 )
2026-05-04 10:13:47 -04:00
Gregory Tsipenyuk
27c28be574
feat: Add MPT support to DEX ( #5285 )
2026-05-04 10:13:47 -04:00
Bart
79a3ab4c22
refactor: Rename non-functional uses of ripple(d) to xrpl(d) ( #6676 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-05-04 10:13:47 -04:00
Mayukha Vadari
f2a7ee0067
refactor: Move more helper files into libxrpl/ledger/helpers ( #6731 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-05-04 10:13:46 -04:00
Alex Kremer
f04943fc50
chore: Enable clang-tidy coreguidelines checks ( #6698 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-04-01 13:27:23 -04:00
Alex Kremer
2dc705bd99
chore: Enable clang-tidy misc checks ( #6655 )
2026-04-01 13:27:22 -04:00
Bart
5a66086fce
chore: Remove unnecessary clang-format off/on directives ( #6682 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-04-01 13:27:21 -04:00
Alex Kremer
453d94da17
chore: Enable remaining clang-tidy performance checks ( #6648 )
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2026-03-30 14:52:09 -04:00
Jingchen
b36aedb4d5
refactor: Address PR comments after the modularisation PRs ( #6389 )
...
Signed-off-by: JCW <a1q123456@users.noreply.github.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-03-30 14:52:09 -04:00
Pratik Mankawde
0c76bf991a
fix: Guard Coro::resume() against completed coroutines ( #6608 )
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com >
2026-03-30 14:52:08 -04:00
Vito Tumas
29aba28f5b
refactor: Split LoanInvariant into LoanBrokerInvariant and LoanInvariant ( #6674 )
2026-03-30 14:52:08 -04:00
Jingchen
e26624dcd1
refactor: Make function naming in ServiceRegistry consistent ( #6390 )
...
Signed-off-by: JCW <a1q123456@users.noreply.github.com >
Co-authored-by: Ed Hennis <ed@ripple.com >
2026-03-30 14:52:08 -04:00
Vito Tumas
b9d07730f3
feat: Add placeholder amendment for assorted bug fixes ( #6652 )
2026-03-25 23:54:33 +00:00
Jingchen
8f182e825a
refactor: Modularise ledger ( #6536 )
...
Signed-off-by: JCW <a1q123456@users.noreply.github.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
Co-authored-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-03-25 16:32:45 +00:00
Alex Kremer
0eedefbf45
refactor: Enable more clang-tidy readability checks ( #6595 )
...
Co-authored-by: Sergey Kuznetsov <kuzzz99@gmail.com >
2026-03-24 15:42:12 +00:00
Mayukha Vadari
8b986e4ab0
refactor: Improve imports to only call the needed helpers ( #6624 )
2026-03-24 10:20:32 +00:00
Mayukha Vadari
e0dbe90370
refactor: Move ledger entry helper functions from View.h/View.cpp to dedicated helper files ( #6453 )
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2026-03-23 15:39:58 +00:00
Jingchen
b1e5ba0518
feat: Add code generator for transactions and ledger entries ( #6443 )
...
Signed-off-by: JCW <a1q123456@users.noreply.github.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-03-18 21:11:51 +00:00
Mayukha Vadari
d360e7c5b6
refactor: Rename transactor files/classes to match the tx name ( #6580 )
2026-03-18 19:52:07 +00:00
Alex Kremer
57e4cbbcd9
refactor: Add simple clang-tidy readability checks ( #6556 )
...
This change enables the following clang-tidy checks:
- readability-avoid-nested-conditional-operator,
- readability-avoid-return-with-void-value,
- readability-braces-around-statements,
- readability-const-return-type,
- readability-container-contains,
- readability-container-size-empty,
- readability-else-after-return,
- readability-make-member-function-const,
- readability-redundant-casting,
- readability-redundant-inline-specifier,
- readability-redundant-member-init,
- readability-redundant-string-init,
- readability-reference-to-constructed-temporary,
- readability-static-definition
2026-03-18 16:41:49 +00:00
Mayukha Vadari
b92a9a3053
fix: Make assorted NFT fixes ( #6566 )
...
This change:
* Removes a set of unnecessary brackets in the initialization of an `std::uint32_t`.
* Fixes a couple of incorrect flags (same value, just wrong variables - so no amendment needed).
2026-03-18 14:47:59 +00:00
Mayukha Vadari
dcaef828b4
refactor: Replace !=/== tesSuccess with using isTesSuccess ( #6409 )
...
This change replaces all instances of `<variable> != tesSUCCESS` with `!isTesSuccess(<variable>)` and `<variable> == tesSUCCESS` with `isTesSuccess(<variable>)`.
2026-03-18 14:15:10 +00:00
Copilot
9e14707e77
fix: Peer crawler port field type inconsistency ( #6318 )
...
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com >
Co-authored-by: mvadari <8029314+mvadari@users.noreply.github.com >
Co-authored-by: Mayukha Vadari <mvadari@gmail.com >
Co-authored-by: Mayukha Vadari <mvadari@ripple.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-03-17 22:03:56 +00:00
tequ
b129b71c33
refactor: Use ReadView instead of ApplyView in authorizedDepositPreauth() ( #6560 )
2026-03-17 15:56:51 -04:00
tequ
013c2d6a56
refactor: Add const qualifier to SLE in verifyDepositPreauth parameter ( #6555 )
2026-03-17 19:33:18 +00:00