Pratik Mankawde
de49319b31
Merge branch 'pratik/otel-phase8-log-correlation' into pratik/otel-phase9-metric-gap-fill
2026-07-20 12:19:45 +01:00
Pratik Mankawde
4908b82077
Merge branch 'pratik/otel-phase6-statsd' into pratik/otel-phase7-native-metrics
2026-07-20 12:19:28 +01:00
Pratik Mankawde
c3b1f69ba8
Merge branch 'pratik/otel-phase3-tx-tracing' into pratik/otel-phase4-consensus-tracing
...
# Conflicts:
# include/xrpl/telemetry/SpanGuard.h
# src/xrpld/app/consensus/RCLConsensus.h
# src/xrpld/consensus/ConsensusTypes.h
2026-07-20 12:10:44 +01:00
Pratik Mankawde
4e9b2f23d6
Merge branch 'pratik/otel-phase2-rpc-tracing' into pratik/otel-phase3-tx-tracing
...
# Conflicts:
# include/xrpl/telemetry/SpanGuard.h
# src/libxrpl/telemetry/SpanGuard.cpp
# src/libxrpl/tx/applySteps.cpp
2026-07-20 12:03:57 +01:00
Pratik Mankawde
d7a014ae95
Merge branch 'pratik/otel-phase1c-rpc-integration' into pratik/otel-phase2-rpc-tracing
2026-07-20 11:50:55 +01:00
Pratik Mankawde
98a2ad19fd
Merge branch 'pratik/otel-phase1b-telemetry-infra' into pratik/otel-phase1c-rpc-integration
...
# Conflicts:
# include/xrpl/telemetry/SpanGuard.h
2026-07-17 19:45:15 +01:00
Pratik Mankawde
7be57a460b
Merge branch 'pratik/otel-phase1a-plan-docs' into pratik/otel-phase1b-telemetry-infra
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-07-17 14:27:46 +01:00
Andrzej Budzanowski
701311f27e
test: Add google benchmark dependency and migrate nodestore timing test as a benchmark ( #7317 )
...
Co-authored-by: Marek Foss <marek.foss@neti-soft.com >
Co-authored-by: Alex Kremer <akremer@ripple.com >
2026-07-16 15:44:43 +00:00
Ed Hennis
530e09dbe8
fix: Update base_uint and test changes released in 3.1.3 ( #7570 )
...
Co-authored-by: Sergey Kuznetsov <skuznetsov@ripple.com >
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-07-14 18:48:10 +00:00
Pratik Mankawde
9819abba3a
Merge branch 'pratik/otel-phase8-log-correlation' into pratik/otel-phase9-metric-gap-fill
2026-07-08 16:02:58 +01:00
Pratik Mankawde
12060bc219
Merge branch 'pratik/otel-phase6-statsd' into pratik/otel-phase7-native-metrics
2026-07-08 16:02:58 +01:00
Pratik Mankawde
a8ce1408a9
Merge branch 'pratik/otel-phase1b-telemetry-infra' into pratik/otel-phase1c-rpc-integration
2026-07-08 16:02:51 +01:00
Pratik Mankawde
c0a3e113d9
Merge branch 'pratik/otel-phase1c-rpc-integration' into pratik/otel-phase2-rpc-tracing
2026-07-08 16:02:51 +01:00
Pratik Mankawde
02b32ecdd8
Merge branch 'pratik/otel-phase3-tx-tracing' into pratik/otel-phase4-consensus-tracing
2026-07-08 16:02:51 +01:00
Pratik Mankawde
61ae9998e1
Merge branch 'pratik/otel-phase2-rpc-tracing' into pratik/otel-phase3-tx-tracing
2026-07-08 16:02:51 +01:00
Pratik Mankawde
22f5b77e0c
Merge branch 'pratik/otel-phase1a-plan-docs' into pratik/otel-phase1b-telemetry-infra
2026-07-08 16:02:43 +01:00
Pratik Mankawde
8919be22bf
levelization
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-07-07 17:53:45 +01:00
Pratik Mankawde
dce39bc71d
Merge branch 'pratik/otel-phase8-log-correlation' into pratik/otel-phase9-metric-gap-fill
...
# Conflicts:
# OpenTelemetryPlan/08-appendix.md
# OpenTelemetryPlan/presentation.md
# docker/telemetry/xrpld-telemetry.cfg
# docs/telemetry-runbook.md
2026-07-06 22:06:45 +01:00
Pratik Mankawde
363c2caf94
Merge branch 'pratik/otel-phase6-statsd' into pratik/otel-phase7-native-metrics
...
# Conflicts:
# OpenTelemetryPlan/08-appendix.md
# OpenTelemetryPlan/09-data-collection-reference.md
# docker/telemetry/docker-compose.yml
# docker/telemetry/grafana/dashboards/statsd-ledger-data-sync.json
# docker/telemetry/grafana/dashboards/statsd-network-traffic.json
# docker/telemetry/grafana/dashboards/statsd-node-health.json
# docker/telemetry/grafana/dashboards/statsd-rpc-pathfinding.json
2026-07-06 22:01:22 +01:00
Pratik Mankawde
ea9c639ee9
Merge branch 'pratik/otel-phase3-tx-tracing' into pratik/otel-phase4-consensus-tracing
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-07-06 20:50:24 +01:00
Marek Foss
f5e63f8a91
test: Migrate basics Beast tests to GTest ( #7136 )
...
Co-authored-by: Alex Kremer <akremer@ripple.com >
2026-07-06 19:48:36 +00:00
Pratik Mankawde
e02b7968ad
Merge branch 'pratik/otel-phase2-rpc-tracing' into pratik/otel-phase3-tx-tracing
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-07-06 20:41:14 +01:00
Pratik Mankawde
38f6afbf4c
code review comments
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-07-06 20:40:12 +01:00
Pratik Mankawde
7a6ff619e5
code review changes
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-07-06 20:37:08 +01:00
Marek Foss
7a153a2bce
test: Migrate resource, shamap Beast tests to GTest ( #7133 )
...
Co-authored-by: Alex Kremer <akremer@ripple.com >
2026-07-06 17:26:19 +00:00
Pratik Mankawde
206d386469
Merge branch 'pratik/otel-phase8-log-correlation' into pratik/otel-phase9-metric-gap-fill
...
# Conflicts:
# src/xrpld/app/ledger/InboundLedger.h
# src/xrpld/perflog/detail/PerfLogImp.cpp
2026-07-06 17:17:21 +01:00
Pratik Mankawde
fd518d3e7b
Merge branch 'pratik/otel-phase6-statsd' into pratik/otel-phase7-native-metrics
...
# Conflicts:
# .github/scripts/levelization/results/ordering.txt
# include/xrpl/beast/insight/Insight.h
# src/test/csf/Peer.h
2026-07-06 17:15:27 +01:00
Pratik Mankawde
e969b0c6ed
Merge branch 'pratik/otel-phase3-tx-tracing' into pratik/otel-phase4-consensus-tracing
...
# Conflicts:
# src/test/csf/Peer.h
# src/xrpld/app/consensus/RCLConsensus.h
2026-07-06 17:11:29 +01:00
Pratik Mankawde
33c17e50b3
Merge branch 'pratik/otel-phase2-rpc-tracing' into pratik/otel-phase3-tx-tracing
2026-07-06 17:09:47 +01:00
Pratik Mankawde
e129b0793c
Merge branch 'pratik/otel-phase1c-rpc-integration' into pratik/otel-phase2-rpc-tracing
...
# Conflicts:
# src/tests/libxrpl/CMakeLists.txt
2026-07-06 17:09:33 +01:00
Pratik Mankawde
45aa2f276a
Merge branch 'pratik/otel-phase1b-telemetry-infra' into pratik/otel-phase1c-rpc-integration
...
# Conflicts:
# .github/scripts/levelization/results/loops.txt
2026-07-06 17:08:46 +01:00
Pratik Mankawde
3789ac45e2
Merge branch 'pratik/otel-phase1a-plan-docs' into pratik/otel-phase1b-telemetry-infra
...
# Conflicts:
# conan.lock
# conan/profiles/default
# conanfile.py
2026-07-06 17:07:23 +01:00
Ayaz Salikhov
8e378c4f47
build: Add verify-headers target to cleanup headers ( #7670 )
2026-07-01 23:14:17 +00:00
Pratik Mankawde
fa46aa55fc
Merge branch 'pratik/otel-phase8-log-correlation' into pratik/otel-phase9-metric-gap-fill
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-26 16:23:16 +01:00
Pratik Mankawde
3cfec0f1e0
Merge branch 'pratik/otel-phase6-statsd' into pratik/otel-phase7-native-metrics
2026-06-26 14:50:05 +01:00
Pratik Mankawde
bc7cff230c
Merge branch 'pratik/otel-phase3-tx-tracing' into pratik/otel-phase4-consensus-tracing
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-26 14:45:43 +01:00
Pratik Mankawde
54d92ff973
Merge branch 'pratik/otel-phase2-rpc-tracing' into pratik/otel-phase3-tx-tracing
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-26 14:42:55 +01:00
Pratik Mankawde
9a2d682a42
Merge branch 'pratik/otel-phase1c-rpc-integration' into pratik/otel-phase2-rpc-tracing
2026-06-26 14:33:16 +01:00
Pratik Mankawde
9d4570f65c
Merge branch 'pratik/otel-phase1b-telemetry-infra' into pratik/otel-phase1c-rpc-integration
2026-06-26 14:29:59 +01:00
Pratik Mankawde
49103d635c
Merge branch 'pratik/otel-phase1a-plan-docs' into pratik/otel-phase1b-telemetry-infra
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-26 14:24:30 +01:00
Ayaz Salikhov
eef8f4a4ff
chore: Use clang-tidy v22 new features ( #7427 )
2026-06-24 17:23:29 +00:00
Pratik Mankawde
cccce1c32e
Merge remote-tracking branch 'origin/release/3.2.x' into pratik/merge_3.2.x
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-17 12:53:02 +01:00
Pratik Mankawde
f98c251011
refactor: Improve tracking of book (un)subscriptions
2026-06-15 22:23:38 +01:00
Pratik Mankawde
25227141b3
Merge branch 'pratik/otel-phase8-log-correlation' into pratik/otel-phase9-metric-gap-fill
...
Bring phase-8 (log correlation) and the naming-check + BasicConfig fixes forward
into phase 9 (native-metrics gap fill). Phase 9 adds MetricsRegistry and
LedgerSpanNames.h.
Conflict resolution:
- presentation.md: took phase-9's restructured deck — sampling now lives in
Slide 8 (Head vs Tail) and the Phase 10/11/12 future-phase slides; phase-8's
older standalone sampling section is superseded (no content lost).
- ordering.txt/loops.txt: regenerated via generate.py.
Naming check: A/B/E/F/G green. Rule D reports 6 findings that are all check
gaps, not data errors (verified every dashboard label traces to code):
- 3 are TraceQL `span.<attr>` references (bare attr is in L1); Rule D should
strip the span./resource. scope prefix.
- 2 (`reason`, `job_type`) are native OTel metric labels emitted by
MetricsRegistry.cpp — a new source of truth the check does not yet model.
The Rule D enhancement lands on phase-1c and merges forward.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com >
2026-06-11 19:11:54 +01:00
Pratik Mankawde
2efc932165
Merge branch 'pratik/otel-phase6-statsd' into pratik/otel-phase7-native-metrics
...
Bring the hardened OTel naming check (Rule E fix + 71 tests) and the phase 1-6
convention work forward into phase 7 (native metrics).
Conflict resolution:
- 05-configuration-reference.md: kept phase-7's native-OTLP metrics story
(server=otel, /v1/metrics) over phase-6's superseded StatsD scrape job, in
prose form (no code block).
- ordering.txt/loops.txt: regenerated via generate.py (not hand-edited).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com >
2026-06-11 18:32:21 +01:00
Pratik Mankawde
6c4c3e1049
layering
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-11 18:01:18 +01:00
Pratik Mankawde
85103e4550
levelization fix
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-11 17:16:36 +01:00
Pratik Mankawde
7cb08307a7
Merge branch 'pratik/otel-phase2-rpc-tracing' into pratik/otel-phase3-tx-tracing
...
Bring phase-2 forward into phase 3 (transaction tracing). Phase 3 introduces
TxSpanNames.h, TxQSpanNames.h, and TxApplySpanNames.h.
Conflict resolution:
- TxQ.cpp: kept phase-3's txq_span-based instrumentation (phase-2 had none).
Dropped the orphaned `NumberSO{... fixUniversalNumber}` line — develop's
#5962 (Retire fixUniversalNumber) removed that symbol repo-wide; the
conflict block had carried one stale copy that would not compile.
- 05/08/OpenTelemetryPlan.md: dropped the deleted 04-code-samples / POC_taskList
references (carried from phase-2), kept phase-3's new secure-OTel.md doc rows,
section, and Mermaid node/edge/style. Config code block -> prose; merged the
secure-OTel hardening pointer with the authoritative-config prose.
- Phase3_taskList.md: removed the "dotted keys for readability" note that came
from phase-2 — phase 3 already uses the underscore keys.
Reviewed by code-review agents: telemetry instrumentation intact, naming check
green (47 keys across 7 *SpanNames.h headers), no conflict markers.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com >
2026-06-11 16:45:34 +01:00
Pratik Mankawde
b1e6d90af1
ordering changes
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-11 16:29:06 +01:00
Pratik Mankawde
6c1d4d92bb
fix(telemetry): keep libxrpl SpanGuard test free of xrpld headers
...
The xrpl_tests target links only xrpl.libxrpl and cannot include the
xrpld-level ConsensusSpanNames.h / RpcSpanNames.h (CI build failure on
ubuntu-gcc-debug-arm64). Revert the test to underscore-form attribute
literals, restore the SpanNames.h include for seg::consensus, and drop
the now-unused tests.libxrpl -> xrpld.* levelization entries.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com >
2026-06-10 17:28:02 +01:00