Ed Hennis
edbb9daa36
Merge branch 'develop' into ximinez/fix-getledger
2026-05-13 22:31:59 -04:00
Bart
afbccf971a
chore: Consolidate fix amendments ( #7134 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-05-13 20:46:30 +00:00
Ed Hennis
2bcbef1b63
Merge branch 'develop' into ximinez/fix-getledger
2026-05-13 12:03:44 -04:00
Alex Kremer
e8bdbaa1e8
refactor: Limit JSON array size ( #7112 )
2026-05-13 12:42:05 +00:00
Vito Tumas
6340c986c9
feat: Enable and rename fixSecurity3_1_3 to fixCleanup3_1_3 ( #7128 )
...
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
2026-05-13 09:42:34 +00:00
Ed Hennis
9f0ca26875
Merge remote-tracking branch 'XRPLF/develop' into ximinez/fix-getledger
...
* XRPLF/develop:
refactor: Fill txJson based on apiVersion (7109)
fix: Fix touchy "funds are conserved" assertion in LoanPay (6231) (6967)
refactor: Remove erroneous base_uint ctor from container (7123)
ci: Make `Show test failure summary` work with no build dir (7124)
refactor: Replace `featureInvariantsV1_1` with `fixCleanup3_2_0` (7116)
2026-05-12 16:03:45 -04:00
Mayukha Vadari
c4c95dbe76
refactor: Replace featureInvariantsV1_1 with fixCleanup3_2_0 ( #7116 )
2026-05-12 12:26:02 +00:00
Ed Hennis
2aa493e0e4
Merge branch 'develop' into ximinez/fix-getledger
2026-05-11 13:34:17 -04:00
Alex Kremer
cdee9a675c
refactor: Use more scoped enums ( #7086 )
2026-05-11 15:39:48 +00:00
Ed Hennis
2ec1276b5f
Merge branch 'develop' into ximinez/fix-getledger
2026-05-07 13:28:38 -04:00
Alex Kremer
7afdd71a54
chore: More fixes for bad renames ( #7092 )
2026-05-07 17:04:30 +00:00
Ed Hennis
25d246fc92
Merge remote-tracking branch 'XRPLF/develop' into ximinez/fix-getledger
...
* XRPLF/develop:
ci: Rewrite clang-tidy workflow(s) in a reusable manner (7062)
chore: Ignore identifier-naming update in git blame (7066)
refactor: Enable clang-tidy `readability-identifier-naming` check (6571)
refactor: Revert certain `Throw`s by `LogicError`s (7036)
ci: Rename print-env -> print-build-env (7061)
fix: Gate -mcmodel flags to x86_64 in sanitizer builds (7049)
fix: Prevents overwriting a bool value in an invariant (6609)
fix: Address code review comments regarding `boost::coroutine2` (6977)
refactor: Apply various minor improvements and corrections (7045)
fix: Store `Delegate` object in delegating and authorized account directories for proper deletion (6681)
ci: Use print-env from XRPLF/actions (7052)
fix: Make assorted RPC fixes (6529)
chore: Enable clang-tidy v21 new checks (7031)
feat: Create new transaction testing framework `TxTest` (6537)
feat: Add cleanup amendment for 3.2.0 (7037)
fix: Fix ubsan flagged issues (6151)
2026-05-05 00:08:59 -04:00
Alex Kremer
8995564ed6
refactor: Enable clang-tidy readability-identifier-naming check ( #6571 )
2026-05-03 10:31:53 +00:00
Vito Tumas
31180f94c2
fix: Prevents overwriting a bool value in an invariant ( #6609 )
...
Co-authored-by: Ed Hennis <ed@ripple.com >
2026-04-30 13:05:09 +00:00
Bart
4d0ea8ae36
refactor: Apply various minor improvements and corrections ( #7045 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-04-30 10:22:11 +00:00
Zhiyuan Wang
dbd646bd53
fix: Store Delegate object in delegating and authorized account directories for proper deletion ( #6681 )
2026-04-29 18:17:01 +00:00
Alex Kremer
f7275b7ad9
chore: Enable clang-tidy v21 new checks ( #7031 )
2026-04-29 15:17:35 +00:00
Vito Tumas
147da57348
feat: Add cleanup amendment for 3.2.0 ( #7037 )
2026-04-28 10:22:32 +00:00
Ed Hennis
2881c08d2e
Merge branch 'develop' into ximinez/fix-getledger
2026-04-25 14:45:50 -04:00
Alex Kremer
4dc923dcc5
chore: Enable clang-tidy modernize-use-nodiscard check ( #7015 )
2026-04-24 17:19:30 +00:00
Ed Hennis
ddbe7e87fb
Merge branch 'develop' into ximinez/fix-getledger
2026-04-23 15:56:06 -04:00
Alex Kremer
19da25812b
fix: Remaining clang-tidy unchecked optionals ( #6979 )
2026-04-23 16:21:01 +00:00
Ed Hennis
85342554b7
Merge branch 'develop' into ximinez/fix-getledger
2026-04-22 14:49:08 -04:00
Mayukha Vadari
1c6cdc653c
fix: More clang-tidy issues ( #6992 )
2026-04-22 17:42:15 +00:00
Ed Hennis
55e5374f56
Merge branch 'develop' into ximinez/fix-getledger
2026-04-21 15:20:21 -04:00
Alex Kremer
ce3951bbb3
chore: Enable clang-tidy modernize checks ( #6975 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-04-21 15:32:51 +00:00
Alex Kremer
ea023121f5
fix: Add rounding to Vault invariants ( #6217 ) ( #6955 )
...
Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com >
Co-authored-by: Ed Hennis <ed@ripple.com >
2026-04-21 12:14:07 +00:00
Ed Hennis
8bb87e9ca9
Merge remote-tracking branch 'XRPLF/develop' into ximinez/fix-getledger
...
* XRPLF/develop:
chore: Enable clang-tidy include cleaner (6947)
fix: Change AMMClawback return code to tecNO_PERMISSION (6946)
ci: [DEPENDABOT] bump actions/upload-pages-artifact from 4.0.0 to 5.0.0 (6927)
ci: [DEPENDABOT] bump actions/upload-artifact from 7.0.0 to 7.0.1 (6928)
chore: Enable clang-tidy readability checks (6930)
2026-04-17 18:08:54 -04:00
Alex Kremer
653a383ff5
chore: Enable clang-tidy include cleaner ( #6947 )
2026-04-17 16:43:49 +00:00
Alex Kremer
f1a5ba43ad
chore: Enable clang-tidy readability checks ( #6930 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-04-17 13:30:52 +00:00
Ed Hennis
cbc2288bdc
Merge branch 'develop' into ximinez/fix-getledger
2026-04-15 14:28:51 -04:00
Alex Kremer
6a0ce46755
chore: Enable most clang-tidy bugprone checks ( #6929 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-04-14 20:24:21 +00:00
Ed Hennis
4ab2950410
Reduce duplicate peer traffic for ledger data ( #5126 )
...
Improve job queue collision checks and logging
- Improve logging related to ledger acquisition and operating mode
changes
- Class "CanProcess" to keep track of processing of distinct items
- Drop duplicate outgoing TMGetLedger messages per peer
- Allow a retry after 30s in case of peer or network congestion.
- Addresses RIPD-1870
- (Changes levelization. That is not desirable, and will need to be fixed.)
- Drop duplicate incoming TMGetLedger messages per peer
- Allow a retry after 15s in case of peer or network congestion.
- The requestCookie is ignored when computing the hash, thus increasing
the chances of detecting duplicate messages.
- With duplicate messages, keep track of the different requestCookies
(or lack of cookie). When work is finally done for a given request,
send the response to all the peers that are waiting on the request,
sending one message per peer, including all the cookies and
a "directResponse" flag indicating the data is intended for the
sender, too.
- Addresses RIPD-1871
- Drop duplicate incoming TMLedgerData messages
- Addresses RIPD-1869
2026-04-13 18:40:46 -04:00
yinyiqian1
d52dd29d20
fix: Address AI reviewer comments for Permission Delegation ( #6675 )
2026-04-08 20:22:19 +00:00
Gregory Tsipenyuk
dfcad69155
feat: Add MPT support to DEX ( #5285 )
2026-04-08 16:17:37 +00:00
Bart
c00ed673a8
refactor: Rename non-functional uses of ripple(d) to xrpl(d) ( #6676 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-04-07 13:00:17 +00:00
Alex Kremer
29e49abd3c
chore: Enable clang-tidy coreguidelines checks ( #6698 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-04-01 15:46:14 +00:00
Alex Kremer
2502befb42
chore: Enable clang-tidy misc checks ( #6655 )
2026-03-31 17:29:45 +00:00
Bart
7f53351920
chore: Remove unnecessary clang-format off/on directives ( #6682 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-03-31 15:38:04 +00:00
Alex Kremer
ab8c168e3b
chore: Enable remaining clang-tidy performance checks ( #6648 )
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2026-03-30 17:08:47 +00:00
Jingchen
3a477e4d01
refactor: Address PR comments after the modularisation PRs ( #6389 )
...
Signed-off-by: JCW <a1q123456@users.noreply.github.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-03-30 15:22:38 +00:00
Vito Tumas
b9d07730f3
feat: Add placeholder amendment for assorted bug fixes ( #6652 )
2026-03-25 23:54:33 +00:00
Jingchen
8f182e825a
refactor: Modularise ledger ( #6536 )
...
Signed-off-by: JCW <a1q123456@users.noreply.github.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
Co-authored-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-03-25 16:32:45 +00:00
Alex Kremer
0eedefbf45
refactor: Enable more clang-tidy readability checks ( #6595 )
...
Co-authored-by: Sergey Kuznetsov <kuzzz99@gmail.com >
2026-03-24 15:42:12 +00:00
Mayukha Vadari
d360e7c5b6
refactor: Rename transactor files/classes to match the tx name ( #6580 )
2026-03-18 19:52:07 +00:00
Alex Kremer
57e4cbbcd9
refactor: Add simple clang-tidy readability checks ( #6556 )
...
This change enables the following clang-tidy checks:
- readability-avoid-nested-conditional-operator,
- readability-avoid-return-with-void-value,
- readability-braces-around-statements,
- readability-const-return-type,
- readability-container-contains,
- readability-container-size-empty,
- readability-else-after-return,
- readability-make-member-function-const,
- readability-redundant-casting,
- readability-redundant-inline-specifier,
- readability-redundant-member-init,
- readability-redundant-string-init,
- readability-reference-to-constructed-temporary,
- readability-static-definition
2026-03-18 16:41:49 +00:00
Copilot
9e14707e77
fix: Peer crawler port field type inconsistency ( #6318 )
...
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com >
Co-authored-by: mvadari <8029314+mvadari@users.noreply.github.com >
Co-authored-by: Mayukha Vadari <mvadari@gmail.com >
Co-authored-by: Mayukha Vadari <mvadari@ripple.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-03-17 22:03:56 +00:00
Alex Kremer
72f4cb097f
refactor: Enable remaining clang-tidy cppcoreguidelines checks ( #6538 )
2026-03-17 19:09:05 +00:00
Mayukha Vadari
78b2d70a11
refactor: Assorted small DID fixes ( #6552 )
...
This change:
* Makes `addSLE` in `DIDSet` a static function, instead of a free function.
* Renames `Attestation` to `Data` everywhere (an artifact of a previous name for the field).
* Actually runs a set of tests that were not included in the `run` function of `DID_test`.
2026-03-17 14:44:07 +00:00
Mayukha Vadari
252c6768df
refactor: Clean up getFeePayer, mSourceBalance, and mPriorBalance ( #6478 )
...
This change:
* Introduces a new helper function on `STTx`, `getFeePayer`.
* Removes the usage of `mSourceBalance` and replaces it with SLE balance lookups.
* Renames `mPriorBalance` to `preFeeBalance_`
This simplifies some of the code in the transactors and makes it a lot more readable.
2026-03-17 14:12:16 +00:00