Ed Hennis
e50bb3d307
Merge branch 'ximinez/number-fix-maxrepcusp' into ximinez/number-maxint-range
2026-05-12 20:11:56 -04:00
Ed Hennis
e22938d69f
AI review feedback: createGuards
...
- Refactor the Guard decision in withTxnType into createGuards, which
lives in Rules.cpp. It is physically located near
setCurrentTransactionRules, and documented to explain that changes
need to be synchronized.
2026-05-12 18:44:05 -04:00
Ed Hennis
5a40416673
Merge branch 'develop' into ximinez/number-fix-maxrepcusp
2026-05-12 15:59:19 -04:00
Ayaz Salikhov
6c2266c5c7
refactor: Remove erroneous base_uint ctor from container ( #7123 )
2026-05-12 19:24:05 +00:00
Mayukha Vadari
c4c95dbe76
refactor: Replace featureInvariantsV1_1 with fixCleanup3_2_0 ( #7116 )
2026-05-12 12:26:02 +00:00
Ed Hennis
f483118498
Merge remote-tracking branch 'mywork/ximinez/number-fix-maxrepcusp' into ximinez/number-maxint-range
...
* mywork/ximinez/number-fix-maxrepcusp:
Address more nitpicky AI comments
What is it going to take to get clang-tidy to shut up?
More clang-tidy changes: AMMExtended_test member and Number_test includes
Fix clang-tidy issues, and more AI complaints
Fix AI-identified mistakes
fix: Fix a rounding error at the Number::maxRep cusp
2026-05-12 01:24:36 -04:00
Ed Hennis
30334cd1f4
Merge branch 'develop' into ximinez/number-fix-maxrepcusp
2026-05-11 13:34:11 -04:00
Alex Kremer
cdee9a675c
refactor: Use more scoped enums ( #7086 )
2026-05-11 15:39:48 +00:00
Ed Hennis
257da7972f
Merge branch 'develop' into ximinez/number-maxint-range
2026-05-07 18:10:49 -04:00
Ed Hennis
5558e1b522
Merge branch 'develop' into ximinez/number-fix-maxrepcusp
2026-05-07 18:10:03 -04:00
Ed Hennis
cd0f49a003
Address more nitpicky AI comments
2026-05-07 17:05:10 -04:00
Vito Tumas
4f8142fd10
fix: Numerically-stable (1+r)^n-1 in computePaymentFactor ( #7033 )
2026-05-07 19:02:09 +00:00
Ed Hennis
668fa65384
Merge branch 'develop' into ximinez/number-maxint-range
2026-05-07 13:29:17 -04:00
Ed Hennis
175a04160d
Merge branch 'develop' into ximinez/number-fix-maxrepcusp
2026-05-07 13:28:33 -04:00
Alex Kremer
7afdd71a54
chore: More fixes for bad renames ( #7092 )
2026-05-07 17:04:30 +00:00
Olek
af89854a43
fix: Stop tx processing if failed to delete expired credentials ( #6715 ) ( #6962 )
...
Co-authored-by: Ed Hennis <ed@ripple.com >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-05-07 12:57:50 +00:00
Ed Hennis
b050c151f8
Fix clang-tidy issues, and more AI complaints
2026-05-06 23:26:11 -04:00
Ed Hennis
a2b21d75ce
Fix AI-identified mistakes
2026-05-06 22:56:07 -04:00
Ed Hennis
b40d2a8e7d
fix: Fix a rounding error at the Number::maxRep cusp
...
- Add helper function, doDropDigit, to wrap the common pattern:
push(mantissa % 10);
mantissa /= 10;
++exponent;
- Might have been helpful to catch this issue when developing.
2026-05-06 22:49:44 -04:00
Ed Hennis
257e568cb6
Merge remote-tracking branch 'XRPLF/develop' into ximinez/number-maxint-range
...
* XRPLF/develop:
fix: Fix regressions in `server_definitions` (7008)
chore: Do not duplicate sanitizer flags (7058)
ci: Run pre-commit on diff in clang-tidy workflow (7078)
ci: Use XRPLF/create-issue (7076)
ci: Rewrite clang-tidy workflow(s) in a reusable manner (7062)
chore: Ignore identifier-naming update in git blame (7066)
refactor: Enable clang-tidy `readability-identifier-naming` check (6571)
2026-05-05 21:08:35 -04:00
Alex Kremer
8995564ed6
refactor: Enable clang-tidy readability-identifier-naming check ( #6571 )
2026-05-03 10:31:53 +00:00
Ed Hennis
fd2040a56d
Merge remote-tracking branch 'XRPLF/develop' into ximinez/number-maxint-range
...
* XRPLF/develop:
refactor: Revert certain `Throw`s by `LogicError`s (7036)
ci: Rename print-env -> print-build-env (7061)
fix: Gate -mcmodel flags to x86_64 in sanitizer builds (7049)
fix: Prevents overwriting a bool value in an invariant (6609)
fix: Address code review comments regarding `boost::coroutine2` (6977)
refactor: Apply various minor improvements and corrections (7045)
fix: Store `Delegate` object in delegating and authorized account directories for proper deletion (6681)
ci: Use print-env from XRPLF/actions (7052)
fix: Make assorted RPC fixes (6529)
chore: Enable clang-tidy v21 new checks (7031)
2026-05-01 14:32:51 -04:00
Bart
182d844996
refactor: Revert certain Throws by LogicErrors ( #7036 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-05-01 09:50:00 +00:00
Vito Tumas
31180f94c2
fix: Prevents overwriting a bool value in an invariant ( #6609 )
...
Co-authored-by: Ed Hennis <ed@ripple.com >
2026-04-30 13:05:09 +00:00
Pratik Mankawde
6407f0fa52
fix: Address code review comments regarding boost::coroutine2 ( #6977 )
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-04-30 10:36:12 +00:00
Bart
4d0ea8ae36
refactor: Apply various minor improvements and corrections ( #7045 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-04-30 10:22:11 +00:00
Zhiyuan Wang
dbd646bd53
fix: Store Delegate object in delegating and authorized account directories for proper deletion ( #6681 )
2026-04-29 18:17:01 +00:00
Ed Hennis
51ab048b97
fixup! Fix clang-tidy
2026-04-29 12:10:11 -04:00
Alex Kremer
f7275b7ad9
chore: Enable clang-tidy v21 new checks ( #7031 )
2026-04-29 15:17:35 +00:00
Ed Hennis
fc569b9410
Merge branch 'develop' into ximinez/number-maxint-range
2026-04-29 11:05:57 -04:00
Jingchen
46b997b774
feat: Create new transaction testing framework TxTest ( #6537 )
...
Signed-off-by: JCW <a1q123456@users.noreply.github.com >
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
Co-authored-by: Copilot <copilot@github.com >
2026-04-28 14:16:10 +00:00
Vito Tumas
147da57348
feat: Add cleanup amendment for 3.2.0 ( #7037 )
2026-04-28 10:22:32 +00:00
Pratik Mankawde
3547112540
fix: Fix ubsan flagged issues ( #6151 )
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com >
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-04-27 20:34:16 +00:00
Ed Hennis
c2f25c2a34
Merge remote-tracking branch 'XRPLF/develop' into ximinez/number-maxint-range
...
* XRPLF/develop:
chore: Enable clang-tidy modernize-use-nodiscard check (7015)
fix: Resolve MSVC Debug build failure in JobQueue.h; re-enable _CRTDBG_MAP_ALLOC in CI (6993)
docs: Update hybrid offer invariant comment (7007)
2026-04-26 22:29:50 -05:00
Alex Kremer
4dc923dcc5
chore: Enable clang-tidy modernize-use-nodiscard check ( #7015 )
2026-04-24 17:19:30 +00:00
Ed Hennis
ee33d98f50
Merge branch 'develop' into ximinez/number-maxint-range
2026-04-24 12:54:01 -04:00
Pratik Mankawde
158df5394c
fix: Resolve MSVC Debug build failure in JobQueue.h; re-enable _CRTDBG_MAP_ALLOC in CI ( #6993 )
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
Co-authored-by: Ed Hennis <ed@ripple.com >
2026-04-24 16:47:16 +00:00
Mayukha Vadari
7cfa5d4610
fix: Make assorted Payments fixes ( #6585 )
2026-04-24 12:56:50 +00:00
Mayukha Vadari
248cb29681
refactor: Move LendingHelpers into libxrpl/ledger/helpers ( #6638 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-04-24 12:06:26 +00:00
Ed Hennis
1226255662
Merge branch 'develop' into ximinez/number-maxint-range
2026-04-23 15:56:51 -04:00
Alex Kremer
19da25812b
fix: Remaining clang-tidy unchecked optionals ( #6979 )
2026-04-23 16:21:01 +00:00
Jingchen
7cd503859e
refactor: Remove seq from TMGetObjectByHash ( #6976 )
2026-04-23 13:59:23 +00:00
Ed Hennis
e3b390f949
Merge branch 'develop' into ximinez/number-maxint-range
2026-04-22 14:49:47 -04:00
Mayukha Vadari
1c6cdc653c
fix: More clang-tidy issues ( #6992 )
2026-04-22 17:42:15 +00:00
Ed Hennis
5a7be26402
Merge branch 'develop' into ximinez/number-maxint-range
2026-04-22 13:11:20 -04:00
Vito Tumas
2e307329f0
refactor: Add transaction-specific invariant checking ( #6551 )
2026-04-22 14:41:19 +00:00
Ed Hennis
25e0b4eeb5
Merge branch 'develop' into ximinez/number-maxint-range
2026-04-21 19:35:21 -04:00
Alex Kremer
ce3951bbb3
chore: Enable clang-tidy modernize checks ( #6975 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-04-21 15:32:51 +00:00
Alex Kremer
ea023121f5
fix: Add rounding to Vault invariants ( #6217 ) ( #6955 )
...
Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com >
Co-authored-by: Ed Hennis <ed@ripple.com >
2026-04-21 12:14:07 +00:00
Ed Hennis
c4ef1e6997
Merge remote-tracking branch 'XRPLF/develop' into ximinez/number-maxint-range
...
* XRPLF/develop:
fix: Disallow MPTClearRequireAuth if is set (6712)
feat: Add GRPC TLS support (6374)
fix: Check for empty `sfAdditionalBooks` array in hybrid offer invariant (6716)
chore: Remove repetitive word in multiple files (6978)
ci: Add workflow to check PR description has been filled (6965)
ci: [DEPENDABOT] Bump tj-actions/changed-files from 47.0.5 to 47.0.6 (6973)
chore: Enable clang-tidy include cleaner (6947)
fix: Change AMMClawback return code to tecNO_PERMISSION (6946)
ci: [DEPENDABOT] bump actions/upload-pages-artifact from 4.0.0 to 5.0.0 (6927)
ci: [DEPENDABOT] bump actions/upload-artifact from 7.0.0 to 7.0.1 (6928)
chore: Enable clang-tidy readability checks (6930)
2026-04-20 18:59:21 -04:00