Pratik Mankawde
7a7a864611
Merge branch 'develop' into pratik/Fix_asan_lsan_flagged_issues
2026-02-18 15:43:05 +00:00
Jingchen
0976b2b68b
refactor: Modularize app/tx ( #6228 )
2026-02-17 18:10:07 +00:00
Pratik Mankawde
c4a94bb000
do not fix the stack size
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-02-17 17:20:17 +00:00
Jingchen
36240116a5
refactor: Decouple app/tx from Application and Config ( #6227 )
...
This change decouples app/tx from `Application` and `Config` to clear the way to moving transactors to `libxrpl`.
2026-02-17 11:29:53 -05:00
Sergey Kuznetsov
958d8f3754
chore: Update clang-format to 21.1.8 ( #6352 )
2026-02-16 14:31:18 -05:00
Pratik Mankawde
ac7ddd0cef
reverted change in Number
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-02-16 18:39:14 +00:00
Pratik Mankawde
a8ee7ef316
Merge branch 'develop' into pratik/Fix_asan_lsan_flagged_issues
2026-02-16 15:53:44 +00:00
Jingchen
ac0ad3627f
refactor: Modularize HashRouter, Conditions, and OrderBookDB ( #6226 )
...
This change modularizes additional components by moving code to `libxrpl`.
2026-02-13 10:34:37 -05:00
Pratik Mankawde
f8fcccd684
Merge remote-tracking branch 'origin/develop' into pratik/Fix_asan_lsan_flagged_issues
2026-02-13 13:11:22 +00:00
Jingchen
5edd3566f7
refactor: Modularize the NetworkOPs interface ( #6225 )
...
This change moves the NetworkOPs interface into `libxrpl` and it leaves its implementation in `xrpld`.
2026-02-12 13:15:03 -05:00
Pratik Mankawde
496354f1c9
increase stack size of coroutine
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-02-12 16:38:57 +00:00
Pratik Mankawde
1a737ebb49
remove recursion from the ApplyStateTable::read and add flat call ApplyStateTable::readLocal
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-02-12 14:46:32 +00:00
Pratik Mankawde
e6455035d5
Merge branch 'develop' into pratik/Fix_asan_lsan_flagged_issues
2026-02-12 12:23:38 +00:00
Pratik Mankawde
6029c65aa1
revert the LocalValue change
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-02-12 12:18:05 +00:00
Jingchen
9f17d10348
refactor: Modularize RelationalDB ( #6224 )
...
The rdb module was not properly designed, which is fixed in this change. The module had three classes:
1) The abstract class `RelationalDB`.
2) The abstract class `SQLiteDatabase`, which inherited from `RelationalDB` and added some pure virtual methods.
3) The concrete class `SQLiteDatabaseImp`, which inherited from `SQLiteDatabase` and implemented all methods.
The updated code simplifies this as follows:
* The `SQLiteDatabaseImp` has become `SQLiteDatabase`, and
* The former `SQLiteDatabase `has merged with `RelationalDatabase`.
2026-02-11 16:22:01 +00:00
Jingchen
ef284692db
refactor: Modularize WalletDB and Manifest ( #6223 )
...
This change modularizes the `WalletDB` and `Manifest`. Note that the wallet db has nothing to do with account wallets and it stores node configuration, which is why it depends on the manifest code.
2026-02-11 13:42:31 +00:00
Pratik Mankawde
7b36580552
Merge branch 'develop' into pratik/Fix_asan_lsan_flagged_issues
2026-02-11 11:48:28 +00:00
Olek
e11f6190b7
fix: Update invariant checks for Permissioned Domains ( #6134 )
2026-02-10 14:02:53 -05:00
Pratik Mankawde
d5a4f36632
ucontext, coroutine2 and for boost asan build
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-02-10 15:31:13 +00:00
Pratik Mankawde
011f0a6320
Merge branch 'develop' into pratik/Fix_asan_lsan_flagged_issues
2026-02-10 13:34:52 +00:00
Pratik Mankawde
68c9b20f2d
Force build boost with asan
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-02-10 12:46:23 +00:00
Mayukha Vadari
bf4674f42b
refactor: Fix spelling issues in tests ( #6199 )
...
This change removes the `src/tests` exception from the `cspell` config and fixes all the issues that arise as a result. No functionality/test change.
2026-02-06 20:30:22 +00:00
Bart
677758b1cc
perf: Remove unnecessary caches ( #5439 )
...
This change removes the cache in `DatabaseNodeImp` and simplifies the caching logic in `SHAMapStoreImp`. As NuDB and RocksDB internally already use caches, additional caches in the code are not very valuable or may even be unnecessary, as also confirmed during preliminary performance analyses.
2026-02-06 09:42:35 -05:00
Pratik Mankawde
69597e4b3b
switch to coroutine2 and remove string caching
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-02-06 13:46:04 +00:00
Pratik Mankawde
14e3e098d5
change coroutine stack size to 4MB.
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-02-06 11:57:52 +00:00
Pratik Mankawde
4600c381b9
stack-buffer-overflow in coroutines.
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-02-05 16:34:45 +00:00
Pratik Mankawde
be28f4d489
fixing issue with ScopedStream stack-use-after-scope
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-02-05 16:14:43 +00:00
Pratik Mankawde
6b16a5a8ed
Merge branch 'develop' into pratik/Fix_asan_lsan_flagged_issues
2026-02-05 13:41:01 +00:00
Pratik Mankawde
fd53813746
more ASAN fixes
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-02-05 13:40:26 +00:00
Pratik Mankawde
bbb03e153e
fixed asan escape macro before return type
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-02-04 15:54:50 +00:00
Pratik Mankawde
63b6ec98ea
added comments and haltonerror=false
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-02-04 15:45:03 +00:00
Bart
34ef577604
refactor: Replace include guards by '#pragma once' ( #6322 )
...
This change replaces all include guards in the `src/` and `include/` directories by `#pragma once`.
2026-02-04 09:50:21 -05:00
Pratik Mankawde
49dcb6b60b
fix memory leak in LocalValue
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-02-04 13:17:31 +00:00
Pratik Mankawde
4b99771021
Don't copy the Json::StaticString
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-02-04 11:24:54 +00:00
Bart
3a172301ce
chore: Remove unity builds ( #6300 )
...
Unity builds were intended to speed up builds, by bundling multiple files into compilation units. However, now that ccache is available on all platforms, there is no need for unity builds anymore, as ccache stores compiled individual build objects for reuse. This change therefore removes the ability to make unity builds.
2026-02-03 22:55:22 +00:00
Jingchen
6c1a92fe93
refactor: Add ServiceRegistry to help modularization ( #6222 )
...
Currently we're passing the `Application` object around, whereby the `Application` class acts more like a service registry that gives other classes access to other services. In order to allow modularization, we should replace `Application` with a service registry class so that modules depending on `Application` for other services can be moved easily. This change adds the `ServiceRegistry` class.
2026-02-03 19:08:27 +00:00
Pratik Mankawde
e6664fe4cf
Merge branch 'develop' into pratik/Fix_asan_lsan_flagged_issues
2026-02-03 18:27:52 +00:00
Pratik Mankawde
b5001bc258
fixes to static variable destruction issue.
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-02-03 18:27:00 +00:00
Copilot
7813683091
fix: Deletes expired NFToken offers from ledger ( #5707 )
...
This change introduces the `fixExpiredNFTokenOfferRemoval` amendment that allows expired offers to pass through `preclaim()` and be deleted in `doApply()`, following the same pattern used for expired credentials.
2026-02-03 16:37:24 +00:00
Pratik Mankawde
5dacfa1938
clang-format updates
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-02-03 15:04:16 +00:00
Pratik Mankawde
394b256f02
Merge branch 'develop' into pratik/Fix_asan_lsan_flagged_issues
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-02-03 15:03:34 +00:00
Ayaz Salikhov
5f638f5553
chore: Set ColumnLimit to 120 in clang-format ( #6288 )
...
This change updates the ColumnLimit from 80 to 120, and applies clang-format to reformat the code.
2026-01-28 18:09:50 +00:00
Pratik Mankawde
a9c3bb84ba
fixes to Number. run et even when st fails
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-01-28 15:30:05 +00:00
Pratik Mankawde
dabdadfff5
Merge branch 'develop' into pratik/Fix_asan_lsan_flagged_issues
2026-01-27 15:20:10 +00:00
Ed Hennis
a2f1973574
fix: Remove DEFAULT fields that change to the default in associateAsset ( #6259 ) ( #6273 )
...
- Add Vault creation tests for showing valid range for AssetsMaximum
2026-01-26 19:58:12 +00:00
Pratik Mankawde
2770a9cdf3
fixes to asan errors
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-01-26 14:55:18 +00:00
Pratik Mankawde
05ef3b1ad8
more fixes
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-01-23 18:28:09 +00:00
Pratik Mankawde
7dd4dbe285
fixes
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-01-23 17:13:03 +00:00
Pratik Mankawde
df76002a44
fixed asan issues
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-01-23 15:39:21 +00:00
Ayaz Salikhov
4cd6cc3e01
fix: Include <functional> header in Number.h ( #6254 )
...
The `Number.h` header file now has `std::reference_wrapper` from `<functional>`, but the include is missing, causing downstream build problems. This change adds the header.
2026-01-21 18:52:22 -05:00