Conflict resolution:
- sfields.macro: both sides claimed INT32 code 2. sfRemainingOwnerCountDelta
is already in develop, so it keeps code 2 and sfVMReturnCode moves to 3.
This changes the Smart Escrow serialization, which is safe while the
amendment is unactivated, but is a deliberate renumber rather than a
mechanical merge.
- EscrowFinish.cpp: took the SeqProxy form of the keylet::escrow call and
kept this branch's comment.
Follow-on fixes the merge required:
- Adapted two keylet::escrow calls in EscrowSmart_test.cpp to SeqProxy; they
are only on this branch, so the earlier pass over the wasm code did not
cover them.
- Updated two gas expectations that the trace host function refactor and the
regenerated fixtures invalidated: the codecov allowance in Wasm_test.cpp is
now 264'467 and sfGasUsed in EscrowSmart_test.cpp is now 48'433. Both are
measured, not estimated.
- Disabled testKeyletHostFunctions. kAllKeyletsWasmHex was built against the
old trace ABI and is rejected with temINVALID_BYTECODE. Regenerating it
needs the all_keylets source ported to the current stdlib first, along with
float_tests and float_0, which are stale for the same reason. See the TODO
on the test.
ASAN wasn't able to keep track of `boost::coroutine` context switches, and would lead to many false positives being detected. By switching to `boost::coroutine2` and `ucontext`, ASAN is able to know about the context switches advertised by the `boost::fiber` class, which in turn leads to more cleaner ASAN analysis.
This change modularizes the `WalletDB` and `Manifest`. Note that the wallet db has nothing to do with account wallets and it stores node configuration, which is why it depends on the manifest code.
Currently we're passing the `Application` object around, whereby the `Application` class acts more like a service registry that gives other classes access to other services. In order to allow modularization, we should replace `Application` with a service registry class so that modules depending on `Application` for other services can be moved easily. This change adds the `ServiceRegistry` class.
This change renames all occurrences of `rippled.cfg` to `xrpld.cfg`. It also provides a script to allow developers to replicate the changes in their local branch or fork to avoid conflicts. For the time being it maintains support for `rippled.cfg` as config file, if `xrpld.cfg` does not exist.
This change renames all occurrences of `namespace ripple` and `ripple::` to `namespace xrpl` and `xrpl::`, respectively, as well as the names of test suites. It also provides a script to allow developers to replicate the changes in their local branch or fork to avoid conflicts.
