Bart
afbccf971a
chore: Consolidate fix amendments ( #7134 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-05-13 20:46:30 +00:00
Michael Legleux
2f65cb5610
ci: Add Conan retry ( #7147 )
2026-05-13 19:34:46 +00:00
Olek
d4ebd6a168
fix: Backport Permissioned Domains fixes ( #7016 )
2026-05-13 19:22:29 +00:00
Pratik Mankawde
02fe838257
auto refresh at 5seconds
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-05-13 19:00:36 +01:00
Pratik Mankawde
20477e5494
validator path changes
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-05-13 18:49:21 +01:00
Sergey Kuznetsov
551f3c3b96
refactor: Move unhex lookup table out of function ( #7104 )
2026-05-13 17:48:43 +00:00
Pratik Mankawde
f0c6227c06
added config for devnet test run
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-05-13 18:42:57 +01:00
Pratik Mankawde
a9e4006591
fix(telemetry): address clang-tidy CI failures on phase10 beast test
...
- Add missing direct includes (contract.h, Log.h, Journal.h, uint256.h,
suite.h, io_context.hpp, optional, stdexcept, string).
- Replace broad unit_test.h with specific unit_test/suite.h.
- Concatenate nested namespaces (xrpl::test).
- Add [[nodiscard]] to getOpenLedger/isStopping/getTrapTxID overrides.
- Make const-eligible variables const (Journal j, registry in
disabled_construction test).
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
2026-05-13 18:27:05 +01:00
Pratik Mankawde
eac2538a55
Merge phase9 clang-tidy fixes into phase10
...
# Conflicts:
# src/tests/libxrpl/telemetry/MetricsRegistry.cpp
2026-05-13 18:24:49 +01:00
Pratik Mankawde
ddca4a982b
fix(telemetry): address clang-tidy CI failures on phase9
...
- MetricsRegistry.cpp: concatenate nested namespaces, add missing
direct includes (Journal.h, string, string_view, cstdint), suppress
readability-convert-member-functions-to-static in #else stubs by
referencing enabled_ member, void unused instanceId parameter.
- MetricsRegistry test: add missing direct includes (Log.h, Journal.h,
uint256.h, io_context.hpp, optional, stdexcept, string), make
throwUnimplemented() static, add [[nodiscard]] to getOpenLedger/
isStopping/getTrapTxID overrides, make const-eligible registry const.
- PerfLogImp.cpp: add braces around if/else body per
readability-braces-around-statements.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
2026-05-13 18:24:29 +01:00
Pratik Mankawde
9fbdfa1fbe
Merge phase9 clang-tidy fixes into phase10
2026-05-13 18:13:40 +01:00
Pratik Mankawde
3c13d788fd
fix(telemetry): address clang-tidy CI failures on phase9
...
- MetricsRegistry.cpp: concatenate nested namespaces, add missing
direct includes (Journal.h, string, string_view, cstdint), suppress
readability-convert-member-functions-to-static in #else stubs by
referencing enabled_ member, void unused instanceId parameter.
- MetricsRegistry test: add missing direct includes (Log.h, Journal.h,
uint256.h, io_context.hpp, optional, stdexcept, string), make
throwUnimplemented() static, add [[nodiscard]] to getOpenLedger/
isStopping/getTrapTxID overrides, make const-eligible registry const.
- PerfLogImp.cpp: add braces around if/else body per
readability-braces-around-statements.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
2026-05-13 18:13:19 +01:00
Luc des Trois Maisons
aa5e4ff89f
refactor: Improve Forwarded header field parsing ( #7126 )
2026-05-13 16:48:38 +00:00
Sergey Kuznetsov
977e5a7dba
fix: Check network ID in transactionSignFor ( #7102 )
2026-05-13 16:03:57 +00:00
Pratik Mankawde
c10b0fd9d1
Merge branch 'pratik/otel-phase9-metric-gap-fill' into pratik/otel-phase10-workload-validation
2026-05-13 16:53:56 +01:00
Pratik Mankawde
3131d99029
Merge branch 'pratik/otel-phase8-log-correlation' into pratik/otel-phase9-metric-gap-fill
2026-05-13 16:53:54 +01:00
Pratik Mankawde
829094df5a
Merge branch 'pratik/otel-phase7-native-metrics' into pratik/otel-phase8-log-correlation
2026-05-13 16:53:52 +01:00
Pratik Mankawde
9554e3889b
Merge branch 'pratik/otel-phase6-statsd' into pratik/otel-phase7-native-metrics
2026-05-13 16:53:50 +01:00
Pratik Mankawde
fe7cb33b65
Merge branch 'pratik/otel-phase5-docs-deployment' into pratik/otel-phase6-statsd
2026-05-13 16:53:47 +01:00
Pratik Mankawde
f5cf4155c2
Merge branch 'pratik/otel-phase4-consensus-tracing' into pratik/otel-phase5-docs-deployment
2026-05-13 16:53:45 +01:00
Pratik Mankawde
ea30adeb47
Merge branch 'pratik/otel-phase3-tx-tracing' into pratik/otel-phase4-consensus-tracing
2026-05-13 16:53:43 +01:00
Pratik Mankawde
9bc2e4abb3
Merge branch 'pratik/otel-phase2-rpc-tracing' into pratik/otel-phase3-tx-tracing
2026-05-13 16:53:32 +01:00
Pratik Mankawde
7b9e0bc300
fix(telemetry): remove unused includes from RPCHandler after node-health attr removal
...
NetworkOPs.h and SpanNames.h were only needed for per-span
nodeAmendmentBlocked/nodeServerState calls, which were removed
in the attr naming simplification. Fixes clang-tidy CI failure.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
2026-05-13 16:53:19 +01:00
Pratik Mankawde
a04459f1f8
fix(telemetry): update collector config + tempo datasource + design doc for simplified attr names
...
- otel-collector-config.yaml: spanmetrics dimensions use new bare names.
- tempo.yaml: TraceQL filter tags use new bare names.
- 02-design-decisions.md: strip xrpl.txq.* prefix from planned attrs.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
2026-05-13 16:47:36 +01:00
Pratik Mankawde
6b5e6a49ec
Merge branch 'pratik/otel-phase9-metric-gap-fill' into pratik/otel-phase10-workload-validation
2026-05-13 16:45:23 +01:00
Pratik Mankawde
b4e4b57504
Merge branch 'pratik/otel-phase8-log-correlation' into pratik/otel-phase9-metric-gap-fill
2026-05-13 16:45:14 +01:00
Pratik Mankawde
6dd43765b5
Merge branch 'pratik/otel-phase7-native-metrics' into pratik/otel-phase8-log-correlation
2026-05-13 16:45:03 +01:00
Pratik Mankawde
cbf389943f
Merge branch 'pratik/otel-phase6-statsd' into pratik/otel-phase7-native-metrics
2026-05-13 16:44:49 +01:00
Pratik Mankawde
b05e650b6f
docs(telemetry): update 09-data-collection-reference + Phase5 integration test list for simplified attr naming
...
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
2026-05-13 16:42:30 +01:00
Pratik Mankawde
57175ab12c
Merge branch 'pratik/otel-phase5-docs-deployment' into pratik/otel-phase6-statsd
2026-05-13 16:37:37 +01:00
Pratik Mankawde
d44a0aa3ff
docs(telemetry): update Phase5 task list for simplified attr naming
...
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
2026-05-13 16:37:27 +01:00
Pratik Mankawde
522fe562ff
Merge branch 'pratik/otel-phase4-consensus-tracing' into pratik/otel-phase5-docs-deployment
2026-05-13 16:36:34 +01:00
Pratik Mankawde
745102360b
docs(telemetry): update Phase4 task list for simplified consensus attr naming
...
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
2026-05-13 16:36:22 +01:00
Pratik Mankawde
19d9c44cf5
Merge branch 'pratik/otel-phase3-tx-tracing' into pratik/otel-phase4-consensus-tracing
2026-05-13 16:31:35 +01:00
Pratik Mankawde
5c14b57462
docs(telemetry): update Phase3 task list for simplified tx/txq attr naming
...
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
2026-05-13 16:31:22 +01:00
Pratik Mankawde
c875944e05
Merge branch 'pratik/otel-phase2-rpc-tracing' into pratik/otel-phase3-tx-tracing
2026-05-13 16:29:32 +01:00
Pratik Mankawde
2430032e3a
docs(telemetry): update Phase2 task list + design docs for attr rename
...
- Phase2_taskList: update attr refs to bare names, note node-health
attrs moved to resource level.
- 02-design-decisions: strip xrpl.pathfind.* prefix from planned attrs.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
2026-05-13 16:29:20 +01:00
Pratik Mankawde
0f63d14999
Merge branch 'pratik/otel-phase1c-rpc-integration' into pratik/otel-phase2-rpc-tracing
2026-05-13 16:28:07 +01:00
Pratik Mankawde
faaec003f4
docs(telemetry): update plan docs for simplified RPC/gRPC attr naming
...
Update OpenTelemetryPlan docs and Telemetry.h doc example to reflect
the renamed per-span attributes: xrpl.rpc.command -> command,
xrpl.rpc.status -> rpc_status, xrpl.grpc.method -> method, etc.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
2026-05-13 16:27:55 +01:00
Pratik Mankawde
815e2b1f5d
refactor(telemetry): fix remaining old attr refs in tests, docs, workload
...
- Update Telemetry.h doc example: xrpl.rpc.command -> command.
- Update SpanGuardFactory.cpp test: use new bare attr names.
- Update TESTING.md: rename attr refs in span table + PromQL example.
- Update expected_spans.json: all attrs match simplified naming.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
2026-05-13 16:21:18 +01:00
Pratik Mankawde
ec8e3e2950
Merge branch 'pratik/otel-phase9-metric-gap-fill' into pratik/otel-phase10-workload-validation
2026-05-13 16:17:49 +01:00
Pratik Mankawde
495d5bd8a0
Merge branch 'pratik/otel-phase8-log-correlation' into pratik/otel-phase9-metric-gap-fill
2026-05-13 16:17:12 +01:00
Pratik Mankawde
6cd910f06f
Merge branch 'pratik/otel-phase7-native-metrics' into pratik/otel-phase8-log-correlation
2026-05-13 16:17:05 +01:00
Pratik Mankawde
5cd71ed107
Merge branch 'pratik/otel-phase6-statsd' into pratik/otel-phase7-native-metrics
2026-05-13 16:16:50 +01:00
Pratik Mankawde
9e27120a15
refactor(telemetry): simplify ledger/peer attr naming on phase-6, update dashboards
...
- Add canonical ledgerHash (xrpl.ledger.hash) to SpanNames.h.
- LedgerSpanNames: reuse shared canonicals (ledgerSeq, closeTime,
closeTimeCorrect, closeResolutionMs, ledgerHash); bare names for
tx_count, tx_failed, validations.
- PeerSpanNames: reuse shared canonicals (peerId, ledgerHash); bare
names for proposal_trusted, validation_full, validation_trusted.
- Update call sites in BuildLedger.cpp, LedgerMaster.cpp, PeerImp.cpp.
- Update 5 Grafana dashboards: strip xrpl.<domain>. prefix from
per-span attr refs in PromQL/TraceQL queries. Keep rule-5 entries.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
2026-05-13 16:16:30 +01:00
Ayaz Salikhov
648ec747f2
feat: Implement nix-based Dockerfile for CI ( #7083 )
2026-05-13 15:10:53 +00:00
Pratik Mankawde
e60efd4d2f
Merge branch 'pratik/otel-phase5-docs-deployment' into pratik/otel-phase6-statsd
2026-05-13 16:10:46 +01:00
Pratik Mankawde
c48f5ed6e7
docs(telemetry): update runbook attr names for simplified naming convention
...
Update 31 attribute references in telemetry-runbook.md to match the
simplified naming: drop xrpl.<domain>. prefix on per-span attrs, use
domain-qualified names for collisions (rpc_status, consensus_state,
etc.), and unify cross-domain refs (xrpl.ledger.seq, xrpl.tx.hash).
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
2026-05-13 16:08:48 +01:00
Pratik Mankawde
c9fe4b1a14
Merge branch 'pratik/otel-phase4-consensus-tracing' into pratik/otel-phase5-docs-deployment
2026-05-13 16:04:27 +01:00
Pratik Mankawde
46d1012ad4
refactor(telemetry): simplify consensus attr naming on phase-4 — drop xrpl.consensus. prefix
...
- Add canonical shared bare attrs to SpanNames.h: closeTime,
closeTimeCorrect, closeResolutionMs (reused by ledger domain).
- Keep qualified (rule 5): ledgerId, mode, round, roundId.
- Domain-qualify collisions: state -> consensus_state,
result -> consensus_result.
- Reuse canonical ledgerSeq from phase-3.
- Drop xrpl.consensus.* prefix from 20+ attrs (proposers, round_time_ms,
converge_percent, avalanche_threshold, etc.).
- Dispute attrs: bare names (dispute_our_vote, dispute_yays, etc.).
- Update call sites in RCLConsensus.cpp, Consensus.h.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
2026-05-13 16:04:16 +01:00