Vito Tumas
72f75cbf43
Merge branch 'develop' into tapanito/vault-add-assets-helper
2026-08-10 12:51:59 +02:00
Vito
3c51e3dad1
feat: Centralize Vault balance mutations in VaultHelpers
...
Add addVaultAssets, removeVaultAssets (two overloads: plain accountSend
and doWithdraw-based), clawbackVaultAssets, and moveVaultAssets as the
single points through which a Vault's sfAssetsTotal/sfAssetsAvailable are
mutated and funds move to/from its pseudo-account:
- addVaultAssets increases both fields and transfers in from a sender.
- removeVaultAssets/clawbackVaultAssets decrease both fields equally and
transfer out; a FinalRemoval flag hard-resets both fields to exactly
zero on a Vault's last withdrawal, since the discounted exchange-rate
formula can produce values with more precision than the asset can
canonically represent, and subtracting such a value would leave a
non-canonical residual instead of an exact zero.
- moveVaultAssets decreases only sfAssetsAvailable, for disbursements
(e.g. a loan's principal and origination fee) where sfAssetsTotal
independently grows via accrued interest.
Also consolidate getAssetsTotalScale into VaultHelpers::getVaultScale,
and move isRounded from LendingHelpers into STAmount.h alongside the
other rounding utilities.
2026-08-10 12:40:10 +02:00
Gregory Tsipenyuk
94bccb3a5a
fix: Fix MPT/DEX Audit/Attackathon reports (Phase 2) ( #7537 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: Sergey Kuznetsov <skuznetsov@ripple.com >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
Co-authored-by: Andrzej Budzanowski <andrzej.budzanowski@neti-soft.com >
Co-authored-by: Marek Foss <marek.foss@neti-soft.com >
Co-authored-by: Alex Kremer <akremer@ripple.com >
Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
Co-authored-by: Mayukha Vadari <mvadari@ripple.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-08-07 21:53:54 +00:00
Alex Kremer
06488c1318
chore: Rename CamelCase namespaces to snake_case ( #7933 )
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-08-04 13:46:55 +00:00
Vito Tumas
8a5eded4f1
feat: Implement LoanBroker cash-basis accounting ( #7817 )
2026-07-30 11:55:39 +00:00
Vito Tumas
5ce0b1c2c7
refactor: Restructure LendingHelpers to improve readability ( #7807 )
2026-07-16 15:47:56 +00:00
Ayaz Salikhov
73b6852a12
style: Unify style for all Doxygen comments ( #7776 )
2026-07-13 10:40:40 +00:00
Olek
fd2cc6dcb3
feat: XLS-68: Sponsor, #5887 continuation ( #7350 )
...
Co-authored-by: tequ <git@tequ.dev >
Co-authored-by: yinyiqian1 <yqian@ripple.com >
Co-authored-by: Mayukha Vadari <mvadari@ripple.com >
Co-authored-by: Mayukha Vadari <mvadari@gmail.com >
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
Co-authored-by: Peter Chen <34582813+PeterChen13579@users.noreply.github.com >
Co-authored-by: Zhiyuan Wang <96991820+Kassaking7@users.noreply.github.com >
Co-authored-by: Ayaz Salikhov <asalikhov@ripple.com >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
Co-authored-by: Zhiyuan Wang <1830604455@qq.com >
2026-07-10 21:58:19 +00:00
Ayaz Salikhov
d07d2aba2e
chore: Enable most modernize checks ( #7664 )
2026-07-06 12:19:52 +00:00
Ayaz Salikhov
53649cc298
chore: Enable modernize-use-constraints ( #7715 )
2026-07-03 14:28:15 +00:00
Ayaz Salikhov
7ba1d76d05
chore: Enable modernize-use-auto ( #7707 )
2026-07-02 20:02:55 +00:00
Ayaz Salikhov
41622b87ae
chore: Enable modernize-unary-static-assert ( #7705 )
2026-07-02 18:30:59 +00:00
Ayaz Salikhov
6f0f5b8bb3
chore: Make clang-tidy happy on macOS ( #7701 )
2026-07-02 16:26:09 +00:00
Ayaz Salikhov
8e378c4f47
build: Add verify-headers target to cleanup headers ( #7670 )
2026-07-01 23:14:17 +00:00
Vito Tumas
0d149ba5b6
fix: Disable AMM creation with Vault shares ( #7666 )
2026-07-01 15:04:38 +00:00
Denis Angell
86d8b244d6
feat: Add Batch (XLS-56) V1_1 ( #6446 )
...
Co-authored-by: Mayukha Vadari <mvadari@ripple.com >
2026-07-01 12:47:14 +00:00
Shawn Xie
768d7603b1
feat: Confidential Transfer for MPT ( #5860 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: chuanshanjida <chuanshanjida@outlook.com >
Co-authored-by: Ed Hennis <ed@ripple.com >
Co-authored-by: Jingchen <a1q123456@users.noreply.github.com >
Co-authored-by: Denis Angell <dangell@transia.co >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
Co-authored-by: yinyiqian1 <yqian@ripple.com >
Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com >
Co-authored-by: Bronek Kozicki <brok@incorrekt.com >
Co-authored-by: Mayukha Vadari <mvadari@ripple.com >
Co-authored-by: Valentin Balaschenko <13349202+vlntb@users.noreply.github.com >
Co-authored-by: tequ <git@tequ.dev >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
Co-authored-by: Peter Chen <34582813+PeterChen13579@users.noreply.github.com >
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
Co-authored-by: Zhiyuan Wang <96991820+Kassaking7@users.noreply.github.com >
Co-authored-by: Alex Kremer <akremer@ripple.com >
Co-authored-by: Sergey Kuznetsov <skuznetsov@ripple.com >
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Gregory Tsipenyuk <gregtatcam@users.noreply.github.com >
Co-authored-by: chuanshanjida <chuanshanjida@outlook.com >
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
Co-authored-by: Peter Chen <ychen@ripple.com >
Co-authored-by: Timothy Banks <timothyaaronbanks@gmail.com >
Co-authored-by: Timothy Banks <tbanks@ripple.com >
2026-06-27 01:20:38 +00:00
Vito Tumas
3e9f1d0ab8
fix: Unify freeze checks for pseudo-account deposit/withdraw ( #7382 )
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
Co-authored-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
Co-authored-by: Shawn Xie <35279399+shawnxie999@users.noreply.github.com >
2026-06-26 21:38:59 +00:00
Mayukha Vadari
b9eee1d245
refactor: Rename (mostly keylet) functions to more closely match the docs ( #7059 )
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2026-06-26 10:24:12 +00:00
Ayaz Salikhov
b68e1f7170
fix: Add pragma once checker ( #7580 )
2026-06-24 12:24:04 +00:00
Zhiyuan Wang
19a9ed7767
fix: Move AMMInvariant weakInvariantCheck logic into the transaction ( #7032 )
2026-06-22 18:42:57 +00:00
yinyiqian1
772ea80a25
fix: Use template for granular delegation permissions ( #6613 )
...
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-06-17 23:20:54 +00:00
solunolab
480676d0bf
docs: Fix some comments to improve readability ( #7405 )
...
Signed-off-by: solunolab <solunolab@outlook.com >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-06-17 13:55:00 +00:00
Pratik Mankawde
cccce1c32e
Merge remote-tracking branch 'origin/release/3.2.x' into pratik/merge_3.2.x
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-17 12:53:02 +01:00
Pratik Mankawde
f98c251011
refactor: Improve tracking of book (un)subscriptions
2026-06-15 22:23:38 +01:00
Sergey Kuznetsov
e29dc474b3
refactor: Improve payment channel closing and returned error codes
2026-06-15 22:23:28 +01:00
Ayaz Salikhov
fccb109e48
feat: Use C++ 23 standard ( #7431 )
2026-06-09 17:36:17 +00:00
Bart
c9769d1add
refactor: Use std::move and std::string_view where possible ( #7424 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-06-09 13:56:32 +00:00
Vito Tumas
109b649106
refactor: Use STLedgerEntry type aliases instead of std::shared_ptr ( #7282 )
2026-06-01 15:27:13 +00:00
Vito Tumas
99431d7833
fix: Pin overpayment principal reduction to exact on-grid value ( #7360 )
2026-05-31 22:54:23 +00:00
Vito Tumas
49567e7283
fix: Fix edge-case where vault-depositor may get stuck ( #7139 )
2026-05-26 18:18:40 +00:00
Jingchen
a911f9089e
fix: Use consistent scale for debtTotal ( #7093 )
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-05-24 20:44:29 +00:00
Gregory Tsipenyuk
3547a9335f
fix: Add assorted MPT/DEX fixes ( #7040 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
Co-authored-by: Shawn Xie <35279399+shawnxie999@users.noreply.github.com >
2026-05-21 18:29:53 +00:00
Vito Tumas
7fdaa0a5ef
fix: Fix IOU precision issues in LoanBrokerCover transactions ( #7274 )
2026-05-21 14:51:58 +00:00
Alex Kremer
a830ab10ef
style: More clang-tidy identifier renaming ( #7290 )
2026-05-20 21:31:15 +00:00
Vito Tumas
9cb049276d
feat: Propagate underlying MPT flags to vault shares ( #7077 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: Denis Angell <dangell@transia.co >
Co-authored-by: Fomo <508629+shortthefomo@users.noreply.github.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-05-20 19:44:09 +00:00
Alex Kremer
5b6e8b6f93
refactor: Rename static constants ( #7120 )
...
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-05-15 15:32:19 +00:00
Mayukha Vadari
028f0cb5da
refactor: Use isFlag where possible instead of bitwise math ( #7278 )
2026-05-15 14:00:13 +00:00
Alex Kremer
cdee9a675c
refactor: Use more scoped enums ( #7086 )
2026-05-11 15:39:48 +00:00
Vito Tumas
4f8142fd10
fix: Numerically-stable (1+r)^n-1 in computePaymentFactor ( #7033 )
2026-05-07 19:02:09 +00:00
Olek
af89854a43
fix: Stop tx processing if failed to delete expired credentials ( #6715 ) ( #6962 )
...
Co-authored-by: Ed Hennis <ed@ripple.com >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-05-07 12:57:50 +00:00
Alex Kremer
8995564ed6
refactor: Enable clang-tidy readability-identifier-naming check ( #6571 )
2026-05-03 10:31:53 +00:00
Bart
182d844996
refactor: Revert certain Throws by LogicErrors ( #7036 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-05-01 09:50:00 +00:00
Alex Kremer
f7275b7ad9
chore: Enable clang-tidy v21 new checks ( #7031 )
2026-04-29 15:17:35 +00:00
Alex Kremer
4dc923dcc5
chore: Enable clang-tidy modernize-use-nodiscard check ( #7015 )
2026-04-24 17:19:30 +00:00
Mayukha Vadari
7cfa5d4610
fix: Make assorted Payments fixes ( #6585 )
2026-04-24 12:56:50 +00:00
Mayukha Vadari
248cb29681
refactor: Move LendingHelpers into libxrpl/ledger/helpers ( #6638 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-04-24 12:06:26 +00:00
Mayukha Vadari
1c6cdc653c
fix: More clang-tidy issues ( #6992 )
2026-04-22 17:42:15 +00:00
Alex Kremer
ce3951bbb3
chore: Enable clang-tidy modernize checks ( #6975 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-04-21 15:32:51 +00:00
Alex Kremer
653a383ff5
chore: Enable clang-tidy include cleaner ( #6947 )
2026-04-17 16:43:49 +00:00