Pratik Mankawde
3547112540
fix: Fix ubsan flagged issues ( #6151 )
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com >
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-04-27 20:34:16 +00:00
Alex Kremer
4dc923dcc5
chore: Enable clang-tidy modernize-use-nodiscard check ( #7015 )
2026-04-24 17:19:30 +00:00
Mayukha Vadari
9ae29612ea
fix: Fix flaky CI tests ( #7005 )
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2026-04-24 13:23:43 +00:00
Mayukha Vadari
248cb29681
refactor: Move LendingHelpers into libxrpl/ledger/helpers ( #6638 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-04-24 12:06:26 +00:00
Alex Kremer
19da25812b
fix: Remaining clang-tidy unchecked optionals ( #6979 )
2026-04-23 16:21:01 +00:00
Jingchen
7cd503859e
refactor: Remove seq from TMGetObjectByHash ( #6976 )
2026-04-23 13:59:23 +00:00
pdp2121
bd1b126230
feat: Add --definitions flag and artifact ( #6858 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-04-22 20:10:52 +00:00
Mayukha Vadari
1c6cdc653c
fix: More clang-tidy issues ( #6992 )
2026-04-22 17:42:15 +00:00
Vito Tumas
2e307329f0
refactor: Add transaction-specific invariant checking ( #6551 )
2026-04-22 14:41:19 +00:00
Alex Kremer
ce3951bbb3
chore: Enable clang-tidy modernize checks ( #6975 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-04-21 15:32:51 +00:00
Alex Kremer
ea023121f5
fix: Add rounding to Vault invariants ( #6217 ) ( #6955 )
...
Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com >
Co-authored-by: Ed Hennis <ed@ripple.com >
2026-04-21 12:14:07 +00:00
yinyiqian1
4b198cd5bb
fix: Disallow MPTClearRequireAuth if is set ( #6712 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-04-20 21:25:52 +00:00
Alex Kremer
726f20c8f6
feat: Add GRPC TLS support ( #6374 )
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2026-04-20 17:12:14 +00:00
Zhiyuan Wang
96643bb0fa
fix: Check for empty sfAdditionalBooks array in hybrid offer invariant ( #6716 )
2026-04-20 17:10:28 +00:00
Alex Kremer
653a383ff5
chore: Enable clang-tidy include cleaner ( #6947 )
2026-04-17 16:43:49 +00:00
Gregory Tsipenyuk
affe5835fe
fix: Change AMMClawback return code to tecNO_PERMISSION ( #6946 )
2026-04-17 14:19:58 +00:00
Alex Kremer
f1a5ba43ad
chore: Enable clang-tidy readability checks ( #6930 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-04-17 13:30:52 +00:00
Alex Kremer
6a0ce46755
chore: Enable most clang-tidy bugprone checks ( #6929 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-04-14 20:24:21 +00:00
Bart
2f029a2120
refactor: Improve exception handling ( #6540 ) ( #6735 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-04-14 17:14:24 +00:00
yinyiqian1
d52dd29d20
fix: Address AI reviewer comments for Permission Delegation ( #6675 )
2026-04-08 20:22:19 +00:00
Mayukha Vadari
7793b5f10b
refactor: Combine AMMHelpers and AMMUtils ( #6733 )
2026-04-08 17:38:33 +00:00
Gregory Tsipenyuk
dfcad69155
feat: Add MPT support to DEX ( #5285 )
2026-04-08 16:17:37 +00:00
Pratik Mankawde
6d1a5be8d2
fix: Handle WSClient write failure when server closes WebSocket ( #6671 )
...
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com >
2026-04-07 19:15:40 +00:00
Bart
c00ed673a8
refactor: Rename non-functional uses of ripple(d) to xrpl(d) ( #6676 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-04-07 13:00:17 +00:00
Mayukha Vadari
f239256d87
refactor: Move more helper files into libxrpl/ledger/helpers ( #6731 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-04-06 22:36:32 +00:00
Mayukha Vadari
00761dbb67
fix: Minor RPC fixes ( #6730 )
2026-04-06 22:15:16 +00:00
Zhiyuan Wang
077e03ff33
fix: Prevent deletion of MPTokens with active escrow ( #6635 )
...
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-04-06 17:51:46 +00:00
Vito Tumas
7d524a03b8
fix: Clamp VaultClawback to assetsAvailable for zero-amount clawback ( #6646 )
2026-04-06 15:13:03 +00:00
Vito Tumas
c0ee813666
fix: Add assorted Lending Protocol fixes ( #6678 )
...
Co-authored-by: Shawn Xie <35279399+shawnxie999@users.noreply.github.com >
2026-04-03 17:41:45 +00:00
Mayukha Vadari
81555d5456
refactor: Reorganize RPC handler files ( #6628 )
2026-04-02 23:46:17 +00:00
yinyiqian1
6d9ed125f3
fix: Decouple reserve from fee in delegate payment ( #6568 )
2026-04-02 20:48:00 +00:00
Vito Tumas
02fa55df8d
fix: Check trustline limits for share-denominated vault withdrawals ( #6645 )
2026-04-01 19:31:45 +00:00
Alex Kremer
29e49abd3c
chore: Enable clang-tidy coreguidelines checks ( #6698 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-04-01 15:46:14 +00:00
Vito Tumas
bee1056faa
fix: Enforce aggregate MaximumAmount in multi-send MPT ( #6644 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-04-01 13:35:13 +00:00
Alex Kremer
2502befb42
chore: Enable clang-tidy misc checks ( #6655 )
2026-03-31 17:29:45 +00:00
Bart
7f53351920
chore: Remove unnecessary clang-format off/on directives ( #6682 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-03-31 15:38:04 +00:00
Alex Kremer
ab8c168e3b
chore: Enable remaining clang-tidy performance checks ( #6648 )
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2026-03-30 17:08:47 +00:00
Jingchen
3a477e4d01
refactor: Address PR comments after the modularisation PRs ( #6389 )
...
Signed-off-by: JCW <a1q123456@users.noreply.github.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-03-30 15:22:38 +00:00
Jingchen
addc1e8e25
refactor: Make function naming in ServiceRegistry consistent ( #6390 )
...
Signed-off-by: JCW <a1q123456@users.noreply.github.com >
Co-authored-by: Ed Hennis <ed@ripple.com >
2026-03-26 14:11:16 +00:00
Jingchen
8f182e825a
refactor: Modularise ledger ( #6536 )
...
Signed-off-by: JCW <a1q123456@users.noreply.github.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
Co-authored-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-03-25 16:32:45 +00:00
Alex Kremer
403fd7c649
fix: More clang-tidy issues found after merging to develop ( #6640 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-03-25 14:28:28 +00:00
Alex Kremer
0eedefbf45
refactor: Enable more clang-tidy readability checks ( #6595 )
...
Co-authored-by: Sergey Kuznetsov <kuzzz99@gmail.com >
2026-03-24 15:42:12 +00:00
Mayukha Vadari
8b986e4ab0
refactor: Improve imports to only call the needed helpers ( #6624 )
2026-03-24 10:20:32 +00:00
Mayukha Vadari
e0dbe90370
refactor: Move ledger entry helper functions from View.h/View.cpp to dedicated helper files ( #6453 )
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2026-03-23 15:39:58 +00:00
Mayukha Vadari
d360e7c5b6
refactor: Rename transactor files/classes to match the tx name ( #6580 )
2026-03-18 19:52:07 +00:00
Alex Kremer
57e4cbbcd9
refactor: Add simple clang-tidy readability checks ( #6556 )
...
This change enables the following clang-tidy checks:
- readability-avoid-nested-conditional-operator,
- readability-avoid-return-with-void-value,
- readability-braces-around-statements,
- readability-const-return-type,
- readability-container-contains,
- readability-container-size-empty,
- readability-else-after-return,
- readability-make-member-function-const,
- readability-redundant-casting,
- readability-redundant-inline-specifier,
- readability-redundant-member-init,
- readability-redundant-string-init,
- readability-reference-to-constructed-temporary,
- readability-static-definition
2026-03-18 16:41:49 +00:00
Mayukha Vadari
dcaef828b4
refactor: Replace !=/== tesSuccess with using isTesSuccess ( #6409 )
...
This change replaces all instances of `<variable> != tesSUCCESS` with `!isTesSuccess(<variable>)` and `<variable> == tesSUCCESS` with `isTesSuccess(<variable>)`.
2026-03-18 14:15:10 +00:00
yinyiqian1
6fbeb04d9e
fix: Disallow empty permission list when Delegate object is absent ( #6542 )
...
This change fixes delegation:
* If the Delegate object is not present, we should disallow empty permission list in DelegateSet preclaim.
* Empty permission list is only allowed to delete the existing Delegate object.
* In `doApply`, permission list being empty returns `tecINTERNAL`, which should not happen.
2026-03-18 13:39:31 +00:00
Alex Kremer
2a325e7e2c
chore: Enable clang-tidy bugprone-use-after-move check ( #6476 )
2026-03-18 00:12:06 +00:00
Alex Kremer
72f4cb097f
refactor: Enable remaining clang-tidy cppcoreguidelines checks ( #6538 )
2026-03-17 19:09:05 +00:00