Pratik Mankawde
57a54ad0fe
Merge branch 'pratik/otel-phase1a-plan-docs' into pratik/otel-phase1b-telemetry-infra
2026-06-09 13:34:58 +01:00
Ayaz Salikhov
63ffdc39dc
ci: Refactor build-related nix / docker / workflows ( #7408 )
2026-06-05 17:05:19 +00:00
Ayaz Salikhov
8abe82eefa
ci: Redesign matrix configuration based on Nix images ( #7385 )
...
Co-authored-by: semgrep-companion-app[bot] <218312740+semgrep-companion-app[bot]@users.noreply.github.com>
2026-06-04 20:02:59 +00:00
Ayaz Salikhov
12e81abef3
ci: Improve sanitizer-libs, add doxygen, dpkg, rpm in nix ( #7403 )
2026-06-04 14:52:42 +00:00
Ayaz Salikhov
6c543426c3
ci: Fix clang asan include dirs in nix images, add curl & gnupg ( #7400 )
2026-06-03 22:19:15 +00:00
Ayaz Salikhov
023bdaeeed
ci: Install gcov, nettools, cacert in nix images ( #7398 )
2026-06-03 19:14:17 +00:00
Ayaz Salikhov
ad111bcc22
ci: Patch binaries in nix-based images and test in every distro ( #7376 )
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-06-02 13:51:20 +00:00
Ayaz Salikhov
d4cb68d5a1
ci: Check binaries separately from building them ( #7355 )
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-06-01 16:47:01 +00:00
Pratik Mankawde
3a1f22583f
Merge branch 'pratik/otel-phase1a-plan-docs' into pratik/otel-phase1b-telemetry-infra
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-05-29 15:34:22 +01:00
Ayaz Salikhov
23d0812827
style: Use shfmt instead of bashate ( #7326 )
2026-05-26 18:28:23 +00:00
Ayaz Salikhov
49cb3f45a4
ci: Add clang to nix images ( #7308 )
...
Co-authored-by: semgrep-companion-app[bot] <218312740+semgrep-companion-app[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-05-26 15:45:33 +00:00
Ayaz Salikhov
648ec747f2
feat: Implement nix-based Dockerfile for CI ( #7083 )
2026-05-13 15:10:53 +00:00
Pratik Mankawde
e9c5c3520e
fix(telemetry): address Phase 1b code review findings
...
Redesign SpanGuard with pimpl idiom to hide all OpenTelemetry types
from public headers. Add global Telemetry accessor so SpanGuard factory
methods work without explicit Telemetry references. Add child/linked
span creation and cross-thread context propagation. Update plan docs
to reflect macro removal in favor of SpanGuard factory pattern.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-04-28 14:26:05 +01:00
Pratik Mankawde
3852b5ae4b
fix(telemetry): address review findings and PR #6437 comments
...
Critical fixes:
- Restore accidentally removed mallocTrim call and MallocTrim.h include
- Add missing shouldTraceLedger() to interface and all implementations
- Derive networkId/networkType from config_->NETWORK_ID (0=mainnet,
1=testnet, 2=devnet) instead of leaving defaults unpopulated
- Clamp sampling_ratio to [0.0, 1.0] in config parser
PR comment fixes:
- Rename rippled -> xrpld in service name defaults, getTracer() calls,
Docker network, comments, and docs/build/telemetry.md
- Remove exporter config option (only otlp_http supported)
- Add trace_ledger and service_name to example config
- Clarify head-based sampling semantics in config comments
- Add filter descriptions for span intrinsic filters in Grafana datasource
- Add inline comments to Docker Compose services
Docker/config improvements:
- Remove deprecated version: "3.8" from docker-compose.yml
- Pin images: collector 0.121.0, grafana 11.5.2
- Add health_check extension to otel-collector-config.yaml
- Comment out Tempo metrics_generator remote_write (no Prometheus service)
- Add Prometheus datasource caveat in Grafana datasource config
Other:
- Revert unrelated formatting changes in ServiceRegistry.h
- Change Conan telemetry default to False (matches CMake OFF)
- Add CLAUDE.md-required docs (ASCII diagrams, usage examples,
@note thread-safety) to Telemetry.h and SpanGuard.h
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-04-28 14:25:31 +01:00
Pratik Mankawde
ca2d616277
refactor(telemetry): remove Jaeger service, exporter, and datasource
...
Tempo is now the sole trace backend. Remove Jaeger all-in-one service
from docker-compose, otlp/jaeger exporter from OTel Collector config,
and Jaeger Grafana datasource provisioning file.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
2026-04-28 14:25:31 +01:00
Pratik Mankawde
88686af850
Phase 1b: Telemetry core infrastructure - CMake, Conan, SpanGuard, config
...
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-04-28 14:25:31 +01:00
