Ed Hennis
b69b9242e2
fixup! clang-tidy: Avoid nested "?:" in global Rules initialization
2026-05-14 20:33:15 -04:00
Ed Hennis
cd2fcf0a5e
Merge branch 'develop' into ximinez/number-fix-maxrepcusp
2026-05-14 18:25:17 -04:00
Ed Hennis
69656d6b67
clang-tidy: Avoid nested "?:" in global Rules initialization
2026-05-14 18:24:05 -04:00
Jingchen
cce4cfef10
feat: Add verify_endpoints to help local peer network development ( #7268 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-05-14 17:07:08 +00:00
Ed Hennis
46b946b22e
clang-tidy: missing include
2026-05-13 22:32:37 -04:00
Ed Hennis
ae03b30f29
Merge branch 'develop' into ximinez/number-fix-maxrepcusp
2026-05-13 20:16:19 -04:00
Bart
afbccf971a
chore: Consolidate fix amendments ( #7134 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-05-13 20:46:30 +00:00
Olek
d4ebd6a168
fix: Backport Permissioned Domains fixes ( #7016 )
2026-05-13 19:22:29 +00:00
Luc des Trois Maisons
aa5e4ff89f
refactor: Improve Forwarded header field parsing ( #7126 )
2026-05-13 16:48:38 +00:00
Sergey Kuznetsov
977e5a7dba
fix: Check network ID in transactionSignFor ( #7102 )
2026-05-13 16:03:57 +00:00
Ed Hennis
4c7c019add
Merge branch 'develop' into ximinez/number-fix-maxrepcusp
2026-05-13 12:03:35 -04:00
Sergey Kuznetsov
c8b42a7f48
refactor: Improve RPC variable naming and handling ( #7103 )
2026-05-13 14:33:49 +00:00
Valentin Balaschenko
4ad94ae2ff
refactor: Use named constant for leaf item size ( #39 ) ( #7130 )
...
Co-authored-by: Ed Hennis <ed@ripple.com >
2026-05-13 13:53:01 +00:00
Valentin Balaschenko
411286c519
refactor: Prevent dry-run transactions from being queued ( #92 ) ( #7131 )
2026-05-13 13:22:00 +00:00
Alex Kremer
e8bdbaa1e8
refactor: Limit JSON array size ( #7112 )
2026-05-13 12:42:05 +00:00
Vito Tumas
6340c986c9
feat: Enable and rename fixSecurity3_1_3 to fixCleanup3_1_3 ( #7128 )
...
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
2026-05-13 09:42:34 +00:00
Ed Hennis
47f30c913d
Fix broken unit tests: EscrowToken
...
- Some EscrowToken tests used a hard-coded list of amendments to
determine whether to expect large mantissa logic. That ignored the
effects of fixCleanup3_2_0, especially as applied to the previous fix
affecting preflight, preclaim, etc.
- Add a helper function, useRulesGuards, which will return the same
decision as createGuards and setCurrentRulesImpl. Use that helper
function in the relevant tests.
- Also remove an #include that clang-tidy was complaining about.
2026-05-12 21:26:54 -04:00
Ed Hennis
d7d5b83f6d
Merge branch 'develop' into ximinez/number-fix-maxrepcusp
2026-05-12 19:18:45 -04:00
Ed Hennis
e22938d69f
AI review feedback: createGuards
...
- Refactor the Guard decision in withTxnType into createGuards, which
lives in Rules.cpp. It is physically located near
setCurrentTransactionRules, and documented to explain that changes
need to be synchronized.
2026-05-12 18:44:05 -04:00
Ed Hennis
7c9a56ff24
Merge branch 'develop' into ximinez/number-fix-maxrepcusp
2026-05-12 16:26:09 -04:00
Olek
590906dadf
fix: Use transaction sequence numbers in permissioned domains ( #7129 )
2026-05-12 20:15:17 +00:00
Sergey Kuznetsov
448ae8b9df
fix: Improve json parsing of currency issuers ( #7110 )
2026-05-12 20:13:36 +00:00
Ed Hennis
5a40416673
Merge branch 'develop' into ximinez/number-fix-maxrepcusp
2026-05-12 15:59:19 -04:00
rrmanukyan
45b1f4dbeb
refactor: Fill txJson based on apiVersion ( #7109 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-05-12 19:27:07 +00:00
Ed Hennis
8012b5d34f
fix: Fix touchy "funds are conserved" assertion in LoanPay ( #6231 ) ( #6967 )
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2026-05-12 19:25:11 +00:00
Ayaz Salikhov
6c2266c5c7
refactor: Remove erroneous base_uint ctor from container ( #7123 )
2026-05-12 19:24:05 +00:00
Mayukha Vadari
c4c95dbe76
refactor: Replace featureInvariantsV1_1 with fixCleanup3_2_0 ( #7116 )
2026-05-12 12:26:02 +00:00
Ed Hennis
30334cd1f4
Merge branch 'develop' into ximinez/number-fix-maxrepcusp
2026-05-11 13:34:11 -04:00
Alex Kremer
cdee9a675c
refactor: Use more scoped enums ( #7086 )
2026-05-11 15:39:48 +00:00
Zhiyuan Wang
779b49cd93
fix: Prevent stale AuthAccounts from persisting after tfTwoAssetIfEmpty re-initialization ( #6996 )
...
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-05-09 14:43:56 +00:00
Ed Hennis
5558e1b522
Merge branch 'develop' into ximinez/number-fix-maxrepcusp
2026-05-07 18:10:03 -04:00
Ed Hennis
cd0f49a003
Address more nitpicky AI comments
2026-05-07 17:05:10 -04:00
Ed Hennis
22d2703ce8
What is it going to take to get clang-tidy to shut up?
2026-05-07 16:50:43 -04:00
Vito Tumas
4f8142fd10
fix: Numerically-stable (1+r)^n-1 in computePaymentFactor ( #7033 )
2026-05-07 19:02:09 +00:00
Ed Hennis
1b6047afe1
More clang-tidy changes: AMMExtended_test member and Number_test includes
2026-05-07 13:51:48 -04:00
Ed Hennis
175a04160d
Merge branch 'develop' into ximinez/number-fix-maxrepcusp
2026-05-07 13:28:33 -04:00
Alex Kremer
7afdd71a54
chore: More fixes for bad renames ( #7092 )
2026-05-07 17:04:30 +00:00
Olek
af89854a43
fix: Stop tx processing if failed to delete expired credentials ( #6715 ) ( #6962 )
...
Co-authored-by: Ed Hennis <ed@ripple.com >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-05-07 12:57:50 +00:00
Ed Hennis
d6c4e6cb93
fix: Cap the base fee for LoanPay ( #6969 ) ( #6970 )
...
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-05-07 12:48:55 +00:00
Bart
8c71ec803d
fix: Restore clang-tidy change to section name in config ( #7091 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-05-07 10:34:47 +00:00
Ed Hennis
b050c151f8
Fix clang-tidy issues, and more AI complaints
2026-05-06 23:26:11 -04:00
Ed Hennis
b40d2a8e7d
fix: Fix a rounding error at the Number::maxRep cusp
...
- Add helper function, doDropDigit, to wrap the common pattern:
push(mantissa % 10);
mantissa /= 10;
++exponent;
- Might have been helpful to catch this issue when developing.
2026-05-06 22:49:44 -04:00
Ayaz Salikhov
8e2aa33f64
chore: Add IWYU pragma for boost::optional to fix clang-tidy ( #7088 )
2026-05-06 23:31:10 +00:00
Vito Tumas
a4720d0449
chore: Mark empty transactor invariants as future work ( #7080 )
2026-05-06 12:55:24 +00:00
Vet
50244a8637
chore: Update default values of base and owner reserve to 1/0.2 ( #6382 )
...
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-05-06 11:19:57 +00:00
Mayukha Vadari
5e1c35f7f7
fix: Fix regressions in server_definitions ( #7008 )
2026-05-05 17:18:26 +00:00
Alex Kremer
8995564ed6
refactor: Enable clang-tidy readability-identifier-naming check ( #6571 )
2026-05-03 10:31:53 +00:00
Bart
182d844996
refactor: Revert certain Throws by LogicErrors ( #7036 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-05-01 09:50:00 +00:00
Vito Tumas
31180f94c2
fix: Prevents overwriting a bool value in an invariant ( #6609 )
...
Co-authored-by: Ed Hennis <ed@ripple.com >
2026-04-30 13:05:09 +00:00
Bart
4d0ea8ae36
refactor: Apply various minor improvements and corrections ( #7045 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-04-30 10:22:11 +00:00