Pratik Mankawde
58d4e48679
fix(telemetry): restore injectCurrentContextToProtobuf decl; re-parent open/establish spans under round; correct childSpan names
...
Post-review fixes for the SpanGuard scope-leak change:
- SpanGuard.h: restore the injectCurrentContextToProtobuf real-class
declaration, its #else no-op stub, and the protocol::TraceContext
forward-declaration dropped during the 3->4 union merge (compile break).
- Re-parent consensus.phase.open and consensus.establish under the round
span via a new RCLConsensus::Adaptor::roundSpanContext() accessor: the
round span is now detached, so ambient parenting no longer works; the
phase spans link explicitly to the captured round context. csf::Peer
gains a matching no-op accessor so the generic engine still compiles.
- Switch five childSpan(op::X, ctx) sites to the full consensus::span::X
constants: childSpan(name, ctx) takes the name verbatim, so the suffix-
only op:: constants emitted short, non-dotted span names.
- TestTelemetry mock: add getConsensusTraceStrategy() override (base pure
virtual introduced on this branch) so the mock is not abstract.
- validate(): rewrite the trace_context comment to drop attack-surface
framing and the PR-discussion reference.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-07-20 15:25:15 +01:00
Pratik Mankawde
c3b1f69ba8
Merge branch 'pratik/otel-phase3-tx-tracing' into pratik/otel-phase4-consensus-tracing
...
# Conflicts:
# include/xrpl/telemetry/SpanGuard.h
# src/xrpld/app/consensus/RCLConsensus.h
# src/xrpld/consensus/ConsensusTypes.h
2026-07-20 12:10:44 +01:00
Vito Tumas
5ce0b1c2c7
refactor: Restructure LendingHelpers to improve readability ( #7807 )
2026-07-16 15:47:56 +00:00
Andrzej Budzanowski
701311f27e
test: Add google benchmark dependency and migrate nodestore timing test as a benchmark ( #7317 )
...
Co-authored-by: Marek Foss <marek.foss@neti-soft.com >
Co-authored-by: Alex Kremer <akremer@ripple.com >
2026-07-16 15:44:43 +00:00
Denis Angell
69b70d7a0d
fix: Refactor Batch Transaction IDs ( #7736 )
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
Co-authored-by: Mayukha Vadari <mvadari@ripple.com >
2026-07-16 13:15:59 +00:00
Vlad
433e5f6896
fix: Reject zero CheckID in CheckCancel and CheckCash ( #7685 )
2026-07-15 22:08:45 +00:00
Kassaking7
cda63d00a2
fix: Add amendment sponsor for AccountRootsDeletedClean ( #7801 )
2026-07-14 19:41:53 +00:00
Ed Hennis
530e09dbe8
fix: Update base_uint and test changes released in 3.1.3 ( #7570 )
...
Co-authored-by: Sergey Kuznetsov <skuznetsov@ripple.com >
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-07-14 18:48:10 +00:00
Ed Hennis
f10dd7b450
fix: Handle rounding just above kMaxRep more accurately ( #7389 )
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com >
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-07-14 18:47:41 +00:00
Gregory Tsipenyuk
2403670da9
fix: Strengthen Clawback invariant checks for MPT balances ( #7285 )
2026-07-14 14:31:06 +00:00
Jingchen
c621136748
test: Add unit tests for IP address related functions ( #7744 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
Co-authored-by: Ed Hennis <ed@ripple.com >
2026-07-14 14:29:18 +00:00
Alex Kremer
73e97b8b84
test: Add JSON array size tests ( #7592 )
2026-07-14 12:35:04 +00:00
Ayaz Salikhov
e1d4f357dc
chore: Enable most readability checks ( #7772 )
2026-07-14 12:21:40 +00:00
Peter Chen
752dab8b30
feat: Add delegate filter param for account_tx RPC ( #6126 )
2026-07-13 18:44:59 +00:00
Ayaz Salikhov
73b6852a12
style: Unify style for all Doxygen comments ( #7776 )
2026-07-13 10:40:40 +00:00
Ed Hennis
8306ac7710
fix: Improve Number addition/subtraction rounding ( #7369 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-07-11 00:18:31 +00:00
Olek
fd2cc6dcb3
feat: XLS-68: Sponsor, #5887 continuation ( #7350 )
...
Co-authored-by: tequ <git@tequ.dev >
Co-authored-by: yinyiqian1 <yqian@ripple.com >
Co-authored-by: Mayukha Vadari <mvadari@ripple.com >
Co-authored-by: Mayukha Vadari <mvadari@gmail.com >
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
Co-authored-by: Peter Chen <34582813+PeterChen13579@users.noreply.github.com >
Co-authored-by: Zhiyuan Wang <96991820+Kassaking7@users.noreply.github.com >
Co-authored-by: Ayaz Salikhov <asalikhov@ripple.com >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
Co-authored-by: Zhiyuan Wang <1830604455@qq.com >
2026-07-10 21:58:19 +00:00
Pratik Mankawde
02b32ecdd8
Merge branch 'pratik/otel-phase3-tx-tracing' into pratik/otel-phase4-consensus-tracing
2026-07-08 16:02:51 +01:00
Ayaz Salikhov
e372c45836
chore: Enable most performance checks ( #7727 )
2026-07-07 21:03:56 +00:00
Ayaz Salikhov
c5a6de6ef7
chore: Enable most cppcoreguidelines checks ( #7660 )
2026-07-07 13:12:52 +00:00
Marek Foss
f5e63f8a91
test: Migrate basics Beast tests to GTest ( #7136 )
...
Co-authored-by: Alex Kremer <akremer@ripple.com >
2026-07-06 19:48:36 +00:00
Marek Foss
7a153a2bce
test: Migrate resource, shamap Beast tests to GTest ( #7133 )
...
Co-authored-by: Alex Kremer <akremer@ripple.com >
2026-07-06 17:26:19 +00:00
Pratik Mankawde
e969b0c6ed
Merge branch 'pratik/otel-phase3-tx-tracing' into pratik/otel-phase4-consensus-tracing
...
# Conflicts:
# src/test/csf/Peer.h
# src/xrpld/app/consensus/RCLConsensus.h
2026-07-06 17:11:29 +01:00
Ayaz Salikhov
f59d5c0894
chore: Enable most misc checks ( #7663 )
2026-07-06 15:22:11 +00:00
Ayaz Salikhov
d07d2aba2e
chore: Enable most modernize checks ( #7664 )
2026-07-06 12:19:52 +00:00
Ayaz Salikhov
c92285f10d
chore: Delete dead code ( #7718 )
2026-07-03 15:59:20 +00:00
Ayaz Salikhov
53649cc298
chore: Enable modernize-use-constraints ( #7715 )
2026-07-03 14:28:15 +00:00
Ayaz Salikhov
f151293e8a
chore: Enable modernize-avoid-bind ( #7711 )
2026-07-03 11:17:03 +00:00
Ayaz Salikhov
7ba1d76d05
chore: Enable modernize-use-auto ( #7707 )
2026-07-02 20:02:55 +00:00
yinyiqian1
6003fd03fc
feat: Enable ConfidentialTransfer and BatchV1_1 ( #7698 )
2026-07-02 18:37:37 +00:00
Ayaz Salikhov
41622b87ae
chore: Enable modernize-unary-static-assert ( #7705 )
2026-07-02 18:30:59 +00:00
Ayaz Salikhov
6f0f5b8bb3
chore: Make clang-tidy happy on macOS ( #7701 )
2026-07-02 16:26:09 +00:00
Timothy Banks
4c619e8a85
refactor: Retire DisallowIncomingV1 fix ( #7364 )
2026-07-02 14:17:32 +00:00
Ayaz Salikhov
8e378c4f47
build: Add verify-headers target to cleanup headers ( #7670 )
2026-07-01 23:14:17 +00:00
Timothy Banks
c53aafa6bf
refactor: Retire InnerObjTemplate fix ( #7368 )
2026-07-01 15:36:28 +00:00
Vito Tumas
0d149ba5b6
fix: Disable AMM creation with Vault shares ( #7666 )
2026-07-01 15:04:38 +00:00
Ayaz Salikhov
d1ff948244
test: Add tests for TMProofPathResponse and TMReplayDeltaResponse invalid hash/key sizes ( #7593 )
2026-07-01 13:30:03 +00:00
Vito Tumas
ea13be81b7
feat: Add an invariant to ensure object deletion also deletes its pseudo-account ( #7445 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-07-01 13:21:23 +00:00
Denis Angell
86d8b244d6
feat: Add Batch (XLS-56) V1_1 ( #6446 )
...
Co-authored-by: Mayukha Vadari <mvadari@ripple.com >
2026-07-01 12:47:14 +00:00
Vito Tumas
ecf7f805c9
feat: Introduce lending 1.1 amendment and add MemoData field to VaultDelete transaction ( #6324 )
2026-06-30 23:51:41 +00:00
Ayaz Salikhov
8abbd1ba3a
chore: Use std::ranges where possible ( #7634 )
2026-06-30 11:03:19 +00:00
Ayaz Salikhov
74b55a59b2
chore: Enable most bugprone checks ( #7643 )
2026-06-29 13:20:17 +00:00
Shawn Xie
768d7603b1
feat: Confidential Transfer for MPT ( #5860 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: chuanshanjida <chuanshanjida@outlook.com >
Co-authored-by: Ed Hennis <ed@ripple.com >
Co-authored-by: Jingchen <a1q123456@users.noreply.github.com >
Co-authored-by: Denis Angell <dangell@transia.co >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
Co-authored-by: yinyiqian1 <yqian@ripple.com >
Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com >
Co-authored-by: Bronek Kozicki <brok@incorrekt.com >
Co-authored-by: Mayukha Vadari <mvadari@ripple.com >
Co-authored-by: Valentin Balaschenko <13349202+vlntb@users.noreply.github.com >
Co-authored-by: tequ <git@tequ.dev >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
Co-authored-by: Peter Chen <34582813+PeterChen13579@users.noreply.github.com >
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
Co-authored-by: Zhiyuan Wang <96991820+Kassaking7@users.noreply.github.com >
Co-authored-by: Alex Kremer <akremer@ripple.com >
Co-authored-by: Sergey Kuznetsov <skuznetsov@ripple.com >
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Gregory Tsipenyuk <gregtatcam@users.noreply.github.com >
Co-authored-by: chuanshanjida <chuanshanjida@outlook.com >
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
Co-authored-by: Peter Chen <ychen@ripple.com >
Co-authored-by: Timothy Banks <timothyaaronbanks@gmail.com >
Co-authored-by: Timothy Banks <tbanks@ripple.com >
2026-06-27 01:20:38 +00:00
yinyiqian1
fd8a915243
fix: Use trustline balance direction to validate IOU PaymentMint/PaymentBurn ( #7584 )
2026-06-26 22:26:53 +00:00
Vito Tumas
3e9f1d0ab8
fix: Unify freeze checks for pseudo-account deposit/withdraw ( #7382 )
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
Co-authored-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
Co-authored-by: Shawn Xie <35279399+shawnxie999@users.noreply.github.com >
2026-06-26 21:38:59 +00:00
yinyiqian1
652b5f9af1
fix: Block delegate tx from being queued ( #7640 )
2026-06-26 20:34:22 +00:00
Pratik Mankawde
bc7cff230c
Merge branch 'pratik/otel-phase3-tx-tracing' into pratik/otel-phase4-consensus-tracing
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-26 14:45:43 +01:00
Timothy Banks
2ab43b6fda
refactor: Retire NFTokenReserve fix ( #7367 )
2026-06-26 10:31:16 +00:00
Timothy Banks
12a5d9014e
refactor: Retire Clawback amendment ( #7353 )
2026-06-26 10:24:25 +00:00
Mayukha Vadari
b9eee1d245
refactor: Rename (mostly keylet) functions to more closely match the docs ( #7059 )
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2026-06-26 10:24:12 +00:00