Ed Hennis
9798172086
Merge branch 'ximinez/lending-XLS-66-ongoing' into ximinez/lending-number-simple
2025-12-05 21:29:53 -05:00
Ed Hennis
065f7171eb
Merge branch 'ximinez/develop-nolending' into ximinez/lending-XLS-66-2
2025-12-05 21:28:36 -05:00
Ed Hennis
d95e0e542f
Merge branch 'develop' into ximinez/develop-nolending
2025-12-05 21:14:03 -05:00
Bart
813bc4d949
refactor: Replaces secp256k1 source by Conan package ( #6089 )
...
This change substitutes the secp256k1 source code copy by the Conan recipe added in XRPLF/conan-center-index#24 , which updates the version of the library to 0.7.0.
2025-12-04 08:32:45 -05:00
Ed Hennis
2e7920cd1a
Merge remote-tracking branch 'XRPLF/develop' into ximinez/lending-number-simple
...
* XRPLF/develop:
Implement Lending Protocol (unsupported) (5270)
2025-12-02 21:34:14 -05:00
Ed Hennis
b772f6281e
Revert "Implement Lending Protocol (unsupported) ( #5270 )"
...
This reverts commit 6c67f1f525 .
2025-12-02 12:20:43 -05:00
Ed Hennis
6c67f1f525
Implement Lending Protocol (unsupported) ( #5270 )
...
- Spec: XLS-66
- Introduces amendment "LendingProtocol", but leaves it UNSUPPORTED to
allow for standalone testing, future development work, and potential
bug fixes.
- AccountInfo RPC will indicate the type of pseudo-account when
appropriate.
- Refactors and improves several existing classes and functional areas,
including Number, STAmount, STObject, json_value, Asset, directory
handling, View helper functions, and unit test helpers.
2025-12-02 16:38:17 +00:00
Ed Hennis
639d6a953c
Refactor the "scaleNumber" conversion functions
...
- Rename to "fromNumber".
- Instead of returning a pair or tuple, returns a constructed object
(IOUAmount, STAmount).
2025-12-01 20:22:15 -05:00
Ed Hennis
8c43a0db93
Clean up some loose ends
...
- Get rid of commented and unused code.
- Add some asserts and static asserts.
- Use the range_ when possible.
2025-12-01 18:36:18 -05:00
Ed Hennis
db52b34f3f
Merge branch 'develop' into ximinez/lending-number-simple
2025-11-28 15:53:18 -05:00
Ed Hennis
eaaea43f80
Refactor Number internals away from int128 to uint64 & a sign flag
2025-11-27 01:47:31 -05:00
Ed Hennis
a87460b89f
Restore the original Number interface
...
- ctors and accessors return `rep`. Very few things expose
`internalrep`.
- An exception is "unchecked" and the new "normalized", which explicitly
take an internalrep. But with those special control flags, it's easier
to distinguish and control when they are used.
- The goal is to get as much of the non-number code back to the previous
state as possible.
2025-11-26 18:32:26 -05:00
Ed Hennis
315b511326
Merge branch 'develop' into ximinez/lending-XLS-66
2025-11-25 14:54:52 -05:00
Jingchen
b124c9f7e3
refactor: Retire Flow and FlowSortStrands amendments ( #6054 )
...
Amendments activated for more than 2 years can be retired. This change retires the Flow and FlowSortStrands amendments.
2025-11-25 14:21:17 +00:00
Ed Hennis
59e6a8107a
Merge branch 'develop' into ximinez/lending-number-simple
2025-11-24 21:49:58 -05:00
Ed Hennis
814fe018b7
Merge branch 'develop' into ximinez/lending-XLS-66
2025-11-24 21:30:08 -05:00
Ed Hennis
71bb08cd78
Review feedback from @Tapanito, @gregtatcam, and @shawnxie999
...
- Created a common doWithdraw function for VaultWithdraw and
LoanBrokerCoverWithdraw. Added verifyDepositPreauth to it, so that
both transactions will get the check.
- Add a missing null check to LoanBrokerSet, and add log messages to the
existing checks.
2025-11-24 20:42:40 -05:00
Ed Hennis
a7af773dd8
Add a LoanBroker invariant to compare CoverAvailable to balance
...
- Ensures that LoanBroker.CoverAvailable is never less than the
pseudo-account balance for the Vault asset.
2025-11-24 16:24:35 -05:00
Jingchen
21c02232a5
refactor: Retire RequireFullyCanonicalSig amendment ( #6035 )
...
Amendments activated for more than 2 years can be retired. This change retires the RequireFullyCanonicalSig amendment.
2025-11-24 13:58:37 +00:00
Jingchen
a791c03dc1
refactor: Retire DeletableAccounts amendment ( #6056 )
...
Amendments activated for more than 2 years can be retired. This change retires the DeletableAccounts amendment.
2025-11-24 11:52:08 +00:00
Jingchen
800a315383
refactor: Retire CryptoConditionsSuite amendment ( #6036 )
...
Amendments activated for more than 2 years can be retired. This change retires the CryptoConditionsSuite amendment.
2025-11-24 06:23:16 -05:00
Ed Hennis
fa2dea84c2
Review feedback from @gregtatcam: STAmount
...
- Fix a couple of typos.
- Make fewer unneeded copies in roundToScale.
2025-11-22 22:30:06 -05:00
Ed Hennis
b82481858a
Review feedback from @gregtatcam
...
- Rename "accountCanSpend" to "accountSpendabled".
- Change some getIssuer() local vars to use references.
2025-11-22 20:57:34 -05:00
Ed Hennis
8bb162ce52
Review feedback from @gregtatcam
...
- Rewrite "Asset::native()" and "integral()" to use std::visit.
- Improve documentation for the LoanPay transaction flags:
tfLoanFullPayment, tfLoanLatePayment
2025-11-22 19:36:50 -05:00
Ed Hennis
1cec91e72d
Move protocol.h values into namespace Lending
2025-11-21 17:20:43 -05:00
Ed Hennis
92388c4491
Merge branch 'develop' into ximinez/lending-number-simple
2025-11-21 14:38:58 -05:00
Ed Hennis
66da6a8608
Merge branch 'develop' into ximinez/lending-XLS-66
2025-11-21 12:47:43 -05:00
Pratik Mankawde
e4dccfd49b
refactor: Retire DisallowIncoming amendment ( #6045 )
...
Amendments activated for more than 2 years can be retired. This change retires the DisallowIncoming amendment.
2025-11-21 15:18:00 +00:00
Jingchen
57f4b4eb7f
refactor: Retire Checks amendment ( #6055 )
...
Amendments activated for more than 2 years can be retired. This change retires the Checks amendment.
2025-11-21 14:19:43 +00:00
Ed Hennis
e45d847558
Merge branch 'develop' into ximinez/lending-number-simple
2025-11-18 22:51:51 -05:00
Ed Hennis
bd0b651891
Merge branch 'develop' into ximinez/lending-XLS-66
2025-11-18 22:39:17 -05:00
sunnyraindy
ad37461ab2
chore: Fix some typos in comments ( #6040 )
2025-11-18 20:21:35 -05:00
Bronek Kozicki
d8b944c218
Enforce assets are transferable ( #6017 )
...
- Includes unit tests for terNO_RIPPLE.
- Switch auth mode to weak when submitter is destination.
- Require rippling enabled for vault deposits or withdrawals.
2025-11-18 18:28:59 -05:00
Jingchen
2c187461cc
refactor: Retire NegativeUNL amendment ( #6033 )
...
Amendments activated for more than 2 years can be retired. This change retires the NegativeUNL amendment.
2025-11-17 14:02:10 +00:00
Ed Hennis
546bfa89d8
For now, skip the larger mantissas in AMM transactions and tests
2025-11-16 20:59:17 -05:00
Ed Hennis
470c9c3936
Fix root2, and add tests for it
2025-11-16 00:18:51 -05:00
Ed Hennis
9f50cc033e
Merge branch 'develop' into ximinez/lending-number-simple
2025-11-15 03:13:10 -05:00
Ed Hennis
cfdcaf3f8d
Merge branch 'develop' into ximinez/lending-XLS-66
2025-11-15 03:08:29 -05:00
Ed Hennis
c9ad49faf3
Step 2.5: Run the STNumber tests using both mantissa sizes
...
- Nothing really needed to be changed in the tests, but I added a couple
of test cases for the min and max int64.
2025-11-14 19:41:26 -05:00
Ed Hennis
857eaffa55
refactor: Move the mantissa_scale enum into the MantissaRange struct
2025-11-14 19:06:44 -05:00
Jingchen
7025e92080
refactor: Retire TicketBatch amendment ( #6032 )
...
Amendments activated for more than 2 years can be retired. This change retires the TicketBatch amendment.
2025-11-14 13:33:34 +00:00
Ed Hennis
606e3ec0b7
Step 2: Add the ability to change the mantissa range
...
- Update tests. Unfinished.
- TODO: Finish Number tests. Use both modes for STNumber tests. Move
mantissa_scale into MantissaRange.
2025-11-14 02:34:56 -05:00
Ed Hennis
2f94838bbf
Merge branch 'develop' into ximinez/lending-XLS-66
2025-11-13 12:18:42 -05:00
Ed Hennis
1c1cd1a391
Change Vault asset fields back to default
...
- Was unintentionally rolled back with `Number` changes.
2025-11-13 12:15:39 -05:00
Ed Hennis
2eca3dca89
Merge remote-tracking branch 'upstream/develop' into ximinez/lending-number-simple
...
* upstream/develop:
chore: Clean up incorrect comments (6031)
refactor: Retire MultiSignReserve and ExpandedSignerList amendments (5981)
2025-11-13 11:01:22 -05:00
Jingchen
508937f3d1
refactor: Retire MultiSignReserve and ExpandedSignerList amendments ( #5981 )
...
Amendments activated for more than 2 years can be retired. This change retires the MultiSignReserve and ExpandedSignerList amendments.
2025-11-13 11:42:45 +00:00
Ed Hennis
7cd48a7713
fixup! Continue with Step 1
2025-11-12 22:58:06 -05:00
Ed Hennis
d2d403da90
Continue with Step 1
...
- Track down and fix edge cases.
- Some refactoring and renaming for clarity and simplicity
2025-11-12 20:32:47 -05:00
Ed Hennis
a4aa72eada
Fix revert issues
2025-11-12 19:19:06 -05:00
Ed Hennis
398170ef3d
Revert "Add optional enforcement of valid integer range to Number"
...
This reverts commit 3cb447a4fe .
2025-11-12 19:15:14 -05:00