ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-06-02 16:26:48 +00:00
Code Issues Packages Projects Releases Wiki Activity
14,208 Commits 260 Branches 188 Tags
933447ce48a3896746cb77012339cc0d0aa2e574
Commit Graph

1224 Commits

Author SHA1 Message Date
Valentin Balaschenko
933447ce48 test case description update 2025-12-05 10:52:42 +00:00
Valentin Balaschenko
5fe00e32a3 fix 2025-12-04 19:38:07 +00:00
Vito Tumas
354531f946 Fix Overpayment Calculation (#6087) 
- Adds additional unit tests to cover math calculations.
- Removes unused methods.
 2025-12-04 12:54:25 -05:00
Ed Hennis
43a6f10050 MPTTester::operator() parameter should be std::int64_t 
- Originally defined as uint64_t, but the testIssuerLoan() test called
  it with a negative number, causing an overflow to a very large number
  that in some circumstances could be silently cast back to an int64_t,
  but might not be. I believe this is UB, and we don't want to rely on
  that.
 2025-12-03 12:35:56 -05:00
Ed Hennis
e2e9582ff1 Test updates - show balances in runLoan() 2025-12-03 12:35:56 -05:00
Ed Hennis
315b511326 Merge branch 'develop' into ximinez/lending-XLS-66 2025-11-25 14:54:52 -05:00
Ed Hennis
40cd57355d Review feedback from @shawnxie999: MPT Clawback 
- MPTs do not require the lsfMPTCanLock flag to be able to clawback
 2025-11-25 14:46:46 -05:00
Jingchen
b124c9f7e3 refactor: Retire Flow and FlowSortStrands amendments (#6054) 
Amendments activated for more than 2 years can be retired. This change retires the Flow and FlowSortStrands amendments.
 2025-11-25 14:21:17 +00:00
Ed Hennis
814fe018b7 Merge branch 'develop' into ximinez/lending-XLS-66 2025-11-24 21:30:08 -05:00
Vito Tumas
24586ef394 Add deep freeze check to LoanBrokerDelete (#6053) 
- Add logging for missing vault
- Fix unit test
 2025-11-24 23:17:34 +00:00
Jingchen
21c02232a5 refactor: Retire RequireFullyCanonicalSig amendment (#6035) 
Amendments activated for more than 2 years can be retired. This change retires the RequireFullyCanonicalSig amendment.
 2025-11-24 13:58:37 +00:00
Jingchen
a791c03dc1 refactor: Retire DeletableAccounts amendment (#6056) 
Amendments activated for more than 2 years can be retired. This change retires the DeletableAccounts amendment.
 2025-11-24 11:52:08 +00:00
Jingchen
800a315383 refactor: Retire CryptoConditionsSuite amendment (#6036) 
Amendments activated for more than 2 years can be retired. This change retires the CryptoConditionsSuite amendment.
 2025-11-24 06:23:16 -05:00
Ed Hennis
4c28e750ff Review feedback from @gregtatcam: compute vs. calculate 
- Rename the LendingHelper functions that started with `calculate` to
  start with `compute`.
 2025-11-23 21:41:38 -05:00
Ed Hennis
4ba2514bfa Review feedback from @gregtatcam: LoanDeltas 
- Renamed to LoanStateDeltas, and document what it's for
 2025-11-23 21:28:09 -05:00
Ed Hennis
27a7138f88 Review feedback from @gregtatcam: constructRoundedLoanState 
- Rename the overload of constructRoundedLoanState that takes components
  as inputs to constructLoanState. The original function did no rounding
  or enforcement of the inputs being rounded.
- Left the overload constructRoundedLoanState(SLE::const_ref loan)
  alone, because Loan objects are assumed to be rounded.
 2025-11-23 21:09:56 -05:00
Ed Hennis
63724e4405 Review feedback from @gregtatcam: seconds per year 
- Define a constexpr secondsInYear in LedgerHelpers.h
 2025-11-23 00:03:52 -05:00
Ed Hennis
973a105959 Review feedback: test coverage, round debt total 
- Add some test cases to improve coverage, and exclude some lines from
  coverage.
- Rounds the Broker.DebtTotal to the Vault scale any time it is
  modified. This should reduce rounding errors.
- Ensure that no debt is left for the Broker after the last loan is
  deleted. This ensures that any accumulated rounding errors are
  resolved.
 2025-11-22 16:07:07 -05:00
Ed Hennis
1cec91e72d Move protocol.h values into namespace Lending 2025-11-21 17:20:43 -05:00
Ed Hennis
b76cd60a12 fixup! Restore code that needs to be amendment gated 2025-11-21 16:39:44 -05:00
Ed Hennis
66da6a8608 Merge branch 'develop' into ximinez/lending-XLS-66 2025-11-21 12:47:43 -05:00
Jingchen
fb74dc28e1 chore: Clean up comment in NetworkOps_test.cpp (#6066) 
This change removes a copyright notice that was accidentally copied over from another file.
 2025-11-21 17:11:00 +00:00
Pratik Mankawde
e4dccfd49b refactor: Retire DisallowIncoming amendment (#6045) 
Amendments activated for more than 2 years can be retired. This change retires the DisallowIncoming amendment.
 2025-11-21 15:18:00 +00:00
Jingchen
57f4b4eb7f refactor: Retire Checks amendment (#6055) 
Amendments activated for more than 2 years can be retired. This change retires the Checks amendment.
 2025-11-21 14:19:43 +00:00
Mayukha Vadari
a3d4be4eaf fix: Set correct index for limit in book_offers CLI (#6043) 
This change fixes an indexing typo in the `book_offers` CLI processing, and does not affect the HTTPS/WS RPC processing.
 2025-11-20 06:37:28 -05:00
Ed Hennis
8a1f244682 Updated overpayment processing 
- Added a test for RIPD-4125
 2025-11-20 00:17:33 -05:00
Olek
6ff495fd9b Fix: Perform array size check (#6030) 
The `ledger_entry` and `deposit_preauth` requests require an array of credentials. However, the array size is not checked before is gets processing. This fix adds checks and return errors in case array size is too big.
 2025-11-19 16:58:18 +00:00
Ed Hennis
bd0b651891 Merge branch 'develop' into ximinez/lending-XLS-66 2025-11-18 22:39:17 -05:00
sunnyraindy
ad37461ab2 chore: Fix some typos in comments (#6040) 2025-11-18 20:21:35 -05:00
Ed Hennis
fd115cfc13 Address my review feedback on (#6017) 
- Shortcut on issuer match in canTransfer.
- An asset can transfer if either trustline enabled rippling, so both
  must have it disabled for the transfer to fail with terNO_RIPPLE.
- Remove unnecessary asfDefaultRipple sets in unit tests.
- Add a new unit test helper class: testline, and a macro: THISLINE.
  When included as a parameter to Env::operator(), will include the line
  number of the transaction that didn't get the expected result. Works
  similarly to BEAST_EXPECT. I didn't do the same for the file name,
  because that can be deduced from the testcase name.
 2025-11-18 18:31:10 -05:00
Bronek Kozicki
d8b944c218 Enforce assets are transferable (#6017) 
- Includes unit tests for terNO_RIPPLE.
- Switch auth mode to weak when submitter is destination.
- Require rippling enabled for vault deposits or withdrawals.
 2025-11-18 18:28:59 -05:00
Jingchen
2c187461cc refactor: Retire NegativeUNL amendment (#6033) 
Amendments activated for more than 2 years can be retired. This change retires the NegativeUNL amendment.
 2025-11-17 14:02:10 +00:00
Vito Tumas
31d6ad727e Refactors method and struct names (#6039) 
- remove unused method
- rename computeFee to computeManagementFee
- rename calculateRounded to constructRounded
- remove redundancies in LoanDeltas struct
- rename PaymentComponentsPlus to ExtendedPaymentComponents
- additional logging
 2025-11-15 08:48:38 +00:00
Ed Hennis
cfdcaf3f8d Merge branch 'develop' into ximinez/lending-XLS-66 2025-11-15 03:08:29 -05:00
Ed Hennis
b9fdf9e564 Add the testPoC_UnsignedUnderflowOnFullPayAfterEarlyPeriodic 
- Updated to reflect that the issue in RIPD-3971 has been resolved by
  commit 4396b77c4b
 2025-11-14 12:52:27 -05:00
Bronek Kozicki
362ecbd1cb fix: Apply object reserve for Vault pseudo-account (#5954) 2025-11-14 17:30:56 +00:00
Jingchen
7025e92080 refactor: Retire TicketBatch amendment (#6032) 
Amendments activated for more than 2 years can be retired. This change retires the TicketBatch amendment.
 2025-11-14 13:33:34 +00:00
Ed Hennis
c65a311ad1 Remove a bunch of obsolete code, marked by "#if LOANCOMPLETE" 2025-11-13 14:26:47 -05:00
Ed Hennis
a868b1938d Fix Vault test failure due to default field not being in RPC Json 2025-11-13 14:21:41 -05:00
Ed Hennis
2f94838bbf Merge branch 'develop' into ximinez/lending-XLS-66 2025-11-13 12:18:42 -05:00
Vlad
f81d0d8c98 chore: Clean up incorrect comments (#6031) 
This change cleans up incorrect comments that were left in test cases after one of the amendments was retired.
 2025-11-13 13:37:38 +00:00
Jingchen
508937f3d1 refactor: Retire MultiSignReserve and ExpandedSignerList amendments (#5981) 
Amendments activated for more than 2 years can be retired. This change retires the MultiSignReserve and ExpandedSignerList amendments.
 2025-11-13 11:42:45 +00:00
Ed Hennis
ad124ce7b2 Fix balance checking assertion in LoanPay when issuer is borrower 
- Resolves RIPD-4096
 2025-11-13 01:51:07 -05:00
Ed Hennis
a4aa72eada Fix revert issues 2025-11-12 19:19:06 -05:00
Ed Hennis
398170ef3d Revert "Add optional enforcement of valid integer range to Number" 
This reverts commit 3cb447a4fe.
 2025-11-12 19:15:14 -05:00
Ed Hennis
9b0b7b5a91 Revert "Make all STNumber fields "soeDEFAULT"" 
This reverts commit 24f37d73f6.
 2025-11-12 19:15:07 -05:00
Ed Hennis
814577758f Revert "Fix build error - avoid copy" 
This reverts commit cb6df196dc.
 2025-11-12 19:15:03 -05:00
Ed Hennis
694abd1c79 Revert "Catch up the consequences of Number changes" 
This reverts commit 0175dd70db.
 2025-11-12 19:15:00 -05:00
Ed Hennis
2e34506835 Revert "Add a distinction between a "valid" and a "representable" Number" 
This reverts commit 8e56af20ee.
 2025-11-12 19:14:54 -05:00
Ed Hennis
8f772b9073 Merge remote-tracking branch 'XRPLF/develop' into ximinez/lending-XLS-66 
* XRPLF/develop:
  chore: Set version 3.1.0-b0 (5986)
  ci: Clean workspace on Windows self-hosted runners (6024)
  docs: fix spelling in comments (6002)
  fix: floating point representation errors in vault (5997)
  ci: Specify bash as the default shell in workflows (6021)
  refactor: Add `XRPL_RETIRE_FIX` and `XRPL_RETIRE_FEATURE` macros (6014)
  refactor: Retire DepositPreAuth and DepositAuth amendments (5978)
  chore: Move running of unit tests out of coverage target (6018)
  refactor: Retire PayChanRecipientOwnerDir amendment (5946)
 2025-11-12 14:12:01 -05:00