Ed Hennis
8743be8eae
Rollback Number class changes; show the fix works without side effects
2026-06-06 14:34:31 -04:00
Ed Hennis
2f701121b4
Merge remote-tracking branch 'upstream/develop' into ximinez/number-round-maxrep-down
...
* upstream/develop:
build: Create single test binary xrpl_tests (7327)
ci: [DEPENDABOT] bump actions/checkout from 6.0.2 to 6.0.3 (7414)
ci: Refactor build-related nix / docker / workflows (7408)
ci: Use multiple directories in dependabot config (7413)
ci: Update clang-tidy to nix-based v22 (7412)
2026-06-06 14:04:24 -04:00
Ed Hennis
961ac6671e
Improve comment descriptions
2026-06-06 13:09:52 -04:00
Ed Hennis
012c67a7eb
Rework subtraction rounding (again) for more accuracy
...
- Go back to the old method of computing the mantissa, but when post
processing, expand the mantissa to slightly larger than maxMantissa,
then in doRoundDown, if the result is not exact, subtract one.
Finally, let doNormalize figure out the rounding of the result.
2026-06-06 01:04:26 -04:00
Ed Hennis
74c66d0944
refactor: Construct Number::Guard from MantissaRange or relevant fields
...
- Simplifies the function signatures in Guard, because it doesn't need
to have those values passed in constantly.
- Also simplifies some of the functions because they don't need to store
values just to pass them to Guard functions.
2026-06-05 12:06:41 -04:00
Ayaz Salikhov
2111bb4b95
ci: Update clang-tidy to nix-based v22 ( #7412 )
2026-06-05 14:11:47 +00:00
Ed Hennis
aa8888732e
Merge branch 'develop' into ximinez/number-round-maxrep-down
2026-06-04 19:03:32 -04:00
Ayaz Salikhov
5b8e6cd1dd
test: Fix LCOV_EXCL_END -> LCOV_EXCL_STOP ( #7407 )
2026-06-04 19:35:36 +00:00
yinyiqian1
e5cf1a0985
fix: Add zero NFT Offer ID check for NFTokenCancelOffer ( #7391 )
2026-06-03 19:30:20 +00:00
Bart
96b2c0964f
refactor: Replace intr_ptr::SharedPtr<SHAMapTreeNode> by SHAMapTreeNodePtr ( #7396 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-06-03 15:34:19 +00:00
Ed Hennis
9e8c3caef4
Improve accuracy of Number::operator+=
...
- Use more of the available range of the uint128 operands.
- Also refactor Number::Guard::round() to return an enum.
2026-06-02 15:35:42 -04:00
Ed Hennis
35bee87909
Experimental: Scale addition operands up to preserve accuracy
2026-06-01 21:52:31 -04:00
Vito Tumas
109b649106
refactor: Use STLedgerEntry type aliases instead of std::shared_ptr ( #7282 )
2026-06-01 15:27:13 +00:00
Bart
7e15621e7b
release: Bump version to 3.2.0-rc3 ( #7371 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-05-31 22:55:18 +00:00
Vito Tumas
99431d7833
fix: Pin overpayment principal reduction to exact on-grid value ( #7360 )
2026-05-31 22:54:23 +00:00
Ed Hennis
47365f4220
fix: Improve upward rounding edge cases for Number::operator/= ( #7328 )
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com >
2026-05-31 00:23:29 +00:00
Bart
1599c1a672
refactor: Revert "perf: Remove unnecessary caches ( #5439 )" ( #7359 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-05-30 18:48:59 +00:00
yinyiqian1
763dd503be
fix: Add zero domainID check for permissionedDomain ( #7362 )
2026-05-30 00:16:25 +00:00
Bart
1acc42313c
release: Bump version to 3.2.0-rc2 ( #7348 )
2026-05-27 15:11:38 -04:00
Ayaz Salikhov
1438bf1c67
release: Bump version to 3.2.0-rc1 ( #7335 )
2026-05-27 13:20:57 -04:00
Ed Hennis
7da643d864
fix: Fix a rounding error at the Number::maxRep cusp ( #7051 )
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com >
2026-05-27 15:19:20 +00:00
Vito Tumas
49567e7283
fix: Fix edge-case where vault-depositor may get stuck ( #7139 )
2026-05-26 18:18:40 +00:00
Vito Tumas
633ef4706f
fix: Fix VaultInvariant and VaultDeposit precision bugs at IOU scale boundaries ( #7272 )
...
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-05-26 16:32:44 +00:00
Vito Tumas
22a21b175e
fix: Include management-fee delta in doOverpayment assertion ( #7039 )
2026-05-26 14:01:52 +00:00
Jingchen
a911f9089e
fix: Use consistent scale for debtTotal ( #7093 )
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-05-24 20:44:29 +00:00
Peter Chen
e34c2667d7
fix: Skip deleted book directories and non-root modifications in ValidBookDirectory invariant ( #7312 )
2026-05-24 20:37:16 +00:00
Gregory Tsipenyuk
dcd2ff0b5f
fix: Fix non-canonical MPT amount ( #7117 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-05-23 06:40:26 +00:00
Bart
dfb9b8ed9a
release: Bump version to 3.2.0-b7 ( #7316 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-05-22 19:32:12 +00:00
Jingchen
179e73594a
fix: Check if the MPT first loss cover can be sent to the broker before deleting the broker ( #7125 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-05-22 11:58:48 +00:00
Gregory Tsipenyuk
3547a9335f
fix: Add assorted MPT/DEX fixes ( #7040 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
Co-authored-by: Shawn Xie <35279399+shawnxie999@users.noreply.github.com >
2026-05-21 18:29:53 +00:00
Bart
1a98182e23
refactor: Remove dead fetchBatch code ( #7309 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-05-21 17:52:41 +00:00
Bart
79308705c5
release: Bump version to 3.2.0-b6 ( #7311 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-05-21 17:50:59 +00:00
Vito Tumas
7fdaa0a5ef
fix: Fix IOU precision issues in LoanBrokerCover transactions ( #7274 )
2026-05-21 14:51:58 +00:00
Vito Tumas
795dc5e364
fix: Avoid principal-zeroing in non-final loan payments at coarse scale ( #7050 )
...
Co-authored-by: Ed Hennis <ed@ripple.com >
2026-05-21 14:46:26 +00:00
Shawn Xie
28cc20c816
fix: Fix wrong hybrid offer orderbook placement and update LedgerStateFix to amend ExchangeRate meta ( #7087 )
...
Co-authored-by: Peter Chen <ychen@ripple.com >
2026-05-21 06:19:04 +00:00
Alex Kremer
a830ab10ef
style: More clang-tidy identifier renaming ( #7290 )
2026-05-20 21:31:15 +00:00
Shawn Xie
8c0080020f
fix: Update pDEX invariant firing under a valid offer deletion ( #7118 )
...
Co-authored-by: Peter Chen <ychen@ripple.com >
2026-05-20 21:10:04 +00:00
yinyiqian1
9cb0740673
fix: Fix multisign and signfor to check for delegate ( #7064 )
2026-05-20 20:24:09 +00:00
Mayukha Vadari
242ce3e9e4
refactor: Fix sfGeneric and sfInvalid field names ( #7300 )
2026-05-20 19:47:59 +00:00
box4wangjing
a5d238e7d4
docs: Fix some comments to improve readability ( #7122 )
...
Signed-off-by: box4wangjing <box4wangjing@outlook.com >
Co-authored-by: Mayukha Vadari <mvadari@ripple.com >
2026-05-20 19:46:45 +00:00
Vito Tumas
9cb049276d
feat: Propagate underlying MPT flags to vault shares ( #7077 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: Denis Angell <dangell@transia.co >
Co-authored-by: Fomo <508629+shortthefomo@users.noreply.github.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-05-20 19:44:09 +00:00
Vito Tumas
93ac1aa7aa
fix: Disable unnecessary sanity-check in VaultDeposit ( #7288 )
2026-05-19 16:38:50 +00:00
Denis Angell
ad3d172a1f
fix: Use account ledger entry when canceling token escrows ( #6171 )
2026-05-18 20:08:48 +00:00
Mayukha Vadari
ad7232cbc5
refactor: Rename account_ to accountID_ ( #7284 )
2026-05-18 10:56:54 +00:00
Mayukha Vadari
c7ecfc6a97
refactor: Clean up comments post-clang-tidy changes ( #7283 )
2026-05-15 23:02:04 +00:00
Ed Hennis
6809690fad
release: Set version to 3.3.0-b0 ( #7280 )
...
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-05-15 18:04:49 +00:00
Alex Kremer
5b6e8b6f93
refactor: Rename static constants ( #7120 )
...
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-05-15 15:32:19 +00:00
Mayukha Vadari
028f0cb5da
refactor: Use isFlag where possible instead of bitwise math ( #7278 )
2026-05-15 14:00:13 +00:00
Jingchen
cce4cfef10
feat: Add verify_endpoints to help local peer network development ( #7268 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-05-14 17:07:08 +00:00
Bart
afbccf971a
chore: Consolidate fix amendments ( #7134 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-05-13 20:46:30 +00:00