* XRPLF/ximinez/number-fix-maxrepcusp: (32 commits)
ci: Only push docker images in XRPLF/rippled (7330)
clang-tidy: missing header
ci: [DEPENDABOT] bump docker/setup-buildx-action from 4.0.0 to 4.1.0 (7322)
ci: [DEPENDABOT] bump codecov/codecov-action from 6.0.0 to 6.0.1 (7321)
ci: [DEPENDABOT] bump docker/build-push-action from 7.1.0 to 7.2.0 (7320)
ci: [DEPENDABOT] bump docker/metadata-action from 6.0.0 to 6.1.0 (7319)
ci: [DEPENDABOT] bump docker/login-action from 4.1.0 to 4.2.0 (7318)
fix: Update `clang-tidy` to include `src/tests` directory header check (7307)
clang-tidy: implicit bool conversion
chore: Pin Python packages for codegen using uv (7329)
style: Use shfmt instead of bashate (7326)
fix: Fix edge-case where vault-depositor may get stuck (7139)
Address some AI review feedback: predeclare, include, format, comment
fix: Fix `VaultInvariant` and `VaultDeposit` precision bugs at IOU scale boundaries (7272)
ci: Add clang to nix images (7308)
fix: Include management-fee delta in doOverpayment assertion (7039)
fix: Fix clang-tidy pre-commit hook to locate compile_commands.json from repo root (7325)
fix: Use consistent scale for `debtTotal` (7093)
fix: Skip deleted book directories and non-root modifications in `ValidBookDirectory` invariant (7312)
fix: Address review feedback on FD/handle guarding (5823 follow-up) (7310)
...
- Predeclare type reference in Rules.h
- Remove an unneeded include in EscrowToken_test
- Number_test will format negative BigInts correctly (unused)
- Remove an inaccurate comment
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* XRPLF/ximinez/number-fix-maxrepcusp:
Fix more AMM tests, and to not exclude fixCleanup3_2_0
docs: Add --parallel flag to cmake build commands in BUILD.md (7302)
fix: Fix wrong hybrid offer orderbook placement and update `LedgerStateFix` to amend `ExchangeRate` meta (7087)
Change the priority of the amendments for large mantissas
Apply suggestions from @Tapanito code review
Apply suggestions from Copilot code review
Review feedback from @tapanito: lambda checks condition in doRoundUp
style: More clang-tidy identifier renaming (7290)
fix: Update pDEX invariant firing under a valid offer deletion (7118)
fix: Fix multisign and signfor to check for delegate (7064)
refactor: Fix `sfGeneric` and `sfInvalid` field names (7300)
docs: Fix some comments to improve readability (7122)
feat: Propagate underlying MPT flags to vault shares (7077)
- Order the checks so that large mantissa is only enabled if SAV or LP
are enabled. fixCleanup3_2_0 only enables the rounding fix.
- Fix tests, and don't exclude fixCleanup3_2_0 in AMM tests
- Also fix formatting
* XRPLF/ximinez/number-fix-maxrepcusp:
fix: Disable unnecessary sanity-check in VaultDeposit (7288)
ci: [DEPENDABOT] bump actions/upload-artifact from 7.0.0 to 7.0.1 (7286)
ci: Only run reusable package in public repos (7293)
fix: Set default peering port to 2459 (6848)
fix: Use account ledger entry when canceling token escrows (6171)
refactor: Rename `account_` to `accountID_` (7284)
ci: Add Linux package builds (DEB + RPM) to CI (6639)
refactor: Clean up comments post-clang-tidy changes (7283)
release: Set version to 3.3.0-b0 (7280)
refactor: Rename static constants (7120)
refactor: Use `isFlag` where possible instead of bitwise math (7278)
ci: Update XRPLF/actions (7281)
clang-tidy: this is ridiculous
clang-tidy: {}
* XRPLF/develop:
release: Set version to 3.3.0-b0 (7280)
refactor: Rename static constants (7120)
refactor: Use `isFlag` where possible instead of bitwise math (7278)
ci: Update XRPLF/actions (7281)
- Some EscrowToken tests used a hard-coded list of amendments to
determine whether to expect large mantissa logic. That ignored the
effects of fixCleanup3_2_0, especially as applied to the previous fix
affecting preflight, preclaim, etc.
- Add a helper function, useRulesGuards, which will return the same
decision as createGuards and setCurrentRulesImpl. Use that helper
function in the relevant tests.
- Also remove an #include that clang-tidy was complaining about.
- Refactor the Guard decision in withTxnType into createGuards, which
lives in Rules.cpp. It is physically located near
setCurrentTransactionRules, and documented to explain that changes
need to be synchronized.
