Pratik Mankawde
c848e51e13
Merge branch 'pratik/otel-phase1c-rpc-integration' into pratik/otel-phase2-rpc-tracing
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-05-29 16:44:07 +01:00
Pratik Mankawde
3a1f22583f
Merge branch 'pratik/otel-phase1a-plan-docs' into pratik/otel-phase1b-telemetry-infra
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-05-29 15:34:22 +01:00
Pratik Mankawde
e1163f7180
Merge branch 'develop' into pratik/otel-phase1a-plan-docs
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-05-29 15:30:02 +01:00
Ayaz Salikhov
f9551ac5ca
style: Run shfmt on workflows, actions and markdown bash code ( #7333 )
2026-05-27 19:24:18 +00:00
Ayaz Salikhov
23d0812827
style: Use shfmt instead of bashate ( #7326 )
2026-05-26 18:28:23 +00:00
Ayaz Salikhov
49cb3f45a4
ci: Add clang to nix images ( #7308 )
...
Co-authored-by: semgrep-companion-app[bot] <218312740+semgrep-companion-app[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-05-26 15:45:33 +00:00
Michael Legleux
93836f22db
ci: Add Linux package builds (DEB + RPM) to CI ( #6639 )
2026-05-16 05:08:37 +00:00
Jingchen
cce4cfef10
feat: Add verify_endpoints to help local peer network development ( #7268 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-05-14 17:07:08 +00:00
Ayaz Salikhov
648ec747f2
feat: Implement nix-based Dockerfile for CI ( #7083 )
2026-05-13 15:10:53 +00:00
Ayaz Salikhov
27f7fdb3a6
chore: Do not duplicate sanitizer flags ( #7058 )
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-05-05 16:32:43 +00:00
Ayaz Salikhov
e092c52409
ci: Use XRPLF/create-issue ( #7076 )
2026-05-05 13:49:13 +00:00
Ayaz Salikhov
d050073842
ci: Rewrite clang-tidy workflow(s) in a reusable manner ( #7062 )
2026-05-04 12:51:07 +00:00
Pratik Mankawde
3ed22580fe
fix(telemetry): address remaining clang-tidy and cspell CI failures
...
- Add "hicpp" to cspell dictionary for NOLINT annotations
- Concatenate nested namespaces in RpcSpanNames.h
- Fix include hygiene and nested ternary in RPCHandler.cpp
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-04-29 17:31:58 +01:00
Pratik Mankawde
a9ee819ea1
docs(telemetry): add Phase 2-5 task lists and appendix update
...
Introduces task list documents for Phases 2 through 5, with Tempo
references (replacing Jaeger) and Task 2.8 dashboard parity spec.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
2026-04-28 14:28:07 +01:00
Pratik Mankawde
e9c5c3520e
fix(telemetry): address Phase 1b code review findings
...
Redesign SpanGuard with pimpl idiom to hide all OpenTelemetry types
from public headers. Add global Telemetry accessor so SpanGuard factory
methods work without explicit Telemetry references. Add child/linked
span creation and cross-thread context propagation. Update plan docs
to reflect macro removal in favor of SpanGuard factory pattern.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-04-28 14:26:05 +01:00
Pratik Mankawde
913a4b794c
docs: correct OTel overhead estimates against SDK benchmarks
...
Verified CPU, memory, and network overhead calculations against
official OTel C++ SDK benchmarks (969 CI runs) and source code
analysis. Key corrections:
- Span creation: 200-500ns → 500-1000ns (SDK BM_SpanCreation median
~1000ns; original estimate matched API no-op, not SDK path)
- Per-TX overhead: 2.4μs → 4.0μs (2.0% vs 1.2%; still within 1-3%)
- Active span memory: ~200 bytes → ~500-800 bytes (Span wrapper +
SpanData + std::map attribute storage)
- Static memory: ~456KB → ~8.3MB (BatchSpanProcessor worker thread
stack ~8MB was omitted)
- Total memory ceiling: ~2.3MB → ~10MB
- Memory success metric target: <5MB → <10MB
- AddEvent: 50-80ns → 100-200ns
Added Section 3.5.4 with links to all benchmark sources.
Updated presentation.md with matching corrections.
High-level conclusions unchanged (1-3% CPU, negligible consensus).
Also includes: review fixes, cross-document consistency improvements,
additional component tracing docs (PathFinding, TxQ, Validator, etc.),
context size corrections (32 → 25 bytes).
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-04-16 15:00:47 +01:00
Pratik Mankawde
ddf894dcb0
Phase 1a: OpenTelemetry plan documentation
...
Add comprehensive planning documentation for the OpenTelemetry
distributed tracing integration:
- Tracing fundamentals and concepts
- Architecture analysis of rippled's tracing surface area
- Design decisions and trade-offs
- Implementation strategy and code samples
- Configuration reference
- Implementation phases roadmap
- Observability backend comparison
- POC task list and presentation materials
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-04-16 15:00:47 +01:00
Gregory Tsipenyuk
dfcad69155
feat: Add MPT support to DEX ( #5285 )
2026-04-08 16:17:37 +00:00
Ayaz Salikhov
dfed0481f7
docs: Rewrite conan docs for custom recipes ( #6647 )
2026-03-25 14:25:33 +00:00
Jingchen
b1e5ba0518
feat: Add code generator for transactions and ledger entries ( #6443 )
...
Signed-off-by: JCW <a1q123456@users.noreply.github.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-03-18 21:11:51 +00:00
Pratik Mankawde
5ae97fa8ae
refactor: Add no-ASAN macro for Throw statements ( #6373 )
...
Throwing exceptions from code sometime confuses ASAN, as it cannot keep track of stack frames. This change therefore adds a macro to skip instrumentation around the `Throw` function.
2026-03-17 13:10:32 +00:00
Pratik Mankawde
983816248a
fix: Switch to boost::coroutine2 ( #6372 )
...
ASAN wasn't able to keep track of `boost::coroutine` context switches, and would lead to many false positives being detected. By switching to `boost::coroutine2` and `ucontext`, ASAN is able to know about the context switches advertised by the `boost::fiber` class, which in turn leads to more cleaner ASAN analysis.
2026-03-16 15:34:15 +00:00
Alex Kremer
afc660a1b5
refactor: Fix clang-tidy bugprone-empty-catch check ( #6419 )
...
This change fixes or suppresses instances detected by the `bugprone-empty-catch` clang-tidy check.
2026-03-02 17:08:56 +00:00
Sergey Kuznetsov
0fd237d707
chore: Add nix development environment ( #6314 )
...
---------
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2026-02-23 20:10:07 -05:00
Sergey Kuznetsov
31302877ab
ci: Add clang tidy workflow to ci ( #6369 )
2026-02-19 14:06:44 -05:00
Mayukha Vadari
bf4674f42b
refactor: Fix spelling issues in tests ( #6199 )
...
This change removes the `src/tests` exception from the `cspell` config and fixes all the issues that arise as a result. No functionality/test change.
2026-02-06 20:30:22 +00:00