Pratik Mankawde
9b3a16ae11
Merge branch 'pratik/otel-phase4-consensus-tracing' into pratik/otel-phase5-docs-deployment
2026-08-05 15:47:59 +01:00
Pratik Mankawde
312b87d840
Merge branch 'pratik/otel-phase3-tx-tracing' into pratik/otel-phase4-consensus-tracing
2026-08-05 15:47:58 +01:00
Pratik Mankawde
5fb1457518
Merge branch 'pratik/otel-phase2-rpc-tracing' into pratik/otel-phase3-tx-tracing
2026-08-05 15:47:43 +01:00
Pratik Mankawde
7505ac623e
Merge branch 'pratik/otel-phase1c-rpc-integration' into pratik/otel-phase2-rpc-tracing
2026-08-05 15:43:03 +01:00
Pratik Mankawde
c432c1f4c5
Merge branch 'pratik/otel-phase1b-telemetry-infra' into pratik/otel-phase1c-rpc-integration
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-08-05 15:29:12 +01:00
Pratik Mankawde
5e1f96da4f
Merge branch 'pratik/otel-phase1a-plan-docs' into pratik/otel-phase1b-telemetry-infra
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-08-05 14:29:58 +01:00
Vito Tumas
c3ee602002
test: Split Loan_test.cpp into topical suites ( #7864 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-08-04 15:43:59 +00:00
Alex Kremer
06488c1318
chore: Rename CamelCase namespaces to snake_case ( #7933 )
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-08-04 13:46:55 +00:00
Luc des Trois Maisons
b8451ffa32
fix: Add missing value_type to JSON iterators ( #7907 )
2026-08-03 21:17:23 +00:00
Bart
21cd615407
perf: Replace node ID by depth in TMLedgerNode ( #6353 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-07-30 15:02:05 +00:00
Vito Tumas
8a5eded4f1
feat: Implement LoanBroker cash-basis accounting ( #7817 )
2026-07-30 11:55:39 +00:00
Alex Kremer
6ddad54985
chore: Move lexical cast tests to gtest ( #7873 )
2026-07-29 22:54:46 +00:00
Pratik Mankawde
fb19db68a2
Merge branch 'pratik/otel-phase4-consensus-tracing' into pratik/otel-phase5-docs-deployment
2026-07-29 14:20:04 +01:00
Pratik Mankawde
ded4c599a6
Merge branch 'pratik/otel-phase3-tx-tracing' into pratik/otel-phase4-consensus-tracing
2026-07-29 14:19:44 +01:00
Pratik Mankawde
c6b56a5e97
Merge branch 'pratik/otel-phase2-rpc-tracing' into pratik/otel-phase3-tx-tracing
2026-07-29 14:19:08 +01:00
Pratik Mankawde
6e6f468ac4
Merge branch 'pratik/otel-phase1c-rpc-integration' into pratik/otel-phase2-rpc-tracing
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-07-29 14:10:45 +01:00
Pratik Mankawde
6b6a23df4e
Merge branch 'pratik/otel-phase1b-telemetry-infra' into pratik/otel-phase1c-rpc-integration
2026-07-29 14:09:48 +01:00
Pratik Mankawde
72d4e5a45c
Merge branch 'pratik/otel-phase1a-plan-docs' into pratik/otel-phase1b-telemetry-infra
2026-07-29 14:09:32 +01:00
Alex Kremer
86832edc70
chore: Move semantic version tests to gtest ( #7872 )
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-07-27 18:48:53 +00:00
Pratik Mankawde
1aa8521357
Merge branch 'pratik/otel-phase4-consensus-tracing' into pratik/otel-phase5-docs-deployment
2026-07-27 19:03:29 +01:00
Pratik Mankawde
9edb1ce60b
fix(build): link telemetry into the consensus module
...
The consensus headers moved into the isolated xrpl/consensus module and
took a dependency on xrpl/telemetry for the tracing span constants, but
two things were left behind:
- Four includes still pointed at the old src/xrpld/consensus/ location,
which no longer exists, so the build failed with
"fatal error: 'xrpld/consensus/ConsensusParms.h' file not found".
- xrpl.libxrpl.consensus never linked xrpl.libxrpl.telemetry. add_module
isolates each module's headers, so xrpl/telemetry/SpanNames.h was not
on the include path even once the include was repointed.
Repoint the stale includes at xrpl/consensus/, and declare the telemetry
module before consensus so consensus can link it. Regenerate ordering.txt
for the resulting edge.
2026-07-27 19:03:13 +01:00
Alex Kremer
6c9c7f0555
chore: Trivial gtest migrations ( #7865 )
2026-07-27 16:34:53 +00:00
Pratik Mankawde
6a57e76222
Merge branch 'pratik/otel-phase4-consensus-tracing' into pratik/otel-phase5-docs-deployment
2026-07-27 17:04:21 +01:00
Pratik Mankawde
0aebf47df4
Merge branch 'pratik/otel-phase3-tx-tracing' into pratik/otel-phase4-consensus-tracing
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-07-27 17:03:59 +01:00
Pratik Mankawde
23d5271eb6
Merge branch 'pratik/otel-phase2-rpc-tracing' into pratik/otel-phase3-tx-tracing
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-07-27 16:58:48 +01:00
Pratik Mankawde
58fa19735e
Merge branch 'pratik/otel-phase1c-rpc-integration' into pratik/otel-phase2-rpc-tracing
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-07-27 16:56:51 +01:00
Pratik Mankawde
7e5f726388
Merge branch 'pratik/otel-phase1b-telemetry-infra' into pratik/otel-phase1c-rpc-integration
2026-07-27 16:56:15 +01:00
Pratik Mankawde
42a6fe8885
Merge branch 'pratik/otel-phase1a-plan-docs' into pratik/otel-phase1b-telemetry-infra
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-07-27 16:55:39 +01:00
Andrzej Budzanowski
29120dfcbd
test: Migrate nodestore tests from Beast to GTest ( #7292 )
...
Co-authored-by: Marek Foss <marek.foss@neti-soft.com >
Co-authored-by: Alex Kremer <akremer@ripple.com >
2026-07-27 13:00:14 +00:00
Pratik Mankawde
7338ed8feb
Merge branch 'pratik/otel-phase4-consensus-tracing' into pratik/otel-phase5-docs-deployment
2026-07-24 16:07:14 +01:00
Pratik Mankawde
ffa782ca96
Merge branch 'pratik/otel-phase3-tx-tracing' into pratik/otel-phase4-consensus-tracing
...
# Conflicts:
# include/xrpl/telemetry/SpanNames.h
2026-07-24 16:07:03 +01:00
Pratik Mankawde
fb76c43307
feat(telemetry): correlate tx spans to the ledger being worked on
...
Add shared current_ledger_seq / current_ledger_hash span attributes so a
transaction's work can be joined to the ledger trace that produced it, and
fix discrepancy D1 (txq.enqueue was a detached trace root).
- Define current_ledger_seq / current_ledger_hash once in SpanNames.h and
re-export via `using` from TxQ/TxApply/Tx span-name headers. These name the
ledger being worked on (open/tentative apply or in-flight consensus build),
distinct from ledger_seq (the built/validated ledger on ledger.build /
consensus.round). Named after the RPC field ledger_current_index.
- txq.enqueue: set current_ledger_seq/hash from the view, and parent the span
to the caller's tx.process span via an explicit captured SpanContext (new
trailing TxQ::apply param) instead of a detached root. The parent is
explicit, not ambient-inherited, and the ScopedSpanGuard scope is RAII-bound
to the synchronous apply, so it cannot leak onto a reused worker (D1 fix).
On the open-ledger rebuild path no tx.process context exists, so it stays a
root and the attribute provides the correlation.
- tx.preclaim / tx.transactor: set both attributes from their ledger view.
tx.preflight is stateless (no view) and is the documented exception.
- tx.process / tx.receive: set current_ledger_seq from the current open ledger
index at submit/receive time (no hash: not yet applied to a ledger).
- Contract test pins the two new attribute key strings.
Neither key is a spanmetrics dimension, so there is no metric-cardinality
impact. Dashboards/collector/docs land on the later phases per the chain split.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-07-24 16:03:42 +01:00
Pratik Mankawde
09a1491973
Merge branch 'pratik/otel-phase4-consensus-tracing' into pratik/otel-phase5-docs-deployment
2026-07-24 12:28:24 +01:00
Pratik Mankawde
0a76df5f3c
Merge branch 'pratik/otel-phase3-tx-tracing' into pratik/otel-phase4-consensus-tracing
...
# Conflicts:
# include/xrpl/telemetry/SpanGuard.h
# src/libxrpl/telemetry/SpanGuard.cpp
2026-07-24 12:28:08 +01:00
Pratik Mankawde
6165a26fed
Merge branch 'pratik/otel-phase1c-rpc-integration' into pratik/otel-phase2-rpc-tracing
2026-07-24 12:25:36 +01:00
Pratik Mankawde
07b8e90bd5
Merge branch 'pratik/otel-phase2-rpc-tracing' into pratik/otel-phase3-tx-tracing
2026-07-24 12:25:36 +01:00
Pratik Mankawde
0feb356d42
Merge branch 'pratik/otel-phase1b-telemetry-infra' into pratik/otel-phase1c-rpc-integration
2026-07-24 12:25:35 +01:00
Pratik Mankawde
017c82eeee
make span functions noexcept
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-07-24 12:20:35 +01:00
Kassaking7
9afa1cf4d1
fix: Update PermissionedDEX invariant domain tracking for valid offer replacement ( #7387 )
...
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-07-23 21:40:21 +00:00
Marek Foss
4c0180b3db
test: Migrate csf and xrpld-consensus Beast non-JTx tests to GTest ( #7046 )
...
Co-authored-by: Alex Kremer <akremer@ripple.com >
2026-07-23 21:38:21 +00:00
Marek Foss
4acccfeda8
test: Modularize Peerfinder component and migrate Peerfinder tests from Beast to GTest and GMock ( #7054 )
...
Co-authored-by: Alex Kremer <akremer@ripple.com >
2026-07-23 21:00:06 +00:00
Mayukha Vadari
38c54c3f36
feat: Add fixCleanup3_4_0 amendment (no functionality yet) ( #7854 )
2026-07-23 18:50:59 +00:00
Pratik Mankawde
f2c0534544
Merge branch 'pratik/otel-phase4-consensus-tracing' into pratik/otel-phase5-docs-deployment
...
Carries activation-site dedup (activateIfLive) + no-alloc GetCurrent forward.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-07-23 14:07:57 +01:00
Pratik Mankawde
34dfc4edf0
Merge branch 'pratik/otel-phase3-tx-tracing' into pratik/otel-phase4-consensus-tracing
...
Brings review fixes: no-alloc GetCurrent hot path, activateIfLive helper,
non-copyable storage, accurate drop-counter doc.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-07-23 13:59:05 +01:00
Pratik Mankawde
8fddbe84a3
Merge branch 'pratik/otel-phase2-rpc-tracing' into pratik/otel-phase3-tx-tracing
...
Brings review fixes: no-alloc GetCurrent hot path, activateIfLive helper,
non-copyable storage, accurate drop-counter doc.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-07-23 13:59:02 +01:00
Pratik Mankawde
842f994dbb
Merge branch 'pratik/otel-phase1c-rpc-integration' into pratik/otel-phase2-rpc-tracing
...
Brings review fixes: no-alloc GetCurrent hot path, activateIfLive helper,
non-copyable storage, accurate drop-counter doc.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-07-23 13:59:01 +01:00
Pratik Mankawde
be78519581
Merge branch 'pratik/otel-phase1b-telemetry-infra' into pratik/otel-phase1c-rpc-integration
...
Brings review fixes: no-alloc GetCurrent hot path, activateIfLive helper,
non-copyable storage, accurate drop-counter doc.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-07-23 13:58:58 +01:00
Pratik Mankawde
c209829c44
refactor(telemetry): no-alloc GetCurrent hot path, activateIfLive helper, non-copyable storage, accurate drop-counter doc
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-07-23 13:50:16 +01:00
Pratik Mankawde
de97f27c3d
Merge branch 'pratik/otel-phase4-consensus-tracing' into pratik/otel-phase5-docs-deployment
...
Brings M1 (dropped-deterministic-id counter) + M2 (childSpan doc) forward.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-07-22 23:15:00 +01:00
Pratik Mankawde
c4315b1551
Merge branch 'pratik/otel-phase3-tx-tracing' into pratik/otel-phase4-consensus-tracing
...
Brings M1 (dropped-deterministic-id counter) + M2 (childSpan doc) forward.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-07-22 23:14:45 +01:00