ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-04-29 15:37:57 +00:00
Code Issues Packages Projects Releases Wiki Activity
13,955 Commits 236 Branches 183 Tags
6167c70043b2a49597df69f0ebc8cb985fa8c73f
Commit Graph

9893 Commits

Author SHA1 Message Date
Vito
6167c70043 Merge remote-tracking branch 'origin/tapanito/transaction-invariant' into tapanito/transactor-invariant-pt2 
# Conflicts:
#	include/xrpl/tx/invariants/VaultInvariant.h
#	src/libxrpl/tx/invariants/VaultInvariant.cpp
#	src/libxrpl/tx/transactors/vault/VaultCreate.cpp
 2026-04-22 17:16:13 +02:00
Vito
dd654f649e fix: Remove unreachable tefINVARIANT_FAILED check on tx invariants 
checkTransactionInvariants only returns tecINVARIANT_FAILED or the
input result, never tefINVARIANT_FAILED. Only protocol invariants can
escalate to tef, so the txResult comparison was dead code.
 2026-04-22 15:25:38 +02:00
Vito
0365449598 chore: Mark conditionally-used includes with IWYU pragma keep 
Serializer.h, STAmount.h, Number.h, and <iterator> are only used inside
XRPL_ASSERT or #ifdef DEBUG blocks that compile to nothing in release
builds. Without the pragma, include-cleaner flags them as unused in
release CI while flagging them as missing in debug builds.
 2026-04-22 13:43:39 +02:00
Vito
3f569f4cca chore: Add more direct includes flagged by include-cleaner 
Add direct includes for std::exception, std::distance, beast::Journal,
xrpl::ReadView, xrpl::Serializer, xrpl::SerialIter, xrpl::Number, and
xrpl::roundToAsset across files that use them. Also suppress
modernize-use-ranges on a std::is_sorted call where the ranges version
does not compile because SignerEntry is not std::totally_ordered.
 2026-04-22 12:43:12 +02:00
Vito Tumas
4b9e3997f8 Merge branch 'develop' into tapanito/transaction-invariant 2026-04-22 11:21:39 +02:00
Vito
273f8a13cd fix: Log transaction JSON on invariant failure 
The fatal log emitted when finalizeInvariants returns false previously
lacked identifying information, making postmortems difficult. Include
the full transaction JSON, matching the global invariant checker.
 2026-04-22 10:00:13 +02:00
Jingchen
45d4aacb53 chore: Remove empty Taker.h (#6984) 2026-04-21 18:15:58 +00:00
Vito
c84cab12ae Merge remote-tracking branch 'origin/develop' into tapanito/transaction-invariant 
# Conflicts:
#	src/test/app/Invariants_test.cpp
 2026-04-21 19:02:58 +02:00
Vito
96f60d6def chore: Add direct includes flagged by include-cleaner 
Add direct includes for std::shared_ptr, SLE, STTx, and XRPAmount in
transactor translation units that override visitInvariantEntry or
finalizeInvariants. Previously these types were pulled in transitively,
which misc-include-cleaner flags as errors under the project's
clang-tidy configuration.
 2026-04-21 18:58:20 +02:00
Vito
687d9489d7 test: Guard against null transactor in Invariants_test 
Addresses a review comment: the soft BEAST_EXPECT assertion would not
abort on failure, risking a null pointer dereference in the subsequent
checkInvariants call. Use an early-return guard instead.
 2026-04-21 18:58:20 +02:00
Alex Kremer
ce3951bbb3 chore: Enable clang-tidy modernize checks (#6975) 
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com>
Co-authored-by: Bart <bthomee@users.noreply.github.com>
 2026-04-21 15:32:51 +00:00
Vito
e28d5e5b50 formatting issues 2026-04-21 16:50:27 +02:00
Vito
da44fdb5d3 Merge remote-tracking branch 'origin/develop' into tapanito/transaction-invariant 2026-04-21 14:41:20 +02:00
Alex Kremer
ea023121f5 fix: Add rounding to Vault invariants (#6217) (#6955) 
Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com>
Co-authored-by: Ed Hennis <ed@ripple.com>
 2026-04-21 12:14:07 +00:00
Vito
9e9fdb40a8 Merge remote-tracking branch 'origin/develop' into tapanito/transaction-invariant 2026-04-21 13:47:31 +02:00
yinyiqian1
4b198cd5bb fix: Disallow MPTClearRequireAuth if is set (#6712) 
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>
 2026-04-20 21:25:52 +00:00
Alex Kremer
726f20c8f6 feat: Add GRPC TLS support (#6374) 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
 2026-04-20 17:12:14 +00:00
Zhiyuan Wang
96643bb0fa fix: Check for empty sfAdditionalBooks array in hybrid offer invariant (#6716) 2026-04-20 17:10:28 +00:00
chuanshanjida
e83818241a chore: Remove repetitive word in multiple files (#6978) 
Signed-off-by: chuanshanjida <chuanshanjida@outlook.com>
 2026-04-20 16:56:03 +00:00
Alex Kremer
653a383ff5 chore: Enable clang-tidy include cleaner (#6947) 2026-04-17 16:43:49 +00:00
Gregory Tsipenyuk
affe5835fe fix: Change AMMClawback return code to tecNO_PERMISSION (#6946) 2026-04-17 14:19:58 +00:00
Alex Kremer
f1a5ba43ad chore: Enable clang-tidy readability checks (#6930) 
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>
 2026-04-17 13:30:52 +00:00
Jingchen
4a73be499d fix: Fix unity build for book step (#6942) 
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
 2026-04-16 17:12:00 +00:00
Sergey Kuznetsov
d52d735543 chore: Move codegen venv setup into build stage (#6617) 
Co-authored-by: JCW <a1q123456@users.noreply.github.com>
Co-authored-by: Bart <bthomee@users.noreply.github.com>
 2026-04-15 18:50:49 +00:00
Alex Kremer
6a0ce46755 chore: Enable most clang-tidy bugprone checks (#6929) 
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>
 2026-04-14 20:24:21 +00:00
Bart
2f029a2120 refactor: Improve exception handling (#6540) (#6735) 
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com>
 2026-04-14 17:14:24 +00:00
Zhiyuan Wang
61fbde3a71 refactor: Remove unused notTooManyOffers function from NFTokenUtils (#6737) 2026-04-13 23:18:10 +00:00
Bart
e2e537b3bb fix: Change Tuning::bookOffers minimum limit to 1 (#6812) 
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com>
 2026-04-10 14:38:46 +00:00
Gregory Tsipenyuk
56c9d1d497 fix: Add description for terLOCKED error (#6811) 2026-04-08 20:56:19 +00:00
yinyiqian1
d52dd29d20 fix: Address AI reviewer comments for Permission Delegation (#6675) 2026-04-08 20:22:19 +00:00
Mayukha Vadari
7793b5f10b refactor: Combine AMMHelpers and AMMUtils (#6733) 2026-04-08 17:38:33 +00:00
Gregory Tsipenyuk
dfcad69155 feat: Add MPT support to DEX (#5285) 2026-04-08 16:17:37 +00:00
Pratik Mankawde
6d1a5be8d2 fix: Handle WSClient write failure when server closes WebSocket (#6671) 
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
 2026-04-07 19:15:40 +00:00
Bart
c00ed673a8 refactor: Rename non-functional uses of ripple(d) to xrpl(d) (#6676) 
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com>
 2026-04-07 13:00:17 +00:00
Mayukha Vadari
f239256d87 refactor: Move more helper files into libxrpl/ledger/helpers (#6731) 
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
 2026-04-06 22:36:32 +00:00
Mayukha Vadari
00761dbb67 fix: Minor RPC fixes (#6730) 2026-04-06 22:15:16 +00:00
Zhiyuan Wang
077e03ff33 fix: Prevent deletion of MPTokens with active escrow (#6635) 
Co-authored-by: Bart <bthomee@users.noreply.github.com>
 2026-04-06 17:51:46 +00:00
Vito Tumas
7d524a03b8 fix: Clamp VaultClawback to assetsAvailable for zero-amount clawback (#6646) 2026-04-06 15:13:03 +00:00
Vito Tumas
c0ee813666 fix: Add assorted Lending Protocol fixes (#6678) 
Co-authored-by: Shawn Xie <35279399+shawnxie999@users.noreply.github.com>
 2026-04-03 17:41:45 +00:00
Mayukha Vadari
8e05416211 fix: Change variable signedness and correctly handle std::optional (#6657) 2026-04-03 15:16:50 +00:00
Mayukha Vadari
81555d5456 refactor: Reorganize RPC handler files (#6628) 2026-04-02 23:46:17 +00:00
yinyiqian1
3414a1776b docs: Add explanatory comment to checkFee (#6631) 2026-04-02 20:48:35 +00:00
yinyiqian1
6d9ed125f3 fix: Decouple reserve from fee in delegate payment (#6568) 2026-04-02 20:48:00 +00:00
Vito Tumas
02fa55df8d fix: Check trustline limits for share-denominated vault withdrawals (#6645) 2026-04-01 19:31:45 +00:00
Valentin Balaschenko
6e2452207d fix: Remove fatal assertion on Linux thread name truncation (#6690) 2026-04-01 16:56:45 +00:00
Alex Kremer
29e49abd3c chore: Enable clang-tidy coreguidelines checks (#6698) 
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>
 2026-04-01 15:46:14 +00:00
Vito Tumas
bee1056faa fix: Enforce aggregate MaximumAmount in multi-send MPT (#6644) 
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
 2026-04-01 13:35:13 +00:00
Mayukha Vadari
a9afd2c116 fix: Fix previous ledger size typo in RCLConsensus (#6696) 2026-03-31 19:56:30 +00:00
Alex Kremer
2502befb42 chore: Enable clang-tidy misc checks (#6655) 2026-03-31 17:29:45 +00:00
Bart
7f53351920 chore: Remove unnecessary clang-format off/on directives (#6682) 
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com>
 2026-03-31 15:38:04 +00:00