Vito
5f6bb93b5c
fix: post merge bugs
2026-05-18 19:15:26 +02:00
Vito
2b4d8ef3a2
curse you clang-tidy
2026-05-18 19:03:39 +02:00
Vito
13358f5042
fix: post merge bugs
2026-05-18 14:34:57 +02:00
Vito
e1946278f9
Merge remote-tracking branch 'origin/develop' into tapanito/lending-cover-precision
2026-05-18 14:34:32 +02:00
Mayukha Vadari
ad7232cbc5
refactor: Rename account_ to accountID_ ( #7284 )
2026-05-18 10:56:54 +00:00
Vito
c4115ee4be
chore: clang-tidy and minor AI comments
2026-05-18 12:20:26 +02:00
Michael Legleux
93836f22db
ci: Add Linux package builds (DEB + RPM) to CI ( #6639 )
2026-05-16 05:08:37 +00:00
Mayukha Vadari
c7ecfc6a97
refactor: Clean up comments post-clang-tidy changes ( #7283 )
2026-05-15 23:02:04 +00:00
Ed Hennis
6809690fad
release: Set version to 3.3.0-b0 ( #7280 )
...
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-05-15 18:04:49 +00:00
Alex Kremer
5b6e8b6f93
refactor: Rename static constants ( #7120 )
...
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-05-15 15:32:19 +00:00
Vito
e2ba7a728b
fix: Round deposit cover to LoanBroker scale
2026-05-15 16:23:41 +02:00
Mayukha Vadari
028f0cb5da
refactor: Use isFlag where possible instead of bitwise math ( #7278 )
2026-05-15 14:00:13 +00:00
Jingchen
cce4cfef10
feat: Add verify_endpoints to help local peer network development ( #7268 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-05-14 17:07:08 +00:00
Vito
a5db99fb96
chore: please clang-tidy
2026-05-14 15:44:18 +02:00
Vito
20678e6bc4
test: Add isZeroAtScale coverage to STAmount_test
...
Tests the new STAmount::isZeroAtScale method across IOU, XRP, and MPT
amounts, covering the zero, sub-ULP, one-ULP, and scale-equals-exponent
short-circuit cases.
2026-05-14 15:30:12 +02:00
Vito
42eadf0416
review: Address code review feedback on cover precision guard
...
- Capitalize guard helper comments in Deposit and Withdraw transactors
- Fix canApplyToBrokerCover signature to use SLE::const_ref (matches header)
- Add alice balance invariant check to Withdraw no-op test case
- Add MPT positive test: verify 1-unit MPT passes the precision guard
2026-05-14 15:04:37 +02:00
Vito
c327fc1ee2
fix: Reject sub-ULP cover amounts with tecPRECISION_LOSS (fixCleanup3_2_0)
...
Add STAmount::isZeroAtScale() and canApplyToBrokerCover() to detect
amounts that round to zero at sfCoverAvailable's precision scale, then
call the guard in LoanBrokerCoverDeposit, LoanBrokerCoverWithdraw, and
LoanBrokerCoverClawback preclaim. Without the guard a sub-ULP deposit,
withdrawal, or clawback would silently succeed while moving no funds.
2026-05-14 14:44:16 +02:00
Vito
1297f0bc52
test: Add LoanBroker cover precision guard tests
...
Exercises the canApplyToBrokerCover guard introduced in
LoanBrokerCoverDeposit, LoanBrokerCoverWithdraw, and
LoanBrokerCoverClawback: three test cases (Deposit, Withdraw, Clawback)
run twice via runTestCases(all_) and runTestCases(all_ - fixCleanup3_2_0).
With the amendment on, a sub-ULP IOU amount (1e-16, which rounds to zero
at the sfCoverAvailable scale of 10 IOU) is rejected with
tecPRECISION_LOSS. Without it, the transaction silently succeeds and
sfCoverAvailable is verified to be unchanged.
2026-05-14 14:43:38 +02:00
Bart
afbccf971a
chore: Consolidate fix amendments ( #7134 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-05-13 20:46:30 +00:00
Olek
d4ebd6a168
fix: Backport Permissioned Domains fixes ( #7016 )
2026-05-13 19:22:29 +00:00
Luc des Trois Maisons
aa5e4ff89f
refactor: Improve Forwarded header field parsing ( #7126 )
2026-05-13 16:48:38 +00:00
Sergey Kuznetsov
977e5a7dba
fix: Check network ID in transactionSignFor ( #7102 )
2026-05-13 16:03:57 +00:00
Sergey Kuznetsov
c8b42a7f48
refactor: Improve RPC variable naming and handling ( #7103 )
2026-05-13 14:33:49 +00:00
Valentin Balaschenko
4ad94ae2ff
refactor: Use named constant for leaf item size ( #39 ) ( #7130 )
...
Co-authored-by: Ed Hennis <ed@ripple.com >
2026-05-13 13:53:01 +00:00
Valentin Balaschenko
411286c519
refactor: Prevent dry-run transactions from being queued ( #92 ) ( #7131 )
2026-05-13 13:22:00 +00:00
Alex Kremer
e8bdbaa1e8
refactor: Limit JSON array size ( #7112 )
2026-05-13 12:42:05 +00:00
Vito Tumas
6340c986c9
feat: Enable and rename fixSecurity3_1_3 to fixCleanup3_1_3 ( #7128 )
...
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
2026-05-13 09:42:34 +00:00
Olek
590906dadf
fix: Use transaction sequence numbers in permissioned domains ( #7129 )
2026-05-12 20:15:17 +00:00
Sergey Kuznetsov
448ae8b9df
fix: Improve json parsing of currency issuers ( #7110 )
2026-05-12 20:13:36 +00:00
rrmanukyan
45b1f4dbeb
refactor: Fill txJson based on apiVersion ( #7109 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-05-12 19:27:07 +00:00
Ed Hennis
8012b5d34f
fix: Fix touchy "funds are conserved" assertion in LoanPay ( #6231 ) ( #6967 )
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2026-05-12 19:25:11 +00:00
Ayaz Salikhov
6c2266c5c7
refactor: Remove erroneous base_uint ctor from container ( #7123 )
2026-05-12 19:24:05 +00:00
Mayukha Vadari
c4c95dbe76
refactor: Replace featureInvariantsV1_1 with fixCleanup3_2_0 ( #7116 )
2026-05-12 12:26:02 +00:00
Alex Kremer
cdee9a675c
refactor: Use more scoped enums ( #7086 )
2026-05-11 15:39:48 +00:00
Zhiyuan Wang
779b49cd93
fix: Prevent stale AuthAccounts from persisting after tfTwoAssetIfEmpty re-initialization ( #6996 )
...
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-05-09 14:43:56 +00:00
Vito Tumas
4f8142fd10
fix: Numerically-stable (1+r)^n-1 in computePaymentFactor ( #7033 )
2026-05-07 19:02:09 +00:00
Alex Kremer
7afdd71a54
chore: More fixes for bad renames ( #7092 )
2026-05-07 17:04:30 +00:00
Olek
af89854a43
fix: Stop tx processing if failed to delete expired credentials ( #6715 ) ( #6962 )
...
Co-authored-by: Ed Hennis <ed@ripple.com >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-05-07 12:57:50 +00:00
Ed Hennis
d6c4e6cb93
fix: Cap the base fee for LoanPay ( #6969 ) ( #6970 )
...
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-05-07 12:48:55 +00:00
Bart
8c71ec803d
fix: Restore clang-tidy change to section name in config ( #7091 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-05-07 10:34:47 +00:00
Ayaz Salikhov
8e2aa33f64
chore: Add IWYU pragma for boost::optional to fix clang-tidy ( #7088 )
2026-05-06 23:31:10 +00:00
Vito Tumas
a4720d0449
chore: Mark empty transactor invariants as future work ( #7080 )
2026-05-06 12:55:24 +00:00
Vet
50244a8637
chore: Update default values of base and owner reserve to 1/0.2 ( #6382 )
...
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-05-06 11:19:57 +00:00
Mayukha Vadari
5e1c35f7f7
fix: Fix regressions in server_definitions ( #7008 )
2026-05-05 17:18:26 +00:00
Alex Kremer
8995564ed6
refactor: Enable clang-tidy readability-identifier-naming check ( #6571 )
2026-05-03 10:31:53 +00:00
Bart
182d844996
refactor: Revert certain Throws by LogicErrors ( #7036 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-05-01 09:50:00 +00:00
Vito Tumas
31180f94c2
fix: Prevents overwriting a bool value in an invariant ( #6609 )
...
Co-authored-by: Ed Hennis <ed@ripple.com >
2026-04-30 13:05:09 +00:00
Bart
4d0ea8ae36
refactor: Apply various minor improvements and corrections ( #7045 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-04-30 10:22:11 +00:00
Zhiyuan Wang
dbd646bd53
fix: Store Delegate object in delegating and authorized account directories for proper deletion ( #6681 )
2026-04-29 18:17:01 +00:00
Mayukha Vadari
7be98d95de
fix: Make assorted RPC fixes ( #6529 )
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2026-04-29 18:05:34 +00:00