Pratik Mankawde
45aa2f276a
Merge branch 'pratik/otel-phase1b-telemetry-infra' into pratik/otel-phase1c-rpc-integration
...
# Conflicts:
# .github/scripts/levelization/results/loops.txt
2026-07-06 17:08:46 +01:00
Pratik Mankawde
3789ac45e2
Merge branch 'pratik/otel-phase1a-plan-docs' into pratik/otel-phase1b-telemetry-infra
...
# Conflicts:
# conan.lock
# conan/profiles/default
# conanfile.py
2026-07-06 17:07:23 +01:00
Jingchen
bfde271609
chore: Fix unity build ( #7730 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-07-06 15:22:02 +00:00
Ayaz Salikhov
d07d2aba2e
chore: Enable most modernize checks ( #7664 )
2026-07-06 12:19:52 +00:00
Ayaz Salikhov
c92285f10d
chore: Delete dead code ( #7718 )
2026-07-03 15:59:20 +00:00
Ayaz Salikhov
53649cc298
chore: Enable modernize-use-constraints ( #7715 )
2026-07-03 14:28:15 +00:00
Ayaz Salikhov
f151293e8a
chore: Enable modernize-avoid-bind ( #7711 )
2026-07-03 11:17:03 +00:00
Ayaz Salikhov
7ba1d76d05
chore: Enable modernize-use-auto ( #7707 )
2026-07-02 20:02:55 +00:00
yinyiqian1
6003fd03fc
feat: Enable ConfidentialTransfer and BatchV1_1 ( #7698 )
2026-07-02 18:37:37 +00:00
Ayaz Salikhov
41622b87ae
chore: Enable modernize-unary-static-assert ( #7705 )
2026-07-02 18:30:59 +00:00
Ayaz Salikhov
6f0f5b8bb3
chore: Make clang-tidy happy on macOS ( #7701 )
2026-07-02 16:26:09 +00:00
Timothy Banks
4c619e8a85
refactor: Retire DisallowIncomingV1 fix ( #7364 )
2026-07-02 14:17:32 +00:00
Ayaz Salikhov
8e378c4f47
build: Add verify-headers target to cleanup headers ( #7670 )
2026-07-01 23:14:17 +00:00
Timothy Banks
c53aafa6bf
refactor: Retire InnerObjTemplate fix ( #7368 )
2026-07-01 15:36:28 +00:00
Vito Tumas
0d149ba5b6
fix: Disable AMM creation with Vault shares ( #7666 )
2026-07-01 15:04:38 +00:00
Vito Tumas
ea13be81b7
feat: Add an invariant to ensure object deletion also deletes its pseudo-account ( #7445 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-07-01 13:21:23 +00:00
Denis Angell
86d8b244d6
feat: Add Batch (XLS-56) V1_1 ( #6446 )
...
Co-authored-by: Mayukha Vadari <mvadari@ripple.com >
2026-07-01 12:47:14 +00:00
Vito Tumas
ecf7f805c9
feat: Introduce lending 1.1 amendment and add MemoData field to VaultDelete transaction ( #6324 )
2026-06-30 23:51:41 +00:00
Ayaz Salikhov
74b55a59b2
chore: Enable most bugprone checks ( #7643 )
2026-06-29 13:20:17 +00:00
Shawn Xie
768d7603b1
feat: Confidential Transfer for MPT ( #5860 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: chuanshanjida <chuanshanjida@outlook.com >
Co-authored-by: Ed Hennis <ed@ripple.com >
Co-authored-by: Jingchen <a1q123456@users.noreply.github.com >
Co-authored-by: Denis Angell <dangell@transia.co >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
Co-authored-by: yinyiqian1 <yqian@ripple.com >
Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com >
Co-authored-by: Bronek Kozicki <brok@incorrekt.com >
Co-authored-by: Mayukha Vadari <mvadari@ripple.com >
Co-authored-by: Valentin Balaschenko <13349202+vlntb@users.noreply.github.com >
Co-authored-by: tequ <git@tequ.dev >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
Co-authored-by: Peter Chen <34582813+PeterChen13579@users.noreply.github.com >
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
Co-authored-by: Zhiyuan Wang <96991820+Kassaking7@users.noreply.github.com >
Co-authored-by: Alex Kremer <akremer@ripple.com >
Co-authored-by: Sergey Kuznetsov <skuznetsov@ripple.com >
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Gregory Tsipenyuk <gregtatcam@users.noreply.github.com >
Co-authored-by: chuanshanjida <chuanshanjida@outlook.com >
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
Co-authored-by: Peter Chen <ychen@ripple.com >
Co-authored-by: Timothy Banks <timothyaaronbanks@gmail.com >
Co-authored-by: Timothy Banks <tbanks@ripple.com >
2026-06-27 01:20:38 +00:00
yinyiqian1
fd8a915243
fix: Use trustline balance direction to validate IOU PaymentMint/PaymentBurn ( #7584 )
2026-06-26 22:26:53 +00:00
Vito Tumas
3e9f1d0ab8
fix: Unify freeze checks for pseudo-account deposit/withdraw ( #7382 )
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
Co-authored-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
Co-authored-by: Shawn Xie <35279399+shawnxie999@users.noreply.github.com >
2026-06-26 21:38:59 +00:00
Pratik Mankawde
9d4570f65c
Merge branch 'pratik/otel-phase1b-telemetry-infra' into pratik/otel-phase1c-rpc-integration
2026-06-26 14:29:59 +01:00
Pratik Mankawde
49103d635c
Merge branch 'pratik/otel-phase1a-plan-docs' into pratik/otel-phase1b-telemetry-infra
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-26 14:24:30 +01:00
Timothy Banks
2ab43b6fda
refactor: Retire NFTokenReserve fix ( #7367 )
2026-06-26 10:31:16 +00:00
Timothy Banks
12a5d9014e
refactor: Retire Clawback amendment ( #7353 )
2026-06-26 10:24:25 +00:00
Mayukha Vadari
b9eee1d245
refactor: Rename (mostly keylet) functions to more closely match the docs ( #7059 )
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2026-06-26 10:24:12 +00:00
Ayaz Salikhov
eef8f4a4ff
chore: Use clang-tidy v22 new features ( #7427 )
2026-06-24 17:23:29 +00:00
Ayaz Salikhov
b68e1f7170
fix: Add pragma once checker ( #7580 )
2026-06-24 12:24:04 +00:00
Jingchen
6341e75200
refactor: Refactor TaggedCache.ipp to remove const_cast in canonicalize_replace_cache ( #5638 )
...
Signed-off-by: JCW <a1q123456@users.noreply.github.com >
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-06-24 12:15:11 +00:00
Mayukha Vadari
dd7401fde2
refactor: Clean up tec object deletion logic ( #6588 )
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2026-06-22 18:44:42 +00:00
Zhiyuan Wang
19a9ed7767
fix: Move AMMInvariant weakInvariantCheck logic into the transaction ( #7032 )
2026-06-22 18:42:57 +00:00
Zhiyuan Wang
93eab33dc2
fix: Improve ValidAMM invariant ( #7295 )
2026-06-22 17:45:42 +00:00
yinyiqian1
997267f845
feat: Remove clear mutable flags for DynamicMPT XLS-94 ( #7439 )
2026-06-22 17:36:06 +00:00
yinyiqian1
772ea80a25
fix: Use template for granular delegation permissions ( #6613 )
...
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-06-17 23:20:54 +00:00
solunolab
480676d0bf
docs: Fix some comments to improve readability ( #7405 )
...
Signed-off-by: solunolab <solunolab@outlook.com >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-06-17 13:55:00 +00:00
Pratik Mankawde
cccce1c32e
Merge remote-tracking branch 'origin/release/3.2.x' into pratik/merge_3.2.x
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-17 12:53:02 +01:00
Ed Hennis
e5785c4fcb
fix: Fix Number comparison operator
2026-06-15 22:24:02 +01:00
Sergey Kuznetsov
47b06ecd17
refactor: Use rocksdb includes only when it is available
2026-06-15 22:23:54 +01:00
Bart
82ee5b7556
refactor: Handle int and uint API versions separately
2026-06-15 22:23:38 +01:00
Pratik Mankawde
f98c251011
refactor: Improve tracking of book (un)subscriptions
2026-06-15 22:23:38 +01:00
Sergey Kuznetsov
e29dc474b3
refactor: Improve payment channel closing and returned error codes
2026-06-15 22:23:28 +01:00
Pratik Mankawde
f9092e7948
Merge branch 'pratik/otel-phase1b-telemetry-infra' into pratik/otel-phase1c-rpc-integration
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-15 20:39:08 +01:00
Pratik Mankawde
f0b834a913
minor naming change
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-15 20:02:48 +01:00
Pratik Mankawde
0e9a71798c
make samping ratio static constexpr
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-15 19:44:55 +01:00
Pratik Mankawde
ba85aecf00
hide gTlDiscardCurrentSpan better
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-15 17:21:35 +01:00
Pratik Mankawde
37a4c9deb8
core review comments
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-15 17:10:23 +01:00
Pratik Mankawde
4d044e6254
ci: Harden OTel naming check — unconditional Rule F, test exemption, Rule H
...
Three robustness fixes to check_otel_naming.py, all on phase-1c where the
script lives:
- Rule F now runs UNCONDITIONALLY. It is a purely syntactic check on the
call-sites and does not need the L1 key set, so code that calls
SpanGuard::span/setAttribute directly without ever defining a *SpanNames.h
is still caught (previously it was silently skipped when no header existed).
- Exempt test files from Rule F (tests pass arbitrary literal keys to exercise
the API). The call-site matcher now requires a SpanGuard/`.`/`->` receiver,
so std::span and bare declarations no longer false-positive.
- Add Rule H (warning, non-fatal): a namespace-qualified constant used at a
telemetry call-site but not defined in any *SpanNames.h is flagged, catching
constants defined in-place instead of in the proper header. Bare locals and
std:: names are not warned to avoid noise.
SpanGuard.h / Telemetry.h @code examples updated to reference constants that
exist on this branch. README documents the new behavior.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com >
2026-06-11 16:10:08 +01:00
Pratik Mankawde
134a24d5bc
ci: Add OpenTelemetry span-attribute naming check (phase 1c)
...
Add check_otel_naming.py and wire it into on-pr.yml so every PR validates
that span-attribute names stay consistent across the code, collector, Tempo,
dashboards, and docs.
- The valid key set is derived dynamically from the *SpanNames.h constants and
the resource attributes the code registers in Telemetry.cpp — no hardcoded
allowlist to drift.
- Each rule is presence-gated: it runs only when the file it needs is in the
tree, so the check is correct whether telemetry changes land in one PR or
several (the collector/Tempo/dashboard/runbook layers arrive in later phases).
- Rule A flags dotted span-attribute keys; Rule F flags string-literal
attribute keys and span-name arguments (values may be runtime data).
- stdlib-only, mirroring the levelization check (bare `python`, no pip step).
- Telemetry.h / SpanGuard.h @code examples now use *SpanNames.h constants so
the strict literal check passes.
- CONTRIBUTING.md documents the check and how to run it locally.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com >
2026-06-11 15:26:38 +01:00
Pratik Mankawde
480b6cab3c
Merge branch 'pratik/otel-phase1b-telemetry-infra' into pratik/otel-phase1c-rpc-integration
...
Bring the phase-1a/1b naming-convention and code-sample cleanup into 1c.
Conflict resolution:
- 04-code-samples.md, POC_taskList.md: deletion wins.
- OpenTelemetryPlan docs (01/02/03/05): took the convention-applied,
code-block-free versions; verified no attribute category, table row, or
section header was lost (the differences were dotted->underscore renames).
- Telemetry.h: kept 1c's RpcSpanNames.h constant-based example
(rpc_span::attr::command) over the string literal.
- 31 non-telemetry files are clean develop carry-forward (identical to 1b).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com >
2026-06-11 14:58:51 +01:00