Pratik Mankawde
26a85c764e
code review comment addressed
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-07-06 18:15:23 +01:00
Pratik Mankawde
46dbc92b5f
code review comments addressed
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-12 20:18:12 +01:00
Pratik Mankawde
d6450631bf
removed code blocks from plan docs
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-11 14:29:01 +01:00
Pratik Mankawde
5598b0eac7
docs(telemetry): fix head sampling at 1.0, remove configurable ratio
...
Document that head sampling is intentionally fixed at 100% and no longer
exposes a sampling_ratio config knob. A per-node ratio let nodes make
divergent keep/drop decisions for the same distributed trace, producing
broken/partial traces; pinning at 1.0 with a ParentBased sampler keeps
decisions coherent across the network. Volume reduction is delegated to
collector-side tail sampling.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-09 18:22:52 +01:00
Pratik Mankawde
1fd971b78b
fix(docs): apply rename scripts to OpenTelemetry plan docs
...
Run .github/scripts/rename/docs.sh to replace rippled → xrpld
references in all plan documentation files, fixing the check-rename
CI failure.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-04-28 13:57:38 +01:00
Pratik Mankawde
913a4b794c
docs: correct OTel overhead estimates against SDK benchmarks
...
Verified CPU, memory, and network overhead calculations against
official OTel C++ SDK benchmarks (969 CI runs) and source code
analysis. Key corrections:
- Span creation: 200-500ns → 500-1000ns (SDK BM_SpanCreation median
~1000ns; original estimate matched API no-op, not SDK path)
- Per-TX overhead: 2.4μs → 4.0μs (2.0% vs 1.2%; still within 1-3%)
- Active span memory: ~200 bytes → ~500-800 bytes (Span wrapper +
SpanData + std::map attribute storage)
- Static memory: ~456KB → ~8.3MB (BatchSpanProcessor worker thread
stack ~8MB was omitted)
- Total memory ceiling: ~2.3MB → ~10MB
- Memory success metric target: <5MB → <10MB
- AddEvent: 50-80ns → 100-200ns
Added Section 3.5.4 with links to all benchmark sources.
Updated presentation.md with matching corrections.
High-level conclusions unchanged (1-3% CPU, negligible consensus).
Also includes: review fixes, cross-document consistency improvements,
additional component tracing docs (PathFinding, TxQ, Validator, etc.),
context size corrections (32 → 25 bytes).
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-04-16 15:00:47 +01:00
Pratik Mankawde
ddf894dcb0
Phase 1a: OpenTelemetry plan documentation
...
Add comprehensive planning documentation for the OpenTelemetry
distributed tracing integration:
- Tracing fundamentals and concepts
- Architecture analysis of rippled's tracing surface area
- Design decisions and trade-offs
- Implementation strategy and code samples
- Configuration reference
- Implementation phases roadmap
- Observability backend comparison
- POC task list and presentation materials
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-04-16 15:00:47 +01:00
