Pratik Mankawde
4a3fc41202
bad merge removed retire macro
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-02 15:08:13 +01:00
Pratik Mankawde
3c1a06d260
Merge branch 'develop' into pratik/Retire_fixUniversalNumber_amendment
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-02 14:43:10 +01:00
Vito Tumas
109b649106
refactor: Use STLedgerEntry type aliases instead of std::shared_ptr ( #7282 )
2026-06-01 15:27:13 +00:00
Vito Tumas
99431d7833
fix: Pin overpayment principal reduction to exact on-grid value ( #7360 )
2026-05-31 22:54:23 +00:00
Ed Hennis
47365f4220
fix: Improve upward rounding edge cases for Number::operator/= ( #7328 )
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com >
2026-05-31 00:23:29 +00:00
Bart
1599c1a672
refactor: Revert "perf: Remove unnecessary caches ( #5439 )" ( #7359 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-05-30 18:48:59 +00:00
Ayaz Salikhov
f9551ac5ca
style: Run shfmt on workflows, actions and markdown bash code ( #7333 )
2026-05-27 19:24:18 +00:00
Bart
396d772a15
refactor: Enable support for fixCleanup3_2_0 amendment ( #7347 )
2026-05-27 19:10:33 +00:00
Ed Hennis
7da643d864
fix: Fix a rounding error at the Number::maxRep cusp ( #7051 )
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com >
2026-05-27 15:19:20 +00:00
Vito Tumas
49567e7283
fix: Fix edge-case where vault-depositor may get stuck ( #7139 )
2026-05-26 18:18:40 +00:00
Vito Tumas
633ef4706f
fix: Fix VaultInvariant and VaultDeposit precision bugs at IOU scale boundaries ( #7272 )
...
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-05-26 16:32:44 +00:00
Pratik Mankawde
2f18167550
Merge branch 'develop' into pratik/Retire_fixUniversalNumber_amendment
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-05-26 16:56:31 +01:00
Jingchen
a911f9089e
fix: Use consistent scale for debtTotal ( #7093 )
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-05-24 20:44:29 +00:00
Valentin Balaschenko
30de556224
fix: Address review feedback on FD/handle guarding ( #5823 follow-up) ( #7310 )
2026-05-23 14:48:48 +00:00
Gregory Tsipenyuk
dcd2ff0b5f
fix: Fix non-canonical MPT amount ( #7117 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-05-23 06:40:26 +00:00
Gregory Tsipenyuk
3547a9335f
fix: Add assorted MPT/DEX fixes ( #7040 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
Co-authored-by: Shawn Xie <35279399+shawnxie999@users.noreply.github.com >
2026-05-21 18:29:53 +00:00
Bart
1a98182e23
refactor: Remove dead fetchBatch code ( #7309 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-05-21 17:52:41 +00:00
Vito Tumas
e24de65f42
chore: Revert graceful peer disconnection and follow-up fix ( #7296 )
2026-05-21 16:13:41 +00:00
Vito Tumas
7fdaa0a5ef
fix: Fix IOU precision issues in LoanBrokerCover transactions ( #7274 )
2026-05-21 14:51:58 +00:00
Shawn Xie
28cc20c816
fix: Fix wrong hybrid offer orderbook placement and update LedgerStateFix to amend ExchangeRate meta ( #7087 )
...
Co-authored-by: Peter Chen <ychen@ripple.com >
2026-05-21 06:19:04 +00:00
Alex Kremer
a830ab10ef
style: More clang-tidy identifier renaming ( #7290 )
2026-05-20 21:31:15 +00:00
Shawn Xie
8c0080020f
fix: Update pDEX invariant firing under a valid offer deletion ( #7118 )
...
Co-authored-by: Peter Chen <ychen@ripple.com >
2026-05-20 21:10:04 +00:00
Mayukha Vadari
242ce3e9e4
refactor: Fix sfGeneric and sfInvalid field names ( #7300 )
2026-05-20 19:47:59 +00:00
box4wangjing
a5d238e7d4
docs: Fix some comments to improve readability ( #7122 )
...
Signed-off-by: box4wangjing <box4wangjing@outlook.com >
Co-authored-by: Mayukha Vadari <mvadari@ripple.com >
2026-05-20 19:46:45 +00:00
Vito Tumas
9cb049276d
feat: Propagate underlying MPT flags to vault shares ( #7077 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: Denis Angell <dangell@transia.co >
Co-authored-by: Fomo <508629+shortthefomo@users.noreply.github.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-05-20 19:44:09 +00:00
Mayukha Vadari
ad7232cbc5
refactor: Rename account_ to accountID_ ( #7284 )
2026-05-18 10:56:54 +00:00
Mayukha Vadari
c7ecfc6a97
refactor: Clean up comments post-clang-tidy changes ( #7283 )
2026-05-15 23:02:04 +00:00
Alex Kremer
5b6e8b6f93
refactor: Rename static constants ( #7120 )
...
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-05-15 15:32:19 +00:00
Mayukha Vadari
028f0cb5da
refactor: Use isFlag where possible instead of bitwise math ( #7278 )
2026-05-15 14:00:13 +00:00
Bart
afbccf971a
chore: Consolidate fix amendments ( #7134 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-05-13 20:46:30 +00:00
Sergey Kuznetsov
551f3c3b96
refactor: Move unhex lookup table out of function ( #7104 )
2026-05-13 17:48:43 +00:00
Sergey Kuznetsov
977e5a7dba
fix: Check network ID in transactionSignFor ( #7102 )
2026-05-13 16:03:57 +00:00
Valentin Balaschenko
4ad94ae2ff
refactor: Use named constant for leaf item size ( #39 ) ( #7130 )
...
Co-authored-by: Ed Hennis <ed@ripple.com >
2026-05-13 13:53:01 +00:00
Alex Kremer
e8bdbaa1e8
refactor: Limit JSON array size ( #7112 )
2026-05-13 12:42:05 +00:00
Vito Tumas
6340c986c9
feat: Enable and rename fixSecurity3_1_3 to fixCleanup3_1_3 ( #7128 )
...
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
2026-05-13 09:42:34 +00:00
Ayaz Salikhov
6c2266c5c7
refactor: Remove erroneous base_uint ctor from container ( #7123 )
2026-05-12 19:24:05 +00:00
Mayukha Vadari
c4c95dbe76
refactor: Replace featureInvariantsV1_1 with fixCleanup3_2_0 ( #7116 )
2026-05-12 12:26:02 +00:00
Alex Kremer
cdee9a675c
refactor: Use more scoped enums ( #7086 )
2026-05-11 15:39:48 +00:00
Vito Tumas
4f8142fd10
fix: Numerically-stable (1+r)^n-1 in computePaymentFactor ( #7033 )
2026-05-07 19:02:09 +00:00
Alex Kremer
7afdd71a54
chore: More fixes for bad renames ( #7092 )
2026-05-07 17:04:30 +00:00
Olek
af89854a43
fix: Stop tx processing if failed to delete expired credentials ( #6715 ) ( #6962 )
...
Co-authored-by: Ed Hennis <ed@ripple.com >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-05-07 12:57:50 +00:00
Pratik Mankawde
d258fdc7b0
refactor: Retire fixUniversalNumber amendment
...
Remove all conditional code paths guarded by fixUniversalNumber, keeping
only the "enabled" path since the amendment is now permanently active.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
2026-05-05 15:30:53 +01:00
Pratik Mankawde
afc3835d0a
refactor: Align identifier naming with develop
...
Restore NOLINT-protected headers and apply develop's identifier naming
conventions to files modified in this branch.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
2026-05-05 15:30:12 +01:00
Pratik Mankawde
875911f156
Merge branch 'develop' into pratik/Retire_fixUniversalNumber_amendment
...
# Conflicts:
# include/xrpl/basics/CountedObject.h
# include/xrpl/basics/Expected.h
# include/xrpl/basics/IntrusivePointer.ipp
# include/xrpl/basics/IntrusiveRefCounts.h
# include/xrpl/basics/Log.h
# include/xrpl/basics/Number.h
# include/xrpl/basics/SlabAllocator.h
# include/xrpl/basics/TaggedCache.h
# include/xrpl/basics/TaggedCache.ipp
# include/xrpl/basics/UptimeClock.h
# include/xrpl/basics/base_uint.h
# include/xrpl/basics/chrono.h
# include/xrpl/basics/hardened_hash.h
# include/xrpl/basics/partitioned_unordered_map.h
# include/xrpl/basics/tagged_integer.h
# include/xrpl/beast/clock/abstract_clock.h
# include/xrpl/beast/clock/basic_seconds_clock.h
# include/xrpl/beast/container/aged_unordered_map.h
# include/xrpl/beast/container/detail/aged_container_iterator.h
# include/xrpl/beast/container/detail/aged_unordered_container.h
# include/xrpl/beast/core/List.h
# include/xrpl/beast/core/LockFreeStack.h
# include/xrpl/beast/hash/hash_append.h
# include/xrpl/beast/insight/Counter.h
# include/xrpl/beast/insight/Event.h
# include/xrpl/beast/insight/Gauge.h
# include/xrpl/beast/insight/Hook.h
# include/xrpl/beast/insight/Meter.h
# include/xrpl/beast/net/IPEndpoint.h
# include/xrpl/beast/unit_test/detail/const_container.h
# include/xrpl/beast/unit_test/global_suites.h
# include/xrpl/beast/unit_test/match.h
# include/xrpl/beast/unit_test/recorder.h
# include/xrpl/beast/unit_test/reporter.h
# include/xrpl/beast/unit_test/results.h
# include/xrpl/beast/unit_test/suite.h
# include/xrpl/beast/unit_test/suite_info.h
# include/xrpl/beast/utility/Journal.h
# include/xrpl/beast/utility/PropertyStream.h
# include/xrpl/core/ClosureCounter.h
# include/xrpl/core/Coro.ipp
# include/xrpl/core/Job.h
# include/xrpl/core/JobQueue.h
# include/xrpl/core/JobTypeData.h
# include/xrpl/core/JobTypeInfo.h
# include/xrpl/core/JobTypes.h
# include/xrpl/core/LoadMonitor.h
# include/xrpl/core/detail/Workers.h
# include/xrpl/core/detail/semaphore.h
# include/xrpl/json/json_value.h
# include/xrpl/json/json_writer.h
# include/xrpl/ledger/Ledger.h
# include/xrpl/ledger/helpers/TokenHelpers.h
# include/xrpl/nodestore/NodeObject.h
# include/xrpl/protocol/AmountConversions.h
# include/xrpl/protocol/ApiVersion.h
# include/xrpl/protocol/Book.h
# include/xrpl/protocol/ErrorCodes.h
# include/xrpl/protocol/Feature.h
# include/xrpl/protocol/Indexes.h
# include/xrpl/protocol/Quality.h
# include/xrpl/protocol/SField.h
# include/xrpl/protocol/STAmount.h
# include/xrpl/protocol/STArray.h
# include/xrpl/protocol/STBase.h
# include/xrpl/protocol/STLedgerEntry.h
# include/xrpl/protocol/STObject.h
# include/xrpl/protocol/STPathSet.h
# include/xrpl/protocol/STTx.h
# include/xrpl/protocol/STValidation.h
# include/xrpl/protocol/STVector256.h
# include/xrpl/protocol/Serializer.h
# include/xrpl/protocol/XRPAmount.h
# include/xrpl/protocol/detail/features.macro
# include/xrpl/protocol/json_get_or_throw.h
# include/xrpl/resource/Charge.h
# include/xrpl/resource/Consumer.h
# include/xrpl/server/InfoSub.h
# include/xrpl/shamap/FullBelowCache.h
# include/xrpl/shamap/SHAMapAddNode.h
# src/libxrpl/protocol/AMMCore.cpp
# src/libxrpl/protocol/IOUAmount.cpp
# src/libxrpl/protocol/STAmount.cpp
# src/libxrpl/tx/Transactor.cpp
# src/libxrpl/tx/applySteps.cpp
# src/test/app/AMM_test.cpp
# src/test/app/NFToken_test.cpp
# src/test/app/OfferMPT_test.cpp
# src/test/app/Offer_test.cpp
# src/test/jtx/AMM.h
# src/test/jtx/AMMTest.h
# src/test/jtx/Env.h
# src/test/jtx/Env_ss.h
# src/test/jtx/JTx.h
# src/test/jtx/PathSet.h
# src/test/jtx/TestHelpers.h
# src/test/jtx/amount.h
# src/test/jtx/balance.h
# src/test/jtx/batch.h
# src/test/jtx/credentials.h
# src/test/jtx/deposit.h
# src/test/jtx/escrow.h
# src/test/jtx/jtx_json.h
# src/test/jtx/mpt.h
# src/test/jtx/multisign.h
# src/test/jtx/paths.h
# src/test/jtx/prop.h
# src/test/jtx/regkey.h
# src/test/jtx/tags.h
# src/xrpld/app/misc/TxQ.h
# src/xrpld/app/misc/detail/TxQ.cpp
# src/xrpld/rpc/detail/AssetCache.h
# src/xrpld/rpc/detail/Pathfinder.h
# src/xrpld/rpc/detail/TrustLine.h
2026-05-05 13:49:14 +01:00
Pratik Mankawde
87f4a482c1
refactor: Align identifier naming with develop
...
Apply readability-identifier-naming clang-tidy check to branch-modified
files (and their transitive includes) in preparation for merging develop.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
2026-05-05 13:43:49 +01:00
Alex Kremer
8995564ed6
refactor: Enable clang-tidy readability-identifier-naming check ( #6571 )
2026-05-03 10:31:53 +00:00
Pratik Mankawde
e9210ccb2e
Merge branch 'develop' into pratik/Retire_fixUniversalNumber_amendment
2026-05-01 15:02:43 +01:00
Bart
182d844996
refactor: Revert certain Throws by LogicErrors ( #7036 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-05-01 09:50:00 +00:00
Pratik Mankawde
de744488bc
Merge branch 'develop' into pratik/Retire_fixUniversalNumber_amendment
2026-04-30 15:23:10 +01:00
Vito Tumas
31180f94c2
fix: Prevents overwriting a bool value in an invariant ( #6609 )
...
Co-authored-by: Ed Hennis <ed@ripple.com >
2026-04-30 13:05:09 +00:00
