Commit Graph

10209 Commits

Author SHA1 Message Date
Ed Hennis
4974fcdf71 Merge branch 'ximinez/number-round-maxrep-down' into ximinez/number-round-maxrep 2026-07-01 16:03:00 -04:00
Ed Hennis
cb5ecae7f3 Merge branch 'develop' into ximinez/number-round-maxrep-down 2026-07-01 16:02:56 -04:00
Ed Hennis
a0e6971399 Apply suggestions from code review
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
2026-07-01 12:04:42 -04:00
Timothy Banks
c53aafa6bf refactor: Retire InnerObjTemplate fix (#7368) 2026-07-01 15:36:28 +00:00
Vito Tumas
0d149ba5b6 fix: Disable AMM creation with Vault shares (#7666) 2026-07-01 15:04:38 +00:00
Ayaz Salikhov
d1ff948244 test: Add tests for TMProofPathResponse and TMReplayDeltaResponse invalid hash/key sizes (#7593) 2026-07-01 13:30:03 +00:00
Vito Tumas
ea13be81b7 feat: Add an invariant to ensure object deletion also deletes its pseudo-account (#7445)
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-07-01 13:21:23 +00:00
Denis Angell
86d8b244d6 feat: Add Batch (XLS-56) V1_1 (#6446)
Co-authored-by: Mayukha Vadari <mvadari@ripple.com>
2026-07-01 12:47:14 +00:00
Vito Tumas
ecf7f805c9 feat: Introduce lending 1.1 amendment and add MemoData field to VaultDelete transaction (#6324) 2026-06-30 23:51:41 +00:00
Ed Hennis
c8c45b343e Add some tests for Numbers with large exponents 2026-06-30 19:51:10 -04:00
Ed Hennis
18de60c399 clang-tidy: missing headers 2026-06-30 18:11:39 -04:00
Ed Hennis
16f286553e Merge branch 'ximinez/number-round-maxrep-down' into ximinez/number-round-maxrep 2026-06-30 12:35:23 -04:00
Ed Hennis
ea6f08d301 Merge branch 'develop' into ximinez/number-round-maxrep-down 2026-06-30 12:26:31 -04:00
Ayaz Salikhov
8abbd1ba3a chore: Use std::ranges where possible (#7634) 2026-06-30 11:03:19 +00:00
Ed Hennis
93f59bd707 Merge branch 'ximinez/number-round-maxrep-down' into ximinez/number-round-maxrep 2026-06-29 19:47:41 -04:00
Ed Hennis
027c6f6e57 Merge branch 'develop' into ximinez/number-round-maxrep-down 2026-06-29 11:18:23 -04:00
Ed Hennis
c425c4ee0c Merge branch 'ximinez/number-round-maxrep-down' into ximinez/number-round-maxrep 2026-06-29 11:14:47 -04:00
Ayaz Salikhov
74b55a59b2 chore: Enable most bugprone checks (#7643) 2026-06-29 13:20:17 +00:00
Shawn Xie
768d7603b1 feat: Confidential Transfer for MPT (#5860)
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: chuanshanjida <chuanshanjida@outlook.com>
Co-authored-by: Ed Hennis <ed@ripple.com>
Co-authored-by: Jingchen <a1q123456@users.noreply.github.com>
Co-authored-by: Denis Angell <dangell@transia.co>
Co-authored-by: Bart <bthomee@users.noreply.github.com>
Co-authored-by: yinyiqian1 <yqian@ripple.com>
Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com>
Co-authored-by: Bronek Kozicki <brok@incorrekt.com>
Co-authored-by: Mayukha Vadari <mvadari@ripple.com>
Co-authored-by: Valentin Balaschenko <13349202+vlntb@users.noreply.github.com>
Co-authored-by: tequ <git@tequ.dev>
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>
Co-authored-by: Peter Chen <34582813+PeterChen13579@users.noreply.github.com>
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com>
Co-authored-by: Zhiyuan Wang <96991820+Kassaking7@users.noreply.github.com>
Co-authored-by: Alex Kremer <akremer@ripple.com>
Co-authored-by: Sergey Kuznetsov <skuznetsov@ripple.com>
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Gregory Tsipenyuk <gregtatcam@users.noreply.github.com>
Co-authored-by: chuanshanjida <chuanshanjida@outlook.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Peter Chen <ychen@ripple.com>
Co-authored-by: Timothy Banks <timothyaaronbanks@gmail.com>
Co-authored-by: Timothy Banks <tbanks@ripple.com>
2026-06-27 01:20:38 +00:00
yinyiqian1
fd8a915243 fix: Use trustline balance direction to validate IOU PaymentMint/PaymentBurn (#7584) 2026-06-26 22:26:53 +00:00
Ed Hennis
394ea6b69c Merge branch 'develop' into ximinez/number-round-maxrep-down 2026-06-26 18:03:40 -04:00
Vito Tumas
3e9f1d0ab8 fix: Unify freeze checks for pseudo-account deposit/withdraw (#7382)
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com>
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>
Co-authored-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com>
Co-authored-by: Shawn Xie <35279399+shawnxie999@users.noreply.github.com>
2026-06-26 21:38:59 +00:00
Ed Hennis
4a1851ab47 Review feedback from @gregtatcam and AI
- Simplify the before and after comparison in numberFromJson
- Update tests
2026-06-26 17:37:24 -04:00
yinyiqian1
652b5f9af1 fix: Block delegate tx from being queued (#7640) 2026-06-26 20:34:22 +00:00
Ed Hennis
78c5471af6 Review feedback: STNumber parsing
- In numberFromJson(), if the result is 0, only the mantissa has to
  match, because there are many valid ways to represent 0.
- Update several broken tests that I missed earlier.
2026-06-26 14:08:53 -04:00
Ed Hennis
573bf2abe3 fixup! One more test case to show that big integers don't include "e0" 2026-06-26 10:36:00 -04:00
Timothy Banks
2ab43b6fda refactor: Retire NFTokenReserve fix (#7367) 2026-06-26 10:31:16 +00:00
Timothy Banks
12a5d9014e refactor: Retire Clawback amendment (#7353) 2026-06-26 10:24:25 +00:00
Mayukha Vadari
b9eee1d245 refactor: Rename (mostly keylet) functions to more closely match the docs (#7059)
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2026-06-26 10:24:12 +00:00
Ed Hennis
24ab150bdf One more test case to show that big integers don't include "e0" 2026-06-25 22:43:07 -04:00
Ed Hennis
78884b8b00 Do the Number parsing verification for all cases 2026-06-25 22:41:03 -04:00
Ed Hennis
f730af6e05 Review feedback from @gregtatcam: json string number parsing
- Change the parsing in numberFromJson so that if the resulting Number
  is not the same as the parsed NumberParts, then throw, because
  unexpected rounding occurred
- Add modified suggested test cases, and modify some existing ones,
  which test this behavior.
2026-06-25 22:35:25 -04:00
Ed Hennis
f0d7dd0117 Merge branch 'ximinez/number-round-maxrep-down' into ximinez/number-round-maxrep 2026-06-25 19:12:17 -04:00
Ed Hennis
2a5b1b4e17 Review feedback from @gregtatcam, plus a few extras
- Rename MantissaRange::Get to MantissaRange::Access. The name doesn't
  really matter, but since the intent of the class is to control access
  to one function, this works.
- Exclude the MantissaScale enum from linting for
  readability-enum-initial-value. clang-tidy was complaining that
  "error: initial values in enum 'xrpl::MantissaRange::MantissaScale'
  are not consistent, consider explicit initialization of all, none or
  only the first enumerator", but I don't care. I just need Large to
  match the last value.
- Add a static_assert in setCurrentTransactionRules, so that if another
  MantissaScale is added (and Large is properly updated), the engineer
  won't forget to add a case for it there.
2026-06-25 19:02:53 -04:00
Ed Hennis
ba44e98e0e Merge branch 'ximinez/number-round-maxrep-down' into ximinez/number-round-maxrep 2026-06-25 15:33:12 -04:00
Ed Hennis
4ff398ba2d Address AI review feedback
- Mostly just clarifying comments and reorganizing functions.
2026-06-25 15:31:51 -04:00
Ed Hennis
cc4c06cf86 Address AI review feedback: mantissa assertion, test resiliency
- Move code around and add comments in `bringIntoRange` to make it
  clearer that mantissas should not be 0, but fall back gracefully in
  non-debug builds if they are.
- Make a test that checks for Large330 future-proof if more scales are
  added later.
2026-06-25 14:26:59 -04:00
Ed Hennis
6906f47349 Apply suggestions from AI code review: typos
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
2026-06-25 14:25:32 -04:00
Ed Hennis
d2c5d95032 Merge branch 'ximinez/number-round-maxrep-down' into ximinez/number-round-maxrep 2026-06-25 11:43:34 -04:00
Ed Hennis
6aa9031848 Merge branch 'develop' into ximinez/number-round-maxrep-down 2026-06-25 11:43:30 -04:00
Ayaz Salikhov
eef8f4a4ff chore: Use clang-tidy v22 new features (#7427) 2026-06-24 17:23:29 +00:00
Ayaz Salikhov
4fec58251b build: Patch nix binaries in CMake (#7539)
Co-authored-by: Bart <bthomee@users.noreply.github.com>
2026-06-24 13:56:18 +00:00
Mayukha Vadari
6736ab39df test: Add test for Permissioned Domain sequence fix (#7591)
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
2026-06-24 12:24:27 +00:00
Ayaz Salikhov
b68e1f7170 fix: Add pragma once checker (#7580) 2026-06-24 12:24:04 +00:00
Timothy Banks
bb7c4d1c9f fix: Additional RPC validation checks on ammRpcInfo account and amm_account fields. (#7324) 2026-06-24 12:23:12 +00:00
Zhiyuan Wang
69d289a388 fix: AMM Quality Leak into Domain BookStep for Permissioned DEX (#6853)
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
2026-06-24 12:15:45 +00:00
Jingchen
6341e75200 refactor: Refactor TaggedCache.ipp to remove const_cast in canonicalize_replace_cache (#5638)
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-06-24 12:15:11 +00:00
yinyiqian1
5a2c82f699 fix: Reject delegate permission to pseudo accounts (#7597) 2026-06-23 19:55:23 +00:00
Ed Hennis
817f541c69 Merge branch 'ximinez/number-round-maxrep-down' into ximinez/number-round-maxrep 2026-06-23 11:10:04 -04:00
Ed Hennis
e090083dc7 Merge branch 'develop' into ximinez/number-round-maxrep-down 2026-06-23 11:09:59 -04:00