Pratik Mankawde
49103d635c
Merge branch 'pratik/otel-phase1a-plan-docs' into pratik/otel-phase1b-telemetry-infra
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-26 14:24:30 +01:00
Timothy Banks
2ab43b6fda
refactor: Retire NFTokenReserve fix ( #7367 )
2026-06-26 10:31:16 +00:00
Timothy Banks
12a5d9014e
refactor: Retire Clawback amendment ( #7353 )
2026-06-26 10:24:25 +00:00
Mayukha Vadari
b9eee1d245
refactor: Rename (mostly keylet) functions to more closely match the docs ( #7059 )
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2026-06-26 10:24:12 +00:00
Ayaz Salikhov
eef8f4a4ff
chore: Use clang-tidy v22 new features ( #7427 )
2026-06-24 17:23:29 +00:00
Ayaz Salikhov
b68e1f7170
fix: Add pragma once checker ( #7580 )
2026-06-24 12:24:04 +00:00
Jingchen
6341e75200
refactor: Refactor TaggedCache.ipp to remove const_cast in canonicalize_replace_cache ( #5638 )
...
Signed-off-by: JCW <a1q123456@users.noreply.github.com >
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-06-24 12:15:11 +00:00
Mayukha Vadari
dd7401fde2
refactor: Clean up tec object deletion logic ( #6588 )
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2026-06-22 18:44:42 +00:00
Zhiyuan Wang
19a9ed7767
fix: Move AMMInvariant weakInvariantCheck logic into the transaction ( #7032 )
2026-06-22 18:42:57 +00:00
Zhiyuan Wang
93eab33dc2
fix: Improve ValidAMM invariant ( #7295 )
2026-06-22 17:45:42 +00:00
yinyiqian1
997267f845
feat: Remove clear mutable flags for DynamicMPT XLS-94 ( #7439 )
2026-06-22 17:36:06 +00:00
yinyiqian1
772ea80a25
fix: Use template for granular delegation permissions ( #6613 )
...
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-06-17 23:20:54 +00:00
solunolab
480676d0bf
docs: Fix some comments to improve readability ( #7405 )
...
Signed-off-by: solunolab <solunolab@outlook.com >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-06-17 13:55:00 +00:00
Pratik Mankawde
cccce1c32e
Merge remote-tracking branch 'origin/release/3.2.x' into pratik/merge_3.2.x
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-17 12:53:02 +01:00
Ed Hennis
e5785c4fcb
fix: Fix Number comparison operator
2026-06-15 22:24:02 +01:00
Sergey Kuznetsov
47b06ecd17
refactor: Use rocksdb includes only when it is available
2026-06-15 22:23:54 +01:00
Bart
82ee5b7556
refactor: Handle int and uint API versions separately
2026-06-15 22:23:38 +01:00
Pratik Mankawde
f98c251011
refactor: Improve tracking of book (un)subscriptions
2026-06-15 22:23:38 +01:00
Sergey Kuznetsov
e29dc474b3
refactor: Improve payment channel closing and returned error codes
2026-06-15 22:23:28 +01:00
Pratik Mankawde
f0b834a913
minor naming change
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-15 20:02:48 +01:00
Pratik Mankawde
0e9a71798c
make samping ratio static constexpr
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-15 19:44:55 +01:00
Pratik Mankawde
ba85aecf00
hide gTlDiscardCurrentSpan better
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-15 17:21:35 +01:00
Pratik Mankawde
37a4c9deb8
core review comments
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-15 17:10:23 +01:00
Pratik Mankawde
e9cb9421ef
Merge branch 'pratik/otel-phase1a-plan-docs' into pratik/otel-phase1b-telemetry-infra
...
Bring the span attribute naming convention (phase 1a) into phase 1b.
Conflict resolution kept phase-1b's SpanGuard-based workflow and applied
the underscore naming convention to all non-code-sample text:
- Converted prose, tables, Mermaid labels, and TraceQL/PromQL query
references across the plan docs to the underscore form.
- Converted the two @code attribute-key examples in Telemetry.h
(command, tx_type).
- Left the code-sample files (04-code-samples.md, POC_taskList.md) and
03-implementation-strategy.md code blocks at the phase-1b version; the
code-sample docs are slated for removal on phase-1a.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com >
2026-06-11 14:10:52 +01:00
Zhiyuan Wang
09c36d066e
fix: Correct hybrid offer deletion on credential expiry ( #6843 )
...
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-06-10 20:42:41 +00:00
Pratik Mankawde
e205d0ef8e
handle gTlDiscardCurrentSpan change
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-10 14:00:52 +01:00
Pratik Mankawde
8a4bf2dee6
refactor: Retire fixUniversalNumber amendment ( #5962 )
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
2026-06-10 10:16:03 +00:00
Pratik Mankawde
e11bf35691
fix: Update BasicConfig.h include path after upstream reorg
...
BasicConfig.h moved from xrpl/basics/ to xrpl/config/ on develop
(PR #7095 / reorg). Phase 1b's telemetry headers still referenced the
old path, breaking a fresh compile with "BasicConfig.h: No such file or
directory". Point both telemetry includes at the new location.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com >
2026-06-10 10:42:52 +01:00
Pratik Mankawde
7a4baab7cb
minor clangtidy fix
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-10 10:29:19 +01:00
Pratik Mankawde
848cbcbfbe
Merge branch 'pratik/otel-phase1a-plan-docs' into pratik/otel-phase1b-telemetry-infra
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-10 10:15:31 +01:00
Ed Hennis
2cbc3c139e
fix: Fix Number comparison operator ( #7406 )
2026-06-09 17:46:56 +00:00
Pratik Mankawde
fa71280795
removed head sampling ratio from config
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-09 18:45:52 +01:00
Ayaz Salikhov
fccb109e48
feat: Use C++ 23 standard ( #7431 )
2026-06-09 17:36:17 +00:00
Vito Tumas
0fb1aca461
refactor: Introduce XRPL_ASSERT_IF for amendment-gated assertions ( #7378 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-06-09 17:02:06 +00:00
Bart
c552eb333f
refactor: Change config section and key string literals into constants ( #7095 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-06-09 14:58:21 +00:00
Bart
c9769d1add
refactor: Use std::move and std::string_view where possible ( #7424 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-06-09 13:56:32 +00:00
Pratik Mankawde
a946ce7458
feat(telemetry): enable peer tracing by default
...
Flip the tracePeer Setup default and the trace_peer config parser
default from off to on, and update the example config and build doc to
match. Peer spans record only peer_id (a node-local numeric connection
id) plus trust/ledger metadata — no IP addresses or public keys — so
the privacy concern behind disabling it does not apply. The high-volume
characteristic is retained in the docs.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-09 13:43:32 +01:00
Pratik Mankawde
57a54ad0fe
Merge branch 'pratik/otel-phase1a-plan-docs' into pratik/otel-phase1b-telemetry-infra
2026-06-09 13:34:58 +01:00
Bart
ee9fbc4e08
refactor: Use const function arguments where possible ( #7423 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-06-09 10:04:09 +00:00
Ayaz Salikhov
2111bb4b95
ci: Update clang-tidy to nix-based v22 ( #7412 )
2026-06-05 14:11:47 +00:00
Bart
96b2c0964f
refactor: Replace intr_ptr::SharedPtr<SHAMapTreeNode> by SHAMapTreeNodePtr ( #7396 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-06-03 15:34:19 +00:00
Vito Tumas
109b649106
refactor: Use STLedgerEntry type aliases instead of std::shared_ptr ( #7282 )
2026-06-01 15:27:13 +00:00
Pratik Mankawde
bf527a41dd
Merge branch 'pratik/otel-phase1a-plan-docs' into pratik/otel-phase1b-telemetry-infra
2026-06-01 12:33:03 +01:00
Vito Tumas
99431d7833
fix: Pin overpayment principal reduction to exact on-grid value ( #7360 )
2026-05-31 22:54:23 +00:00
Ed Hennis
47365f4220
fix: Improve upward rounding edge cases for Number::operator/= ( #7328 )
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com >
2026-05-31 00:23:29 +00:00
Bart
1599c1a672
refactor: Revert "perf: Remove unnecessary caches ( #5439 )" ( #7359 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-05-30 18:48:59 +00:00
Pratik Mankawde
3a1f22583f
Merge branch 'pratik/otel-phase1a-plan-docs' into pratik/otel-phase1b-telemetry-infra
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-05-29 15:34:22 +01:00
Pratik Mankawde
68a69d9064
updated as per latest clang-tidy
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-05-29 14:50:24 +01:00
Ayaz Salikhov
f9551ac5ca
style: Run shfmt on workflows, actions and markdown bash code ( #7333 )
2026-05-27 19:24:18 +00:00
Bart
396d772a15
refactor: Enable support for fixCleanup3_2_0 amendment ( #7347 )
2026-05-27 19:10:33 +00:00