Ed Hennis
4304b3acb4
Fix clang-tidy issues
2026-04-17 18:51:07 -04:00
Ed Hennis
29af96bfa1
Address copilot review feedback: correct sign of borrowerDelta
2026-04-17 18:46:50 -04:00
Ed Hennis
7944d03795
Merge remote-tracking branch 'upstream/develop' into ximinez/loanpay-assertion-develop
...
* upstream/develop: (30 commits)
chore: Enable clang-tidy include cleaner (6947)
fix: Change AMMClawback return code to tecNO_PERMISSION (6946)
ci: [DEPENDABOT] bump actions/upload-pages-artifact from 4.0.0 to 5.0.0 (6927)
ci: [DEPENDABOT] bump actions/upload-artifact from 7.0.0 to 7.0.1 (6928)
chore: Enable clang-tidy readability checks (6930)
fix: Fix unity build for book step (6942)
chore: Move codegen venv setup into build stage (6617)
chore: Enable most clang-tidy bugprone checks (6929)
refactor: Improve exception handling (6540) (6735)
refactor: Remove unused notTooManyOffers function from NFTokenUtils (6737)
fix: Change `Tuning::bookOffers` minimum limit to 1 (6812)
chore: Make pre-commit line ending conversions work on Windows (6832) (6833)
fix: Add description for `terLOCKED` error (6811)
fix: Address AI reviewer comments for Permission Delegation (6675)
refactor: Combine `AMMHelpers` and `AMMUtils` (6733)
feat: Add MPT support to DEX (5285)
fix: Handle WSClient write failure when server closes WebSocket (6671)
ci: Change conditions for uploading artifacts in public/private/org repos (6734)
refactor: Rename non-functional uses of `ripple(d)` to `xrpl(d)` (6676)
refactor: Move more helper files into `libxrpl/ledger/helpers` (6731)
...
2026-04-17 16:13:26 -04:00
Alex Kremer
653a383ff5
chore: Enable clang-tidy include cleaner ( #6947 )
2026-04-17 16:43:49 +00:00
Gregory Tsipenyuk
affe5835fe
fix: Change AMMClawback return code to tecNO_PERMISSION ( #6946 )
2026-04-17 14:19:58 +00:00
dependabot[bot]
ef2642f873
ci: [DEPENDABOT] bump actions/upload-pages-artifact from 4.0.0 to 5.0.0 ( #6927 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-04-17 14:02:02 +00:00
dependabot[bot]
b2038163bc
ci: [DEPENDABOT] bump actions/upload-artifact from 7.0.0 to 7.0.1 ( #6928 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-04-17 14:01:56 +00:00
Alex Kremer
f1a5ba43ad
chore: Enable clang-tidy readability checks ( #6930 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-04-17 13:30:52 +00:00
Jingchen
4a73be499d
fix: Fix unity build for book step ( #6942 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-04-16 17:12:00 +00:00
Sergey Kuznetsov
d52d735543
chore: Move codegen venv setup into build stage ( #6617 )
...
Co-authored-by: JCW <a1q123456@users.noreply.github.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-04-15 18:50:49 +00:00
Alex Kremer
6a0ce46755
chore: Enable most clang-tidy bugprone checks ( #6929 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-04-14 20:24:21 +00:00
Bart
2f029a2120
refactor: Improve exception handling ( #6540 ) ( #6735 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-04-14 17:14:24 +00:00
Zhiyuan Wang
61fbde3a71
refactor: Remove unused notTooManyOffers function from NFTokenUtils ( #6737 )
2026-04-13 23:18:10 +00:00
Bart
e2e537b3bb
fix: Change Tuning::bookOffers minimum limit to 1 ( #6812 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-04-10 14:38:46 +00:00
Ed Hennis
a873250019
chore: Make pre-commit line ending conversions work on Windows ( #6832 ) ( #6833 )
2026-04-10 10:12:52 +00:00
Gregory Tsipenyuk
56c9d1d497
fix: Add description for terLOCKED error ( #6811 )
2026-04-08 20:56:19 +00:00
yinyiqian1
d52dd29d20
fix: Address AI reviewer comments for Permission Delegation ( #6675 )
2026-04-08 20:22:19 +00:00
Mayukha Vadari
7793b5f10b
refactor: Combine AMMHelpers and AMMUtils ( #6733 )
2026-04-08 17:38:33 +00:00
Gregory Tsipenyuk
dfcad69155
feat: Add MPT support to DEX ( #5285 )
2026-04-08 16:17:37 +00:00
Pratik Mankawde
6d1a5be8d2
fix: Handle WSClient write failure when server closes WebSocket ( #6671 )
...
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com >
2026-04-07 19:15:40 +00:00
Ayaz Salikhov
b0fe2ec58a
ci: Change conditions for uploading artifacts in public/private/org repos ( #6734 )
2026-04-07 14:32:13 +00:00
Bart
c00ed673a8
refactor: Rename non-functional uses of ripple(d) to xrpl(d) ( #6676 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-04-07 13:00:17 +00:00
Mayukha Vadari
f239256d87
refactor: Move more helper files into libxrpl/ledger/helpers ( #6731 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-04-06 22:36:32 +00:00
Mayukha Vadari
00761dbb67
fix: Minor RPC fixes ( #6730 )
2026-04-06 22:15:16 +00:00
Zhiyuan Wang
077e03ff33
fix: Prevent deletion of MPTokens with active escrow ( #6635 )
...
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-04-06 17:51:46 +00:00
Vito Tumas
7d524a03b8
fix: Clamp VaultClawback to assetsAvailable for zero-amount clawback ( #6646 )
2026-04-06 15:13:03 +00:00
Vito Tumas
c0ee813666
fix: Add assorted Lending Protocol fixes ( #6678 )
...
Co-authored-by: Shawn Xie <35279399+shawnxie999@users.noreply.github.com >
2026-04-03 17:41:45 +00:00
Mayukha Vadari
8e05416211
fix: Change variable signedness and correctly handle std::optional ( #6657 )
2026-04-03 15:16:50 +00:00
Mayukha Vadari
81555d5456
refactor: Reorganize RPC handler files ( #6628 )
2026-04-02 23:46:17 +00:00
Ayaz Salikhov
6b55c4cdc8
chore: Update XRPLF/actions ( #6713 )
2026-04-02 21:34:20 +00:00
yinyiqian1
3414a1776b
docs: Add explanatory comment to checkFee ( #6631 )
2026-04-02 20:48:35 +00:00
yinyiqian1
6d9ed125f3
fix: Decouple reserve from fee in delegate payment ( #6568 )
2026-04-02 20:48:00 +00:00
Vito Tumas
02fa55df8d
fix: Check trustline limits for share-denominated vault withdrawals ( #6645 )
2026-04-01 19:31:45 +00:00
Ed Hennis
b4b47e80ba
Merge branch 'develop' into ximinez/loanpay-assertion
2026-04-01 13:39:09 -04:00
Valentin Balaschenko
6e2452207d
fix: Remove fatal assertion on Linux thread name truncation ( #6690 )
2026-04-01 16:56:45 +00:00
Alex Kremer
29e49abd3c
chore: Enable clang-tidy coreguidelines checks ( #6698 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-04-01 15:46:14 +00:00
Ed Hennis
c8e1d02dee
Merge branch 'develop' into ximinez/loanpay-assertion
2026-04-01 11:45:36 -04:00
Ayaz Salikhov
ae21f53e4d
ci: Allow uploading artifacts for XRPLF org ( #6702 )
2026-04-01 13:37:35 +00:00
Vito Tumas
bee1056faa
fix: Enforce aggregate MaximumAmount in multi-send MPT ( #6644 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-04-01 13:35:13 +00:00
Ayaz Salikhov
b6aa4a8fde
chore: Use nudb recipe from the upstream ( #6701 )
2026-04-01 10:33:02 +00:00
Ed Hennis
f68b3326df
Review feedback from @tapanito
...
- Return a default value in LoanPay balanceScale if the exponent list is
empty.
- Amendment gate the "roundedAmount" change in overpayment.
- Improve comments and logging.
documentation
2026-03-31 21:02:28 -04:00
Ed Hennis
da1cb2d7ce
Merge remote-tracking branch 'upstream/develop' into ximinez/loanpay-assertion
...
* upstream/develop: (149 commits)
fix: Fix previous ledger size typo in RCLConsensus (6696)
chore: Enable clang-tidy misc checks (6655)
ci: Use pull_request_target to check for signed commits (6697)
chore: Remove unnecessary clang-format off/on directives (6682)
fix: Fix Workers::stop() race between m_allPaused and m_runningTaskCount (6574)
ci: Only publish docs in public repos (6687)
chore: Enable remaining clang-tidy `performance` checks (6648)
refactor: Address PR comments after the modularisation PRs (6389)
chore: Fix clang-tidy header filter (6686)
ci: [DEPENDABOT] bump actions/deploy-pages from 4.0.5 to 5.0.0 (6684)
ci: [DEPENDABOT] bump codecov/codecov-action from 5.5.3 to 6.0.0 (6685)
fix: Guard Coro::resume() against completed coroutines (6608)
refactor: Split LoanInvariant into LoanBrokerInvariant and LoanInvariant (6674)
ci: Don't publish docs on release branches (6673)
refactor: Make function naming in ServiceRegistry consistent (6390)
chore: Shorten job names to stay within Linux 15-char thread limit (6669)
fix: Improve loan invariant message (6668)
ci: Upload artifacts only in public repositories (6670)
ci: Add conflicting-pr workflow (6656)
chore: Add more AI tools to .gitignore (6658)
...
2026-03-31 18:54:27 -04:00
Ed Hennis
0797a5d4db
Address an outdated TODO comment
2026-03-31 18:53:10 -04:00
Ed Hennis
d33ee7ed46
Merge commit '2c1fad1023' into HEAD
...
* commit '2c1fad1023':
chore: Apply clang-format width 100 (6387)
2026-03-31 18:53:02 -04:00
Ed Hennis
53183c71e8
Update formatting
2026-03-31 18:44:32 -04:00
Ed Hennis
05eaef5233
Merge commit '25cca465538a56cce501477f9e5e2c1c7ea2d84c' into HEAD
...
* commit '25cca465538a56cce501477f9e5e2c1c7ea2d84c': (22 commits)
chore: Set clang-format width to 100 in config file (6387)
chore: Set cmake-format width to 100 (6386)
ci: Add clang tidy workflow to ci (6369)
refactor: Modularize app/tx (6228)
refactor: Decouple app/tx from `Application` and `Config` (6227)
chore: Update clang-format to 21.1.8 (6352)
refactor: Modularize `HashRouter`, `Conditions`, and `OrderBookDB` (6226)
chore: Fix minor issues in comments (6346)
refactor: Modularize the NetworkOPs interface (6225)
chore: Fix `gcov` lib coverage build failure on macOS (6350)
refactor: Modularize RelationalDB (6224)
refactor: Modularize WalletDB and Manifest (6223)
fix: Update invariant checks for Permissioned Domains (6134)
refactor: Change main thread name to `xrpld-main` (6336)
refactor: Fix spelling issues in tests (6199)
test: Add file and line location to Env (6276)
chore: Remove CODEOWNERS (6337)
perf: Remove unnecessary caches (5439)
chore: Restore unity builds (6328)
refactor: Update secp256k1 to 0.7.1 (6331)
...
2026-03-31 18:42:49 -04:00
Ed Hennis
e44fc46ad0
Verify and log LoanPay fund conservation in all builds
...
- A warning will be logged if there's a mismatch.
2026-03-31 18:22:16 -04:00
Ed Hennis
3f8f5a081f
Review feedback from @tapanito: readability, duplicate checks
2026-03-31 18:22:16 -04:00
Mayukha Vadari
a9afd2c116
fix: Fix previous ledger size typo in RCLConsensus ( #6696 )
2026-03-31 19:56:30 +00:00
Alex Kremer
2502befb42
chore: Enable clang-tidy misc checks ( #6655 )
2026-03-31 17:29:45 +00:00