Ed Hennis
16f286553e
Merge branch 'ximinez/number-round-maxrep-down' into ximinez/number-round-maxrep
2026-06-30 12:35:23 -04:00
Ed Hennis
ea6f08d301
Merge branch 'develop' into ximinez/number-round-maxrep-down
2026-06-30 12:26:31 -04:00
Ayaz Salikhov
8abbd1ba3a
chore: Use std::ranges where possible ( #7634 )
2026-06-30 11:03:19 +00:00
Ed Hennis
93f59bd707
Merge branch 'ximinez/number-round-maxrep-down' into ximinez/number-round-maxrep
2026-06-29 19:47:41 -04:00
Ed Hennis
027c6f6e57
Merge branch 'develop' into ximinez/number-round-maxrep-down
2026-06-29 11:18:23 -04:00
Ed Hennis
c425c4ee0c
Merge branch 'ximinez/number-round-maxrep-down' into ximinez/number-round-maxrep
2026-06-29 11:14:47 -04:00
Ayaz Salikhov
74b55a59b2
chore: Enable most bugprone checks ( #7643 )
2026-06-29 13:20:17 +00:00
Shawn Xie
768d7603b1
feat: Confidential Transfer for MPT ( #5860 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: chuanshanjida <chuanshanjida@outlook.com >
Co-authored-by: Ed Hennis <ed@ripple.com >
Co-authored-by: Jingchen <a1q123456@users.noreply.github.com >
Co-authored-by: Denis Angell <dangell@transia.co >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
Co-authored-by: yinyiqian1 <yqian@ripple.com >
Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com >
Co-authored-by: Bronek Kozicki <brok@incorrekt.com >
Co-authored-by: Mayukha Vadari <mvadari@ripple.com >
Co-authored-by: Valentin Balaschenko <13349202+vlntb@users.noreply.github.com >
Co-authored-by: tequ <git@tequ.dev >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
Co-authored-by: Peter Chen <34582813+PeterChen13579@users.noreply.github.com >
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
Co-authored-by: Zhiyuan Wang <96991820+Kassaking7@users.noreply.github.com >
Co-authored-by: Alex Kremer <akremer@ripple.com >
Co-authored-by: Sergey Kuznetsov <skuznetsov@ripple.com >
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Gregory Tsipenyuk <gregtatcam@users.noreply.github.com >
Co-authored-by: chuanshanjida <chuanshanjida@outlook.com >
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
Co-authored-by: Peter Chen <ychen@ripple.com >
Co-authored-by: Timothy Banks <timothyaaronbanks@gmail.com >
Co-authored-by: Timothy Banks <tbanks@ripple.com >
2026-06-27 01:20:38 +00:00
yinyiqian1
fd8a915243
fix: Use trustline balance direction to validate IOU PaymentMint/PaymentBurn ( #7584 )
2026-06-26 22:26:53 +00:00
Ed Hennis
394ea6b69c
Merge branch 'develop' into ximinez/number-round-maxrep-down
2026-06-26 18:03:40 -04:00
Vito Tumas
3e9f1d0ab8
fix: Unify freeze checks for pseudo-account deposit/withdraw ( #7382 )
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
Co-authored-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
Co-authored-by: Shawn Xie <35279399+shawnxie999@users.noreply.github.com >
2026-06-26 21:38:59 +00:00
Ed Hennis
4a1851ab47
Review feedback from @gregtatcam and AI
...
- Simplify the before and after comparison in numberFromJson
- Update tests
2026-06-26 17:37:24 -04:00
yinyiqian1
652b5f9af1
fix: Block delegate tx from being queued ( #7640 )
2026-06-26 20:34:22 +00:00
Ed Hennis
78c5471af6
Review feedback: STNumber parsing
...
- In numberFromJson(), if the result is 0, only the mantissa has to
match, because there are many valid ways to represent 0.
- Update several broken tests that I missed earlier.
2026-06-26 14:08:53 -04:00
Ed Hennis
573bf2abe3
fixup! One more test case to show that big integers don't include "e0"
2026-06-26 10:36:00 -04:00
Timothy Banks
2ab43b6fda
refactor: Retire NFTokenReserve fix ( #7367 )
2026-06-26 10:31:16 +00:00
Timothy Banks
12a5d9014e
refactor: Retire Clawback amendment ( #7353 )
2026-06-26 10:24:25 +00:00
Mayukha Vadari
b9eee1d245
refactor: Rename (mostly keylet) functions to more closely match the docs ( #7059 )
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2026-06-26 10:24:12 +00:00
Ed Hennis
24ab150bdf
One more test case to show that big integers don't include "e0"
2026-06-25 22:43:07 -04:00
Ed Hennis
f730af6e05
Review feedback from @gregtatcam: json string number parsing
...
- Change the parsing in numberFromJson so that if the resulting Number
is not the same as the parsed NumberParts, then throw, because
unexpected rounding occurred
- Add modified suggested test cases, and modify some existing ones,
which test this behavior.
2026-06-25 22:35:25 -04:00
Ed Hennis
cc4c06cf86
Address AI review feedback: mantissa assertion, test resiliency
...
- Move code around and add comments in `bringIntoRange` to make it
clearer that mantissas should not be 0, but fall back gracefully in
non-debug builds if they are.
- Make a test that checks for Large330 future-proof if more scales are
added later.
2026-06-25 14:26:59 -04:00
Ed Hennis
6906f47349
Apply suggestions from AI code review: typos
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-06-25 14:25:32 -04:00
Ed Hennis
d2c5d95032
Merge branch 'ximinez/number-round-maxrep-down' into ximinez/number-round-maxrep
2026-06-25 11:43:34 -04:00
Ed Hennis
6aa9031848
Merge branch 'develop' into ximinez/number-round-maxrep-down
2026-06-25 11:43:30 -04:00
Ayaz Salikhov
eef8f4a4ff
chore: Use clang-tidy v22 new features ( #7427 )
2026-06-24 17:23:29 +00:00
Mayukha Vadari
6736ab39df
test: Add test for Permissioned Domain sequence fix ( #7591 )
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-06-24 12:24:27 +00:00
Ayaz Salikhov
b68e1f7170
fix: Add pragma once checker ( #7580 )
2026-06-24 12:24:04 +00:00
Timothy Banks
bb7c4d1c9f
fix: Additional RPC validation checks on ammRpcInfo account and amm_account fields. ( #7324 )
2026-06-24 12:23:12 +00:00
Zhiyuan Wang
69d289a388
fix: AMM Quality Leak into Domain BookStep for Permissioned DEX ( #6853 )
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-06-24 12:15:45 +00:00
Jingchen
6341e75200
refactor: Refactor TaggedCache.ipp to remove const_cast in canonicalize_replace_cache ( #5638 )
...
Signed-off-by: JCW <a1q123456@users.noreply.github.com >
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-06-24 12:15:11 +00:00
yinyiqian1
5a2c82f699
fix: Reject delegate permission to pseudo accounts ( #7597 )
2026-06-23 19:55:23 +00:00
Ed Hennis
f3849fc2d2
Merge branch 'ximinez/number-round-maxrep-down' into ximinez/number-round-maxrep
2026-06-22 16:42:02 -04:00
Ed Hennis
2c074d03c7
Merge branch 'develop' into ximinez/number-round-maxrep-down
2026-06-22 16:41:58 -04:00
Mayukha Vadari
dd7401fde2
refactor: Clean up tec object deletion logic ( #6588 )
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2026-06-22 18:44:42 +00:00
Zhiyuan Wang
19a9ed7767
fix: Move AMMInvariant weakInvariantCheck logic into the transaction ( #7032 )
2026-06-22 18:42:57 +00:00
Zhiyuan Wang
93eab33dc2
fix: Improve ValidAMM invariant ( #7295 )
2026-06-22 17:45:42 +00:00
yinyiqian1
997267f845
feat: Remove clear mutable flags for DynamicMPT XLS-94 ( #7439 )
2026-06-22 17:36:06 +00:00
Ed Hennis
aadf3c66c9
Remove some overly verbose unit test log messages.
2026-06-18 21:05:03 -04:00
Ed Hennis
7cb224e50f
Update some comments, and const correctness
2026-06-18 20:59:20 -04:00
Ed Hennis
da396070ce
Address review feedback from @TimothyBanks and @gregtatcam
...
- Remove unnecessary if constexpr check
- Update scaling static_assert
- Remove unnecessary rounding logic from Number::Guard::doRound()
- Handle fractional rounding between kMaxRep and kMaxRepUp
2026-06-18 17:57:21 -04:00
Ed Hennis
39d85076c4
Merge branch 'ximinez/number-round-maxrep-down' into ximinez/number-round-maxrep
2026-06-17 21:50:55 -04:00
Ed Hennis
14a43cfc35
Merge branch 'develop' into ximinez/number-round-maxrep-down
2026-06-17 21:46:24 -04:00
yinyiqian1
772ea80a25
fix: Use template for granular delegation permissions ( #6613 )
...
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-06-17 23:20:54 +00:00
Ed Hennis
069fc99b6a
Merge branch 'ximinez/number-round-maxrep-down' into ximinez/number-round-maxrep
2026-06-17 15:01:40 -04:00
Ed Hennis
cebd4ecf15
Merge branch 'develop' into ximinez/number-round-maxrep-down
2026-06-17 15:01:35 -04:00
Pratik Mankawde
cccce1c32e
Merge remote-tracking branch 'origin/release/3.2.x' into pratik/merge_3.2.x
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-17 12:53:02 +01:00
Ed Hennis
e5785c4fcb
fix: Fix Number comparison operator
2026-06-15 22:24:02 +01:00
yinyiqian1
fded06652a
fix: Add zero NFT Offer ID check for NFTokenCancelOffer
2026-06-15 22:24:02 +01:00
Sergey Kuznetsov
47b06ecd17
refactor: Use rocksdb includes only when it is available
2026-06-15 22:23:54 +01:00
Sergey Kuznetsov
e29dc474b3
refactor: Improve payment channel closing and returned error codes
2026-06-15 22:23:28 +01:00