Pratik Mankawde
b9f0a3ae19
Merge branch 'pratik/otel-phase1a-plan-docs' into pratik/otel-phase1b-telemetry-infra
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-12 20:21:52 +01:00
Pratik Mankawde
df395d6851
test: Add null check unit test for Oracle::aggregatePrice ( #7306 )
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-11 18:05:36 +00:00
Pratik Mankawde
e9cb9421ef
Merge branch 'pratik/otel-phase1a-plan-docs' into pratik/otel-phase1b-telemetry-infra
...
Bring the span attribute naming convention (phase 1a) into phase 1b.
Conflict resolution kept phase-1b's SpanGuard-based workflow and applied
the underscore naming convention to all non-code-sample text:
- Converted prose, tables, Mermaid labels, and TraceQL/PromQL query
references across the plan docs to the underscore form.
- Converted the two @code attribute-key examples in Telemetry.h
(command, tx_type).
- Left the code-sample files (04-code-samples.md, POC_taskList.md) and
03-implementation-strategy.md code blocks at the phase-1b version; the
code-sample docs are slated for removal on phase-1a.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com >
2026-06-11 14:10:52 +01:00
Zhiyuan Wang
09c36d066e
fix: Correct hybrid offer deletion on credential expiry ( #6843 )
...
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-06-10 20:42:41 +00:00
Shi Cheng
1f359f719c
fix: Add [[maybe_unused]] to fix320Enabled for assert=OFF builds ( #7446 )
...
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com >
2026-06-10 17:24:44 +00:00
Pratik Mankawde
e205d0ef8e
handle gTlDiscardCurrentSpan change
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-10 14:00:52 +01:00
Vito Tumas
83cc5df72e
fix: Disable transaction invariants ( #7409 )
2026-06-10 12:05:53 +00:00
Vito Tumas
97ca7d57bc
perf: Dispatch "hasInvalidAmount()" on type tag instead of dynamic_cast ( #7402 )
2026-06-10 11:44:57 +00:00
Pratik Mankawde
8a4bf2dee6
refactor: Retire fixUniversalNumber amendment ( #5962 )
...
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com >
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
2026-06-10 10:16:03 +00:00
Pratik Mankawde
e11bf35691
fix: Update BasicConfig.h include path after upstream reorg
...
BasicConfig.h moved from xrpl/basics/ to xrpl/config/ on develop
(PR #7095 / reorg). Phase 1b's telemetry headers still referenced the
old path, breaking a fresh compile with "BasicConfig.h: No such file or
directory". Point both telemetry includes at the new location.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com >
2026-06-10 10:42:52 +01:00
Bart
742aa0878b
test: Do not create data directory for memory databases ( #7323 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-06-10 09:16:53 +00:00
Pratik Mankawde
848cbcbfbe
Merge branch 'pratik/otel-phase1a-plan-docs' into pratik/otel-phase1b-telemetry-infra
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-10 10:15:31 +01:00
Pratik Mankawde
c712968890
removed non-accessible include
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-09 18:49:17 +01:00
Ed Hennis
2cbc3c139e
fix: Fix Number comparison operator ( #7406 )
2026-06-09 17:46:56 +00:00
Pratik Mankawde
fa71280795
removed head sampling ratio from config
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-09 18:45:52 +01:00
Ayaz Salikhov
fccb109e48
feat: Use C++ 23 standard ( #7431 )
2026-06-09 17:36:17 +00:00
Vito Tumas
0fb1aca461
refactor: Introduce XRPL_ASSERT_IF for amendment-gated assertions ( #7378 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-06-09 17:02:06 +00:00
Bart
c552eb333f
refactor: Change config section and key string literals into constants ( #7095 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-06-09 14:58:21 +00:00
Bart
c9769d1add
refactor: Use std::move and std::string_view where possible ( #7424 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-06-09 13:56:32 +00:00
Pratik Mankawde
a946ce7458
feat(telemetry): enable peer tracing by default
...
Flip the tracePeer Setup default and the trace_peer config parser
default from off to on, and update the example config and build doc to
match. Peer spans record only peer_id (a node-local numeric connection
id) plus trust/ledger metadata — no IP addresses or public keys — so
the privacy concern behind disabling it does not apply. The high-volume
characteristic is retained in the docs.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-09 13:43:32 +01:00
Pratik Mankawde
57a54ad0fe
Merge branch 'pratik/otel-phase1a-plan-docs' into pratik/otel-phase1b-telemetry-infra
2026-06-09 13:34:58 +01:00
Bart
ee9fbc4e08
refactor: Use const function arguments where possible ( #7423 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-06-09 10:04:09 +00:00
Ayaz Salikhov
a389f922dd
ci: Use new packaging images and don't cancel develop builds ( #7417 )
...
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-06-08 13:41:08 +00:00
Ayaz Salikhov
949887feb9
build: Create single test binary xrpl_tests ( #7327 )
2026-06-05 19:24:32 +00:00
Ayaz Salikhov
2111bb4b95
ci: Update clang-tidy to nix-based v22 ( #7412 )
2026-06-05 14:11:47 +00:00
Ayaz Salikhov
5b8e6cd1dd
test: Fix LCOV_EXCL_END -> LCOV_EXCL_STOP ( #7407 )
2026-06-04 19:35:36 +00:00
yinyiqian1
e5cf1a0985
fix: Add zero NFT Offer ID check for NFTokenCancelOffer ( #7391 )
2026-06-03 19:30:20 +00:00
Bart
96b2c0964f
refactor: Replace intr_ptr::SharedPtr<SHAMapTreeNode> by SHAMapTreeNodePtr ( #7396 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-06-03 15:34:19 +00:00
Vito Tumas
225ed204ad
test: Suppress invariant-failure logs in Vault and LoanBroker bug-regression tests ( #7379 )
2026-06-02 17:12:09 +00:00
Vito Tumas
109b649106
refactor: Use STLedgerEntry type aliases instead of std::shared_ptr ( #7282 )
2026-06-01 15:27:13 +00:00
Pratik Mankawde
9918803333
clang tidy fixes
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-01 13:18:27 +01:00
Pratik Mankawde
bf527a41dd
Merge branch 'pratik/otel-phase1a-plan-docs' into pratik/otel-phase1b-telemetry-infra
2026-06-01 12:33:03 +01:00
Bart
7e15621e7b
release: Bump version to 3.2.0-rc3 ( #7371 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-05-31 22:55:18 +00:00
Vito Tumas
99431d7833
fix: Pin overpayment principal reduction to exact on-grid value ( #7360 )
2026-05-31 22:54:23 +00:00
Ed Hennis
47365f4220
fix: Improve upward rounding edge cases for Number::operator/= ( #7328 )
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com >
2026-05-31 00:23:29 +00:00
Bart
1599c1a672
refactor: Revert "perf: Remove unnecessary caches ( #5439 )" ( #7359 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-05-30 18:48:59 +00:00
yinyiqian1
763dd503be
fix: Add zero domainID check for permissionedDomain ( #7362 )
2026-05-30 00:16:25 +00:00
Pratik Mankawde
c157253372
activate telemetry by default and fix clang-tidy issues.
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-05-29 18:51:47 +01:00
Pratik Mankawde
f031befc6e
compilation fixes and levelization fixes
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-05-29 16:04:19 +01:00
Pratik Mankawde
4e8d37facf
another fix
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-05-29 15:55:11 +01:00
Pratik Mankawde
071ad45d31
otel version update issue fixes
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-05-29 15:54:07 +01:00
Pratik Mankawde
3a1f22583f
Merge branch 'pratik/otel-phase1a-plan-docs' into pratik/otel-phase1b-telemetry-infra
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-05-29 15:34:22 +01:00
Pratik Mankawde
68a69d9064
updated as per latest clang-tidy
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-05-29 14:50:24 +01:00
Bart
1acc42313c
release: Bump version to 3.2.0-rc2 ( #7348 )
2026-05-27 15:11:38 -04:00
Ayaz Salikhov
1438bf1c67
release: Bump version to 3.2.0-rc1 ( #7335 )
2026-05-27 13:20:57 -04:00
Pratik Mankawde
a104140a51
addressing code review comments
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-05-27 16:46:35 +01:00
Ed Hennis
7da643d864
fix: Fix a rounding error at the Number::maxRep cusp ( #7051 )
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com >
2026-05-27 15:19:20 +00:00
Andrzej Budzanowski
85af406a0f
fix: Update clang-tidy to include src/tests directory header check ( #7307 )
2026-05-26 19:35:32 +00:00
Vito Tumas
49567e7283
fix: Fix edge-case where vault-depositor may get stuck ( #7139 )
2026-05-26 18:18:40 +00:00
Vito Tumas
633ef4706f
fix: Fix VaultInvariant and VaultDeposit precision bugs at IOU scale boundaries ( #7272 )
...
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-05-26 16:32:44 +00:00