Alex Kremer
653a383ff5
chore: Enable clang-tidy include cleaner ( #6947 )
2026-04-17 16:43:49 +00:00
Gregory Tsipenyuk
affe5835fe
fix: Change AMMClawback return code to tecNO_PERMISSION ( #6946 )
2026-04-17 14:19:58 +00:00
Alex Kremer
f1a5ba43ad
chore: Enable clang-tidy readability checks ( #6930 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-04-17 13:30:52 +00:00
Jingchen
4a73be499d
fix: Fix unity build for book step ( #6942 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-04-16 17:12:00 +00:00
Sergey Kuznetsov
d52d735543
chore: Move codegen venv setup into build stage ( #6617 )
...
Co-authored-by: JCW <a1q123456@users.noreply.github.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-04-15 18:50:49 +00:00
Alex Kremer
6a0ce46755
chore: Enable most clang-tidy bugprone checks ( #6929 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-04-14 20:24:21 +00:00
Bart
2f029a2120
refactor: Improve exception handling ( #6540 ) ( #6735 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-04-14 17:14:24 +00:00
Zhiyuan Wang
61fbde3a71
refactor: Remove unused notTooManyOffers function from NFTokenUtils ( #6737 )
2026-04-13 23:18:10 +00:00
Bart
e2e537b3bb
fix: Change Tuning::bookOffers minimum limit to 1 ( #6812 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-04-10 14:38:46 +00:00
Gregory Tsipenyuk
56c9d1d497
fix: Add description for terLOCKED error ( #6811 )
2026-04-08 20:56:19 +00:00
yinyiqian1
d52dd29d20
fix: Address AI reviewer comments for Permission Delegation ( #6675 )
2026-04-08 20:22:19 +00:00
Mayukha Vadari
7793b5f10b
refactor: Combine AMMHelpers and AMMUtils ( #6733 )
2026-04-08 17:38:33 +00:00
Gregory Tsipenyuk
dfcad69155
feat: Add MPT support to DEX ( #5285 )
2026-04-08 16:17:37 +00:00
Pratik Mankawde
6d1a5be8d2
fix: Handle WSClient write failure when server closes WebSocket ( #6671 )
...
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com >
2026-04-07 19:15:40 +00:00
Bart
c00ed673a8
refactor: Rename non-functional uses of ripple(d) to xrpl(d) ( #6676 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-04-07 13:00:17 +00:00
Mayukha Vadari
f239256d87
refactor: Move more helper files into libxrpl/ledger/helpers ( #6731 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-04-06 22:36:32 +00:00
Mayukha Vadari
00761dbb67
fix: Minor RPC fixes ( #6730 )
2026-04-06 22:15:16 +00:00
Zhiyuan Wang
077e03ff33
fix: Prevent deletion of MPTokens with active escrow ( #6635 )
...
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-04-06 17:51:46 +00:00
Vito Tumas
7d524a03b8
fix: Clamp VaultClawback to assetsAvailable for zero-amount clawback ( #6646 )
2026-04-06 15:13:03 +00:00
Vito Tumas
c0ee813666
fix: Add assorted Lending Protocol fixes ( #6678 )
...
Co-authored-by: Shawn Xie <35279399+shawnxie999@users.noreply.github.com >
2026-04-03 17:41:45 +00:00
Mayukha Vadari
8e05416211
fix: Change variable signedness and correctly handle std::optional ( #6657 )
2026-04-03 15:16:50 +00:00
Mayukha Vadari
81555d5456
refactor: Reorganize RPC handler files ( #6628 )
2026-04-02 23:46:17 +00:00
yinyiqian1
3414a1776b
docs: Add explanatory comment to checkFee ( #6631 )
2026-04-02 20:48:35 +00:00
yinyiqian1
6d9ed125f3
fix: Decouple reserve from fee in delegate payment ( #6568 )
2026-04-02 20:48:00 +00:00
Vito Tumas
02fa55df8d
fix: Check trustline limits for share-denominated vault withdrawals ( #6645 )
2026-04-01 19:31:45 +00:00
Valentin Balaschenko
6e2452207d
fix: Remove fatal assertion on Linux thread name truncation ( #6690 )
2026-04-01 16:56:45 +00:00
Alex Kremer
29e49abd3c
chore: Enable clang-tidy coreguidelines checks ( #6698 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-04-01 15:46:14 +00:00
Vito Tumas
bee1056faa
fix: Enforce aggregate MaximumAmount in multi-send MPT ( #6644 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-04-01 13:35:13 +00:00
Pratik Mankawde
fdec3ce5c4
Phase 8: Log-trace correlation with Loki and filelog receiver
...
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-03-31 22:31:37 +01:00
Pratik Mankawde
eca887c66e
feat(telemetry): add 7-day validation agreement window to ValidationTracker
...
Add window7d_ deque, agreementPct7d(), agreements7d(), missed7d() to
match the external xrpl-validator-dashboard's 7-day agreement tracking.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
2026-03-31 22:31:24 +01:00
Pratik Mankawde
f51976f63e
test(telemetry): add ValidationTracker unit tests
...
Cover normal agreement, missed validation, late repair, empty window,
grace period boundary, max pending trimming, mixed results, duplicate
recording, and only-we-validated scenarios.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
2026-03-31 22:31:24 +01:00
Pratik Mankawde
1f2a36b316
fix(telemetry): fix ValidationTracker grace period boundary and hard trim
...
- Use >= instead of > for grace period comparison to reconcile at exactly
8 seconds rather than skipping the boundary
- Two-pass hard trim: first remove entries past late-repair window, then
any reconciled entry, to avoid sabotaging late repairs
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
2026-03-31 22:31:24 +01:00
Pratik Mankawde
8365f7dda3
feat(telemetry): add ValidationTracker for validation agreement tracking (Task 7.8)
...
Standalone class that tracks whether this validator's validations agree
with network consensus, maintaining rolling 1h/24h windows and lifetime
totals with a late-repair mechanism for out-of-order arrivals.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
2026-03-31 22:31:24 +01:00
Pratik Mankawde
2f7064ace6
Phase 7: Native OTel metrics migration
...
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-03-31 22:31:24 +01:00
Pratik Mankawde
2a2c9dc5dc
fix: remove non-existent CanonicalTXSet.h include from BuildLedger.cpp
...
The xrpld/app/misc/CanonicalTXSet.h header doesn't exist — it was
incorrectly added during a rebase conflict resolution. The correct
include xrpl/ledger/CanonicalTXSet.h is already present.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
2026-03-31 22:30:59 +01:00
Pratik Mankawde
6723815563
feat(telemetry): add validation attributes to peer.validation.receive span (Task 4.8)
...
Add ledger hash and full-validation flag to peer.validation.receive
spans for trace-level agreement analysis across validators.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
2026-03-31 22:30:59 +01:00
Pratik Mankawde
7e5591318f
Phase 5b: Ledger, peer, and tx spans with expanded Grafana dashboards
...
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-03-31 22:30:59 +01:00
Pratik Mankawde
f940290866
Phase 5: Documentation, deployment configs, integration test infrastructure
...
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-03-31 22:29:30 +01:00
Pratik Mankawde
014060370a
fix(telemetry): move quorum/proposers attributes to consensus.accept span
...
Move validation_quorum and proposers_validated attributes from
consensus.accept.apply to consensus.accept span to match the design
spec. Both values are available in onAccept() scope.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
2026-03-31 22:28:33 +01:00
Pratik Mankawde
8c222b9e05
feat(telemetry): add consensus validation span enrichment (Task 4.8)
...
Add validation ledger hash and full-validation flag to
consensus.validation.send spans, plus quorum and proposer count to
consensus.accept spans for trace-level agreement analysis.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
2026-03-31 22:28:33 +01:00
Pratik Mankawde
a127711b86
Phase 4: Consensus tracing - round lifecycle, proposals, validations, close time
...
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-03-31 22:28:33 +01:00
Pratik Mankawde
715c531512
feat(telemetry): add peer version attribute to tx.receive spans (Task 3.7)
...
Tag transaction receive spans with the relaying peer's rippled version
to enable version-mismatch correlation during network upgrades.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
2026-03-31 22:28:27 +01:00
Pratik Mankawde
88d17e4c04
Phase 3: Transaction tracing - protobuf context propagation, PeerImp, NetworkOPs
...
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-03-31 22:28:27 +01:00
Pratik Mankawde
8f2507a945
feat(telemetry): add node health attributes to RPC spans (Task 2.8)
...
Add amendment_blocked and server_state span attributes to every
rpc.command.* span so operators can correlate RPC behavior with node state.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
2026-03-31 22:28:22 +01:00
Pratik Mankawde
945faac770
Phase 2: RPC tracing - span macros, attributes, WebSocket, command spans
...
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-03-31 22:28:22 +01:00
Pratik Mankawde
012e453997
Phase 1c: RPC integration - ServerHandler tracing, telemetry config wiring
...
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-03-31 22:28:17 +01:00
Pratik Mankawde
a7470615be
Phase 1b: Telemetry core infrastructure - CMake, Conan, SpanGuard, config
...
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-03-31 22:28:12 +01:00
Mayukha Vadari
a9afd2c116
fix: Fix previous ledger size typo in RCLConsensus ( #6696 )
2026-03-31 19:56:30 +00:00
Alex Kremer
2502befb42
chore: Enable clang-tidy misc checks ( #6655 )
2026-03-31 17:29:45 +00:00
Bart
7f53351920
chore: Remove unnecessary clang-format off/on directives ( #6682 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-03-31 15:38:04 +00:00