Pratik Mankawde
5ce2bad4a9
Merge branch 'pratik/otel-phase8-log-correlation' into pratik/otel-phase9-metric-gap-fill
...
# Conflicts:
# .cspell.config.yaml
# src/tests/libxrpl/nodestore/NuDBFactory.cpp
2026-08-20 12:14:58 +01:00
Copilot
820ca5b332
refactor: Convert boost::beast::string_view to std::string_view ( #6306 )
...
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com >
Co-authored-by: mvadari <8029314+mvadari@users.noreply.github.com >
Co-authored-by: Mayukha Vadari <mvadari@ripple.com >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
Co-authored-by: Mayukha Vadari <mvadari@gmail.com >
Co-authored-by: Timur Yalymov <36795566+tyalymov@users.noreply.github.com >
Co-authored-by: Cursor <cursoragent@cursor.com >
Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com >
2026-08-17 23:19:56 +00:00
Mayukha Vadari
d34aa37b3c
refactor: Use std::format instead of boost::format where it fits ( #7996 )
...
Co-authored-by: Timur Yalymov <36795566+tyalymov@users.noreply.github.com >
Co-authored-by: Cursor <cursoragent@cursor.com >
Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-08-14 13:49:08 +00:00
Copilot
153b7839a7
refactor: Replace boost::filesystem with std::filesystem across the codebase ( #7012 )
...
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com >
Co-authored-by: mvadari <8029314+mvadari@users.noreply.github.com >
Co-authored-by: Mayukha Vadari <mvadari@ripple.com >
Co-authored-by: Mayukha Vadari <mvadari@gmail.com >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
Co-authored-by: mathbunnyru <12270691+mathbunnyru@users.noreply.github.com >
2026-08-12 13:40:39 +00:00
Mayukha Vadari
a0e1e578a0
refactor: Remove operator!= overloads that C++20 synthesizes ( #7994 )
2026-08-10 17:23:02 +00:00
Ayaz Salikhov
9859e5ceda
Merge remote-tracking branch 'upstream/release/3.3.x' into mathbunnyru/merge-3.3.0-to-develop
...
* upstream/release/3.3.x: (41 commits)
chore: Bump version to 3.3.0
chore: Bump version to 3.3.0-rc7
fix: Increase manifest protocol message size cap and fix manifests relay
fix: Cap untrusted manifests per message and drop oversized ones
chore: Bump version to 3.2.1
chore: Bump version to 3.2.1-rc1
fix: Cap untrusted manifests per message and drop oversized ones
fix: Reject oversized validator manifest before decoding
fix: Reduce untrusted manifest cache cap to 100
fix: Bound untrusted manifest cache
chore: Bump version to 3.3.0-rc6
feat: Package validator-keys inside rippled
chore: Bump version to 3.3.0-rc5
fix: Switch SponsorshipSet to use a delta for sfFeeAmount
fix: Re-revert "fix: Set request size limits and differential pricing for get-object-by-hash calls"
chore: Bump version to 3.3.0-rc4
fix: Revert "fix: Set request size limits and differential pricing for get-object-by-hash calls"
chore: Bump version to 3.3.0-rc3
fix: Reduce untrusted manifest cache cap to 100
fix: Revert "fix: Reject oversized SHAMap nodes in gotStaleData and fetch-pack path"
...
2026-08-07 16:00:25 +01:00
Pratik Mankawde
5ed32063f5
Merge branch 'pratik/otel-phase8-log-correlation' into pratik/otel-phase9-metric-gap-fill
...
Resolve conflicts by keeping phase-9's getobject_* metric instrumentation
and applying develop's snake_case namespace rename (#7933 ) to it:
Resource:: -> resource::, Tuning:: -> tuning::, BuildInfo:: -> build_info::.
2026-08-05 15:54:33 +01:00
Pratik Mankawde
54cfdda00b
fix: Increase manifest protocol message size cap and fix manifests relay
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-08-04 17:08:43 -04:00
Alex Kremer
06488c1318
chore: Rename CamelCase namespaces to snake_case ( #7933 )
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-08-04 13:46:55 +00:00
Pratik Mankawde
8461ded0d8
fix: Cap untrusted manifests per message and drop oversized ones
2026-08-03 12:00:11 -04:00
Pratik Mankawde
c50edf507c
fix: Reduce untrusted manifest cache cap to 100
2026-07-23 16:27:45 -04:00
Pratik Mankawde
30b0d2677a
Merge branch 'pratik/otel-phase8-log-correlation' into pratik/otel-phase9-metric-gap-fill
...
# Conflicts:
# src/xrpld/telemetry/ValidationTracker.h
2026-07-20 17:57:08 +01:00
Pratik Mankawde
de49319b31
Merge branch 'pratik/otel-phase8-log-correlation' into pratik/otel-phase9-metric-gap-fill
2026-07-20 12:19:45 +01:00
Pratik Mankawde
68a765d929
fix: Bound untrusted manifest cache
2026-07-17 14:07:57 -04:00
Bart
7877ee42a0
fix: Reject oversized validator manifest before decoding
2026-07-16 16:33:03 -04:00
Bart
1dcaf4b54e
fix: Bound and offload per-connection subscription cleanup
2026-07-16 16:33:03 -04:00
Ayaz Salikhov
73b6852a12
style: Unify style for all Doxygen comments ( #7776 )
2026-07-13 10:40:40 +00:00
Pratik Mankawde
15f9c66dcf
fix(telemetry): address phase-9 metric gap-fill review comments
...
- PerfLogImp::rpcEnd(): return after the requestId-not-found UNREACHABLE
so a stale (now - epoch) duration is no longer recorded to the counter
and histogram in release builds.
- MetricsRegistry peer-version gauge: compare versions numerically via
BuildInfo::encodeSoftwareVersion() instead of a lexicographic string
compare, stripping the non-digit prefix so peer 'rippled-X.Y.Z' lines
up with our bare 'X.Y.Z'. Fixes every peer counting as higher-version.
- MetricsRegistry::stop(): call Shutdown() before ForceFlush() before
reset() so the reader thread stops before teardown and no gauge
callback fires during shutdown.
- MetricsRegistry::start(): extract initExporterAndProvider() and
initSyncInstruments() helpers to keep each function under the line
limit; no behavior change.
- time_in_current_state_seconds: read NetworkOPs::getServerStateDurationUs()
(a lightweight accessor over StateAccounting) and convert microseconds
to seconds, replacing the hardcoded 0.0.
2026-07-07 20:47:05 +01:00
Ayaz Salikhov
53649cc298
chore: Enable modernize-use-constraints ( #7715 )
2026-07-03 14:28:15 +00:00
Ayaz Salikhov
f151293e8a
chore: Enable modernize-avoid-bind ( #7711 )
2026-07-03 11:17:03 +00:00
Ayaz Salikhov
8e378c4f47
build: Add verify-headers target to cleanup headers ( #7670 )
2026-07-01 23:14:17 +00:00
Pratik Mankawde
cccce1c32e
Merge remote-tracking branch 'origin/release/3.2.x' into pratik/merge_3.2.x
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-17 12:53:02 +01:00
Pratik Mankawde
f98c251011
refactor: Improve tracking of book (un)subscriptions
2026-06-15 22:23:38 +01:00
Bart
c552eb333f
refactor: Change config section and key string literals into constants ( #7095 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-06-09 14:58:21 +00:00
Bart
c9769d1add
refactor: Use std::move and std::string_view where possible ( #7424 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-06-09 13:56:32 +00:00
Valentin Balaschenko
30de556224
fix: Address review feedback on FD/handle guarding ( #5823 follow-up) ( #7310 )
2026-05-23 14:48:48 +00:00
Vito Tumas
e24de65f42
chore: Revert graceful peer disconnection and follow-up fix ( #7296 )
2026-05-21 16:13:41 +00:00
Alex Kremer
a830ab10ef
style: More clang-tidy identifier renaming ( #7290 )
2026-05-20 21:31:15 +00:00
Alex Kremer
5b6e8b6f93
refactor: Rename static constants ( #7120 )
...
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-05-15 15:32:19 +00:00
Alex Kremer
cdee9a675c
refactor: Use more scoped enums ( #7086 )
2026-05-11 15:39:48 +00:00
Alex Kremer
7afdd71a54
chore: More fixes for bad renames ( #7092 )
2026-05-07 17:04:30 +00:00
Alex Kremer
8995564ed6
refactor: Enable clang-tidy readability-identifier-naming check ( #6571 )
2026-05-03 10:31:53 +00:00
Alex Kremer
f7275b7ad9
chore: Enable clang-tidy v21 new checks ( #7031 )
2026-04-29 15:17:35 +00:00
Alex Kremer
4dc923dcc5
chore: Enable clang-tidy modernize-use-nodiscard check ( #7015 )
2026-04-24 17:19:30 +00:00
Alex Kremer
ce3951bbb3
chore: Enable clang-tidy modernize checks ( #6975 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-04-21 15:32:51 +00:00
Alex Kremer
f1a5ba43ad
chore: Enable clang-tidy readability checks ( #6930 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-04-17 13:30:52 +00:00
Alex Kremer
6a0ce46755
chore: Enable most clang-tidy bugprone checks ( #6929 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-04-14 20:24:21 +00:00
Bart
c00ed673a8
refactor: Rename non-functional uses of ripple(d) to xrpl(d) ( #6676 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-04-07 13:00:17 +00:00
Alex Kremer
29e49abd3c
chore: Enable clang-tidy coreguidelines checks ( #6698 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-04-01 15:46:14 +00:00
Alex Kremer
2502befb42
chore: Enable clang-tidy misc checks ( #6655 )
2026-03-31 17:29:45 +00:00
Alex Kremer
57e4cbbcd9
refactor: Add simple clang-tidy readability checks ( #6556 )
...
This change enables the following clang-tidy checks:
- readability-avoid-nested-conditional-operator,
- readability-avoid-return-with-void-value,
- readability-braces-around-statements,
- readability-const-return-type,
- readability-container-contains,
- readability-container-size-empty,
- readability-else-after-return,
- readability-make-member-function-const,
- readability-redundant-casting,
- readability-redundant-inline-specifier,
- readability-redundant-member-init,
- readability-redundant-string-init,
- readability-reference-to-constructed-temporary,
- readability-static-definition
2026-03-18 16:41:49 +00:00
Ayaz Salikhov
2c1fad1023
chore: Apply clang-format width 100 ( #6387 )
2026-02-19 23:30:00 +00:00
Jingchen
0976b2b68b
refactor: Modularize app/tx ( #6228 )
2026-02-17 18:10:07 +00:00
Sergey Kuznetsov
958d8f3754
chore: Update clang-format to 21.1.8 ( #6352 )
2026-02-16 14:31:18 -05:00
Jingchen
ac0ad3627f
refactor: Modularize HashRouter, Conditions, and OrderBookDB ( #6226 )
...
This change modularizes additional components by moving code to `libxrpl`.
2026-02-13 10:34:37 -05:00
Jingchen
5edd3566f7
refactor: Modularize the NetworkOPs interface ( #6225 )
...
This change moves the NetworkOPs interface into `libxrpl` and it leaves its implementation in `xrpld`.
2026-02-12 13:15:03 -05:00
Jingchen
ef284692db
refactor: Modularize WalletDB and Manifest ( #6223 )
...
This change modularizes the `WalletDB` and `Manifest`. Note that the wallet db has nothing to do with account wallets and it stores node configuration, which is why it depends on the manifest code.
2026-02-11 13:42:31 +00:00
Bart
34ef577604
refactor: Replace include guards by '#pragma once' ( #6322 )
...
This change replaces all include guards in the `src/` and `include/` directories by `#pragma once`.
2026-02-04 09:50:21 -05:00
Ayaz Salikhov
5f638f5553
chore: Set ColumnLimit to 120 in clang-format ( #6288 )
...
This change updates the ColumnLimit from 80 to 120, and applies clang-format to reformat the code.
2026-01-28 18:09:50 +00:00
Mayukha Vadari
3c9f5b6252
refactor: Fix typos in comments, configure cspell ( #6164 )
...
This change sets up a `cspell `configuration and fixes lots of typos in comments. There are no other code changes.
2026-01-07 12:10:19 -05:00