Ed Hennis
06e79bd3d5
Merge branch 'ximinez/lending-XLS-66' into ximinez/lending-enabled
2025-11-26 00:25:51 -05:00
Ed Hennis
315b511326
Merge branch 'develop' into ximinez/lending-XLS-66
2025-11-25 14:54:52 -05:00
Jingchen
b124c9f7e3
refactor: Retire Flow and FlowSortStrands amendments ( #6054 )
...
Amendments activated for more than 2 years can be retired. This change retires the Flow and FlowSortStrands amendments.
2025-11-25 14:21:17 +00:00
Ed Hennis
67886de4ab
Merge branch 'ximinez/lending-XLS-66' into ximinez/lending-enabled
2025-11-24 21:43:03 -05:00
Ed Hennis
814fe018b7
Merge branch 'develop' into ximinez/lending-XLS-66
2025-11-24 21:30:08 -05:00
Ed Hennis
71bb08cd78
Review feedback from @Tapanito, @gregtatcam, and @shawnxie999
...
- Created a common doWithdraw function for VaultWithdraw and
LoanBrokerCoverWithdraw. Added verifyDepositPreauth to it, so that
both transactions will get the check.
- Add a missing null check to LoanBrokerSet, and add log messages to the
existing checks.
2025-11-24 20:42:40 -05:00
Ed Hennis
a7af773dd8
Add a LoanBroker invariant to compare CoverAvailable to balance
...
- Ensures that LoanBroker.CoverAvailable is never less than the
pseudo-account balance for the Vault asset.
2025-11-24 16:24:35 -05:00
Jingchen
21c02232a5
refactor: Retire RequireFullyCanonicalSig amendment ( #6035 )
...
Amendments activated for more than 2 years can be retired. This change retires the RequireFullyCanonicalSig amendment.
2025-11-24 13:58:37 +00:00
Jingchen
a791c03dc1
refactor: Retire DeletableAccounts amendment ( #6056 )
...
Amendments activated for more than 2 years can be retired. This change retires the DeletableAccounts amendment.
2025-11-24 11:52:08 +00:00
Jingchen
800a315383
refactor: Retire CryptoConditionsSuite amendment ( #6036 )
...
Amendments activated for more than 2 years can be retired. This change retires the CryptoConditionsSuite amendment.
2025-11-24 06:23:16 -05:00
Ed Hennis
fa2dea84c2
Review feedback from @gregtatcam: STAmount
...
- Fix a couple of typos.
- Make fewer unneeded copies in roundToScale.
2025-11-22 22:30:06 -05:00
Ed Hennis
b82481858a
Review feedback from @gregtatcam
...
- Rename "accountCanSpend" to "accountSpendabled".
- Change some getIssuer() local vars to use references.
2025-11-22 20:57:34 -05:00
Ed Hennis
8bb162ce52
Review feedback from @gregtatcam
...
- Rewrite "Asset::native()" and "integral()" to use std::visit.
- Improve documentation for the LoanPay transaction flags:
tfLoanFullPayment, tfLoanLatePayment
2025-11-22 19:36:50 -05:00
Ed Hennis
1cec91e72d
Move protocol.h values into namespace Lending
2025-11-21 17:20:43 -05:00
Ed Hennis
f41b2c11d4
Merge branch 'ximinez/lending-XLS-66' into ximinez/lending-enabled
2025-11-21 14:35:06 -05:00
Ed Hennis
66da6a8608
Merge branch 'develop' into ximinez/lending-XLS-66
2025-11-21 12:47:43 -05:00
Pratik Mankawde
e4dccfd49b
refactor: Retire DisallowIncoming amendment ( #6045 )
...
Amendments activated for more than 2 years can be retired. This change retires the DisallowIncoming amendment.
2025-11-21 15:18:00 +00:00
Jingchen
57f4b4eb7f
refactor: Retire Checks amendment ( #6055 )
...
Amendments activated for more than 2 years can be retired. This change retires the Checks amendment.
2025-11-21 14:19:43 +00:00
Ed Hennis
ae00ec7ac5
Merge branch 'ximinez/lending-XLS-66' into ximinez/lending-enabled
2025-11-18 22:51:36 -05:00
Ed Hennis
bd0b651891
Merge branch 'develop' into ximinez/lending-XLS-66
2025-11-18 22:39:17 -05:00
sunnyraindy
ad37461ab2
chore: Fix some typos in comments ( #6040 )
2025-11-18 20:21:35 -05:00
Bronek Kozicki
d8b944c218
Enforce assets are transferable ( #6017 )
...
- Includes unit tests for terNO_RIPPLE.
- Switch auth mode to weak when submitter is destination.
- Require rippling enabled for vault deposits or withdrawals.
2025-11-18 18:28:59 -05:00
Jingchen
2c187461cc
refactor: Retire NegativeUNL amendment ( #6033 )
...
Amendments activated for more than 2 years can be retired. This change retires the NegativeUNL amendment.
2025-11-17 14:02:10 +00:00
Ed Hennis
baa875db19
Merge branch 'ximinez/lending-XLS-66' into ximinez/lending-enabled
2025-11-15 03:09:11 -05:00
Ed Hennis
cfdcaf3f8d
Merge branch 'develop' into ximinez/lending-XLS-66
2025-11-15 03:08:29 -05:00
Jingchen
7025e92080
refactor: Retire TicketBatch amendment ( #6032 )
...
Amendments activated for more than 2 years can be retired. This change retires the TicketBatch amendment.
2025-11-14 13:33:34 +00:00
Ed Hennis
ae497c14a0
Merge branch 'ximinez/lending-XLS-66' into ximinez/lending-enabled
2025-11-13 12:20:53 -05:00
Ed Hennis
2f94838bbf
Merge branch 'develop' into ximinez/lending-XLS-66
2025-11-13 12:18:42 -05:00
Ed Hennis
1c1cd1a391
Change Vault asset fields back to default
...
- Was unintentionally rolled back with `Number` changes.
2025-11-13 12:15:39 -05:00
Jingchen
508937f3d1
refactor: Retire MultiSignReserve and ExpandedSignerList amendments ( #5981 )
...
Amendments activated for more than 2 years can be retired. This change retires the MultiSignReserve and ExpandedSignerList amendments.
2025-11-13 11:42:45 +00:00
Ed Hennis
7ebee40951
Merge branch 'ximinez/lending-XLS-66' into ximinez/lending-enabled
2025-11-12 20:12:30 -05:00
Ed Hennis
a4aa72eada
Fix revert issues
2025-11-12 19:19:06 -05:00
Ed Hennis
398170ef3d
Revert "Add optional enforcement of valid integer range to Number"
...
This reverts commit 3cb447a4fe .
2025-11-12 19:15:14 -05:00
Ed Hennis
9b0b7b5a91
Revert "Make all STNumber fields "soeDEFAULT""
...
This reverts commit 24f37d73f6 .
2025-11-12 19:15:07 -05:00
Ed Hennis
1b4e18a1a7
Revert "Add integer enforcement when converting to XRP/MPTAmount to Number"
...
This reverts commit b605a2cdcc .
2025-11-12 19:15:06 -05:00
Ed Hennis
694abd1c79
Revert "Catch up the consequences of Number changes"
...
This reverts commit 0175dd70db .
2025-11-12 19:15:00 -05:00
Ed Hennis
2e34506835
Revert "Add a distinction between a "valid" and a "representable" Number"
...
This reverts commit 8e56af20ee .
2025-11-12 19:14:54 -05:00
Ed Hennis
cee1e6a6ed
Merge branch 'ximinez/lending-XLS-66' into ximinez/lending-enabled
2025-11-12 14:17:18 -05:00
Ed Hennis
8f772b9073
Merge remote-tracking branch 'XRPLF/develop' into ximinez/lending-XLS-66
...
* XRPLF/develop:
chore: Set version 3.1.0-b0 (5986)
ci: Clean workspace on Windows self-hosted runners (6024)
docs: fix spelling in comments (6002)
fix: floating point representation errors in vault (5997)
ci: Specify bash as the default shell in workflows (6021)
refactor: Add `XRPL_RETIRE_FIX` and `XRPL_RETIRE_FEATURE` macros (6014)
refactor: Retire DepositPreAuth and DepositAuth amendments (5978)
chore: Move running of unit tests out of coverage target (6018)
refactor: Retire PayChanRecipientOwnerDir amendment (5946)
2025-11-12 14:12:01 -05:00
Jingchen
9ffb434315
refactor: Add XRPL_RETIRE_FIX and XRPL_RETIRE_FEATURE macros ( #6014 )
...
Rather than having a single `XRPL_RETIRE` macro that applies to both feature and fix amendments, this change replaces it by new `XRPL_RETIRE_FIX` and `XRPL_RETIRE_FEATURE` macros that avoids confusion between whether to prefix the amendment name with `feature` or `fix`.
2025-11-11 12:45:13 -05:00
Ed Hennis
6c375f1346
Convert sfNextPaymentDueDate from optional to default
...
- Simplifies some of the updates and checks
2025-11-11 12:02:58 -05:00
Jingchen
ff18cfef96
refactor: Retire DepositPreAuth and DepositAuth amendments ( #5978 )
...
Amendments activated for more than 2 years can be retired. This change retires the fDepositPreAuth and DepositAuth amendments.
2025-11-11 15:21:07 +00:00
Pratik Mankawde
9b332d88c1
refactor: Retire PayChanRecipientOwnerDir amendment ( #5946 )
...
Amendments activated for more than 2 years can be retired. This change retires the PayChanRecipientOwnerDir amendment.
2025-11-11 09:07:45 -05:00
Ed Hennis
4396b77c4b
Add tfLoanLatePayment flag; full payment is no longer a special case
...
- A regular payment that is late, or a tfLoanLatePayment that is not
late will fail.
- Flags are mutually exclusive.
- Add a few interest computation shortcuts and overflow prevention
checks that return 0 if there's no time to compute for.
2025-11-10 23:17:42 -05:00
Ed Hennis
b815477ca1
Change LendingProtocol feature and dependencies to supported
2025-11-10 19:54:18 -05:00
Ed Hennis
73a857e69e
Merge branch 'develop' into ximinez/lending-XLS-66
2025-11-10 15:35:09 -05:00
Bronek Kozicki
3b810c305a
fix: JSON parsing of negative STNumber and STAmount ( #5990 )
...
This change fixes JSON parsing of negative `int` input in `STNumber` and `STAmount`. The conversion of JSON to `STNumber` or `STAmount` may trigger a condition where we negate smallest possible `int` value, which is undefined behaviour. We use a temporary storage as `int64_t` to avoid this bug. Note that this only affects RPC, because we do not parse JSON in the protocol layer, and hence no amendment is needed.
2025-11-10 17:33:20 +00:00
Jingchen
12c629a1d2
refactor: Retire CheckCashMakesTrustLine amendment ( #5974 )
...
Amendments activated for more than 2 years can be retired. This change retires the CheckCashMakesTrustLine amendment.
2025-11-10 16:03:10 +00:00
Ed Hennis
e3ea23cff5
Add test case to reproduce RIPD-3459
...
- Improve a few loan test helper functions.
- Make Loan.GracePeriod a default field.
2025-11-08 19:04:32 -05:00
Ed Hennis
ffc0d26d20
Merge remote-tracking branch 'mywork/ximinez/lending-number' into ximinez/lending-XLS-66
...
* mywork/ximinez/lending-number:
Add a distinction between a "valid" and a "representable" Number
chore: Point xrpld symlink to rippled (6012)
Catch up the consequences of Number changes
Fix build error - avoid copy
Add integer enforcement when converting to XRP/MPTAmount to Number
Make all STNumber fields "soeDEFAULT"
Add optional enforcement of valid integer range to Number
2025-11-08 17:00:35 -05:00