Commit Graph

9608 Commits

Author SHA1 Message Date
Vito
06460e2238 increases tls handshake timeout 2025-09-10 13:51:49 +02:00
Vito
90c74454c8 introduces hybrid connection timeout to outbound connection attempts 2025-09-10 13:48:37 +02:00
Vito
d68ca81b71 adds missing writePending flag 2025-09-04 15:34:04 +02:00
Vito Tumas
273e8b5365 Merge branch 'develop' into tapanito/bugfix/graceful-disconect 2025-09-04 12:41:59 +02:00
Vito
c487b41d1f reduce log verbosity 2025-09-04 12:40:33 +02:00
Vito
a5bdb3cef5 correctly handle shutdown when tls was not established yet 2025-09-04 12:40:11 +02:00
Vito
80c8a2e969 improves logging of failed connect attempts 2025-09-04 11:47:11 +02:00
Vito
c273c14b3e updates peerImp to correctly cancel protocol start if shutdown was initiated 2025-09-04 11:46:39 +02:00
Vito
3e406e1e13 changes connectAttempt timer to give 15 seconds for the whole connection process 2025-09-04 11:45:58 +02:00
Vito
15ae952514 cleans up connectAttempt 2025-09-04 11:44:47 +02:00
Bronek Kozicki
cf5f65b68e Add Scale to SingleAssetVault (#5652)
* Add and Scale to VaultCreate
* Add round-trip calculation to VaultDeposit VaultWithdraw and VaultClawback
* Implement Number::truncate() for VaultClawback
* Add rounding to DepositWithdraw
* Disallow zero shares withdraw or deposit with tecPRECISION_LOSS
* Return tecPATH_DRY on overflow when converting shares/assets
* Remove empty shares MPToken in clawback or withdraw (except for vault owner)
* Implicitly create shares MPToken for vault owner in VaultCreate
* Review feedback: defensive checks in shares/assets calculations

---------

Co-authored-by: Ed Hennis <ed@ripple.com>
2025-09-04 08:54:24 +00:00
Mayukha Vadari
e0b9812fc5 Refactor ledger_entry RPC source code and tests (#5237)
This is a major refactor of LedgerEntry.cpp. It adds a number of helper functions to make the code easier to maintain.

It also splits up the ledger and ledger_entry tests into different files, and cleans up the ledger_entry tests to make them easier to write and maintain.

This refactor also caught a few bugs in some of the other RPC processing, so those are fixed along the way.
2025-08-29 15:52:09 -04:00
Vito Tumas
e4fdf33158 adds additional logging to differentiate why connections were refused (#5690)
This is a follow-up to PR #5664 that further improves the specificity of logging for refused peer connections. The previous changes did not account for several key scenarios, leading to potentially misleading log messages.

It addresses the following 

- Inbound Disabled: Connections are now explicitly logged as rejected when the server is not configured to accept inbound peers. Previously, this was logged as the server being "full," which was technically correct but lacked diagnostic clarity.
- Duplicate Connections: The logging now distinguishes between two types of duplicate connection refusals:
    - When a peer with the same node public key is already connected (duplicate connection).
    -  When a connection is rejected because the limit for connections from a single IP address has been reached.

These changes provide more accurate and actionable diagnostic information when analyzing peer connection behavior.
2025-08-29 00:00:38 +00:00
Michael Legleux
87ea3ba65d Merge remote-tracking branch 'upstream/release' into merge2.6.0 2025-08-28 13:51:17 -04:00
Bronek Kozicki
dedf3d3983 Remove extraneous // LCOV_EXCL_START, and fix CMake warning (#5744)
* Remove extraneous // LCOV_EXCL_START
* Fix "At least one COMMAND must be given" CMake warning
2025-08-28 10:15:17 -04:00
Michael Legleux
2df7dcfdeb Set version to 2.6.0 2025-08-27 10:25:53 -07:00
Vito
62e10d09c6 restores shutdownStarted_ 2025-08-27 12:19:44 +02:00
Vito
5984ef1400 Merge branch 'develop' into tapanito/bugfix/graceful-disconect 2025-08-27 12:18:06 +02:00
Vito
a6eb8379f0 simplifies connect attempt async shutdown 2025-08-27 11:44:26 +02:00
Alex Kremer
1506e65558 refactor: Update to Boost 1.88 (#5570)
This updates Boost to 1.88, which is needed because Clio wants to move to 1.88 as that fixes several ASAN false positives around coroutine usage. In order for Clio to move to newer boost, libXRPL needs to move too. Hence the changes in this PR. A lot has changed between 1.83 and 1.88 so there are lots of changes in the diff, especially in regards to Boost.Asio and coroutines in particular.
2025-08-27 09:34:50 +00:00
Vito
df82fe3311 address review comments 2025-08-26 14:21:27 +02:00
Ed Hennis
7775c725f3 Merge remote-tracking branch 'upstream/release' into ximinez/merge-release 2025-08-22 19:56:21 -04:00
Ed Hennis
c5fe970646 Set version to 2.6.0-rc3 2025-08-22 17:32:31 -04:00
Ed Hennis
c57cd8b23e Revert "perf: Move mutex to the partition level (#5486)"
This reverts commit 94decc753b.
2025-08-22 17:30:08 -04:00
Mayukha Vadari
095dc4d9cc fix(test): handle null metadata for unvalidated tx in Env::meta (#5715)
This change handles errors better when calling `env.meta`. It prints some debug help and throws an error if `env.meta` is going to return a `nullptr`.
2025-08-22 16:15:03 +00:00
Bart
896b8c3b54 chore: Fix file formatting (#5718) 2025-08-22 10:02:56 -04:00
Vito
a34d2139a7 removes unused imports 2025-08-21 11:00:12 +02:00
Vito Tumas
985c199c11 Merge branch 'develop' into tapanito/bugfix/graceful-disconect 2025-08-21 10:56:26 +02:00
Vito
5b27b7e429 adds graceful shutdown to connect attempt 2025-08-21 10:54:17 +02:00
Vito
d9884eefa1 improves PeerImp logging 2025-08-21 10:54:00 +02:00
Vito
28870883bf cleans up assets in PeerImp 2025-08-20 12:17:46 +02:00
Vito
3d07dba2ce W.I.P. correct async shutdown 2025-08-20 11:20:40 +02:00
Vito
11152e39e6 prevent further async operations once shutdown initaited 2025-08-19 15:59:50 +02:00
Vito
7e41aaeffb adds graceful shutdown for outbound connection attempt 2025-08-19 15:59:49 +02:00
Jingchen
ceb0ce5634 refactor: Decouple net from xrpld and move rpc-related classes to the rpc folder (#5477)
As a step of modularisation, this change moves code from `xrpld` to `libxrpl`.
2025-08-15 23:27:13 +00:00
Michael Legleux
fb89213d4d Set version to 2.6.0-rc2 2025-08-15 14:50:35 -07:00
Vito
f0c5af9b99 shutdown the connection after reading EOF 2025-08-15 13:07:17 +02:00
Vito Tumas
7587d5fb05 Merge branch 'develop' into tapanito/bugfix/graceful-disconect 2025-08-14 19:09:20 +02:00
Elliot.
a14551b151 fix: Change log to debug level for AMM offer retrieval and IOU payment check (#5686)
Reduce log noise by changing two log statements from error/warn level to debug level. These logs occur during normal operation when AMM offers are not available or when IOU authorization checks fail, which are expected scenarios that don't require an elevated log level.
2025-08-14 12:28:01 -04:00
Vito Tumas
c665eb3009 Merge branch 'develop' into tapanito/bugfix/graceful-disconect 2025-08-14 16:20:14 +02:00
Vito
8a238aa52a removes graceful close 2025-08-14 16:07:20 +02:00
Vito
5c6a071c01 log all tcp errors onShutdown 2025-08-14 12:20:45 +02:00
Vito
474514b2b8 improves code style 2025-08-13 17:14:10 +02:00
Vito
72cec6614c updates peer logic to shutdown asynchornously 2025-08-13 16:42:07 +02:00
Michael Legleux
da82e52613 Set version to 2.6.0-rc1 2025-08-12 13:40:34 -07:00
Vito
068bcd0399 adds a check whether the socket is open before sending a message 2025-08-12 19:16:12 +02:00
Vito
076371746b adds graceful peer disconnection 2025-08-12 19:02:56 +02:00
Vito Tumas
c9d73b6135 fix: Improve logging of the reason to refuse a peer connection (#5664)
Currently, all peer connection rejections are logged with the reason "slots full". This is inaccurate, as the PeerFinder can also reject connections if they are a duplicate. This change updates the logging logic to correctly report the specific reason (full or duplicate) for a rejected peer connection, providing more accurate diagnostic information.
2025-08-11 18:52:47 +00:00
Oleksandr Hrabar
b7ed99426b fix: Make test suite names match the directory name (#5597)
This change fixes the suite names all around the test files, to make them match to the folder name in which this test files are located. Also, the RCL test files are relocated to the consensus folder, because they are testing consensus functionality.
2025-08-11 14:12:36 -04:00
Mayukha Vadari
97f0747e10 chore: Run prettier on all files (#5657) 2025-08-11 16:15:42 +00:00