Denis Angell
9294479a8a
Merge remote-tracking branch 'origin/develop' into dangell7/docs
...
# Conflicts:
# include/xrpl/protocol/STParsedJSON.h
# include/xrpl/shamap/SHAMapTreeNode.h
# src/libxrpl/ledger/helpers/TokenHelpers.cpp
# src/libxrpl/protocol/STIssue.cpp
# src/libxrpl/protocol/STParsedJSON.cpp
# src/libxrpl/shamap/SHAMapTreeNode.cpp
# src/libxrpl/tx/invariants/PermissionedDEXInvariant.cpp
# src/libxrpl/tx/transactors/nft/NFTokenAcceptOffer.cpp
# src/libxrpl/tx/transactors/vault/VaultWithdraw.cpp
# src/xrpld/rpc/detail/Role.cpp
# src/xrpld/rpc/detail/TransactionSign.cpp
# src/xrpld/rpc/handlers/account/AccountObjects.cpp
2026-05-14 08:59:49 +02:00
Denis Angell
315d1fdb06
part 3
2026-05-14 06:57:17 +02:00
Denis Angell
e635557235
part 2
2026-05-14 05:56:04 +02:00
Denis Angell
d8febb71bd
part 1
2026-05-13 23:01:44 +02:00
Vito Tumas
6340c986c9
feat: Enable and rename fixSecurity3_1_3 to fixCleanup3_1_3 ( #7128 )
...
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
2026-05-13 09:42:34 +00:00
Alex Kremer
cdee9a675c
refactor: Use more scoped enums ( #7086 )
2026-05-11 15:39:48 +00:00
Alex Kremer
8995564ed6
refactor: Enable clang-tidy readability-identifier-naming check ( #6571 )
2026-05-03 10:31:53 +00:00
Zhiyuan Wang
dbd646bd53
fix: Store Delegate object in delegating and authorized account directories for proper deletion ( #6681 )
2026-04-29 18:17:01 +00:00
Alex Kremer
f7275b7ad9
chore: Enable clang-tidy v21 new checks ( #7031 )
2026-04-29 15:17:35 +00:00
Alex Kremer
4dc923dcc5
chore: Enable clang-tidy modernize-use-nodiscard check ( #7015 )
2026-04-24 17:19:30 +00:00
Mayukha Vadari
7cfa5d4610
fix: Make assorted Payments fixes ( #6585 )
2026-04-24 12:56:50 +00:00
Mayukha Vadari
248cb29681
refactor: Move LendingHelpers into libxrpl/ledger/helpers ( #6638 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-04-24 12:06:26 +00:00
Alex Kremer
19da25812b
fix: Remaining clang-tidy unchecked optionals ( #6979 )
2026-04-23 16:21:01 +00:00
Mayukha Vadari
1c6cdc653c
fix: More clang-tidy issues ( #6992 )
2026-04-22 17:42:15 +00:00
Vito Tumas
2e307329f0
refactor: Add transaction-specific invariant checking ( #6551 )
2026-04-22 14:41:19 +00:00
Alex Kremer
ce3951bbb3
chore: Enable clang-tidy modernize checks ( #6975 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-04-21 15:32:51 +00:00
Alex Kremer
ea023121f5
fix: Add rounding to Vault invariants ( #6217 ) ( #6955 )
...
Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com >
Co-authored-by: Ed Hennis <ed@ripple.com >
2026-04-21 12:14:07 +00:00
Zhiyuan Wang
96643bb0fa
fix: Check for empty sfAdditionalBooks array in hybrid offer invariant ( #6716 )
2026-04-20 17:10:28 +00:00
Alex Kremer
f1a5ba43ad
chore: Enable clang-tidy readability checks ( #6930 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-04-17 13:30:52 +00:00
Alex Kremer
6a0ce46755
chore: Enable most clang-tidy bugprone checks ( #6929 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-04-14 20:24:21 +00:00
Mayukha Vadari
7793b5f10b
refactor: Combine AMMHelpers and AMMUtils ( #6733 )
2026-04-08 17:38:33 +00:00
Gregory Tsipenyuk
dfcad69155
feat: Add MPT support to DEX ( #5285 )
2026-04-08 16:17:37 +00:00
Bart
c00ed673a8
refactor: Rename non-functional uses of ripple(d) to xrpl(d) ( #6676 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-04-07 13:00:17 +00:00
Mayukha Vadari
f239256d87
refactor: Move more helper files into libxrpl/ledger/helpers ( #6731 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-04-06 22:36:32 +00:00
Alex Kremer
29e49abd3c
chore: Enable clang-tidy coreguidelines checks ( #6698 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-04-01 15:46:14 +00:00
Alex Kremer
2502befb42
chore: Enable clang-tidy misc checks ( #6655 )
2026-03-31 17:29:45 +00:00
Bart
7f53351920
chore: Remove unnecessary clang-format off/on directives ( #6682 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-03-31 15:38:04 +00:00
Alex Kremer
ab8c168e3b
chore: Enable remaining clang-tidy performance checks ( #6648 )
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2026-03-30 17:08:47 +00:00
Jingchen
3a477e4d01
refactor: Address PR comments after the modularisation PRs ( #6389 )
...
Signed-off-by: JCW <a1q123456@users.noreply.github.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-03-30 15:22:38 +00:00
Vito Tumas
9b944ee8c2
refactor: Split LoanInvariant into LoanBrokerInvariant and LoanInvariant ( #6674 )
2026-03-27 18:35:42 +00:00
Jingchen
addc1e8e25
refactor: Make function naming in ServiceRegistry consistent ( #6390 )
...
Signed-off-by: JCW <a1q123456@users.noreply.github.com >
Co-authored-by: Ed Hennis <ed@ripple.com >
2026-03-26 14:11:16 +00:00
Jingchen
8f182e825a
refactor: Modularise ledger ( #6536 )
...
Signed-off-by: JCW <a1q123456@users.noreply.github.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
Co-authored-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-03-25 16:32:45 +00:00
Alex Kremer
0eedefbf45
refactor: Enable more clang-tidy readability checks ( #6595 )
...
Co-authored-by: Sergey Kuznetsov <kuzzz99@gmail.com >
2026-03-24 15:42:12 +00:00
Mayukha Vadari
8b986e4ab0
refactor: Improve imports to only call the needed helpers ( #6624 )
2026-03-24 10:20:32 +00:00
Mayukha Vadari
e0dbe90370
refactor: Move ledger entry helper functions from View.h/View.cpp to dedicated helper files ( #6453 )
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2026-03-23 15:39:58 +00:00
Mayukha Vadari
d360e7c5b6
refactor: Rename transactor files/classes to match the tx name ( #6580 )
2026-03-18 19:52:07 +00:00
Alex Kremer
57e4cbbcd9
refactor: Add simple clang-tidy readability checks ( #6556 )
...
This change enables the following clang-tidy checks:
- readability-avoid-nested-conditional-operator,
- readability-avoid-return-with-void-value,
- readability-braces-around-statements,
- readability-const-return-type,
- readability-container-contains,
- readability-container-size-empty,
- readability-else-after-return,
- readability-make-member-function-const,
- readability-redundant-casting,
- readability-redundant-inline-specifier,
- readability-redundant-member-init,
- readability-redundant-string-init,
- readability-reference-to-constructed-temporary,
- readability-static-definition
2026-03-18 16:41:49 +00:00
Mayukha Vadari
b92a9a3053
fix: Make assorted NFT fixes ( #6566 )
...
This change:
* Removes a set of unnecessary brackets in the initialization of an `std::uint32_t`.
* Fixes a couple of incorrect flags (same value, just wrong variables - so no amendment needed).
2026-03-18 14:47:59 +00:00
Mayukha Vadari
dcaef828b4
refactor: Replace !=/== tesSuccess with using isTesSuccess ( #6409 )
...
This change replaces all instances of `<variable> != tesSUCCESS` with `!isTesSuccess(<variable>)` and `<variable> == tesSUCCESS` with `isTesSuccess(<variable>)`.
2026-03-18 14:15:10 +00:00
Alex Kremer
72f4cb097f
refactor: Enable remaining clang-tidy cppcoreguidelines checks ( #6538 )
2026-03-17 19:09:05 +00:00
Mayukha Vadari
252c6768df
refactor: Clean up getFeePayer, mSourceBalance, and mPriorBalance ( #6478 )
...
This change:
* Introduces a new helper function on `STTx`, `getFeePayer`.
* Removes the usage of `mSourceBalance` and replaces it with SLE balance lookups.
* Renames `mPriorBalance` to `preFeeBalance_`
This simplifies some of the code in the transactors and makes it a lot more readable.
2026-03-17 14:12:16 +00:00
Mayukha Vadari
1bf9e6e7da
fix: Remove a newline from logging statement in changeSpotPrice calculation ( #6547 )
...
This change removes an unnecessary newline in a logging statement. Namely, `std::endl` is unneeded in `JLOG`, since it automatically places a newline at the end of the string.
2026-03-13 18:12:25 +00:00
Vito Tumas
c1d108e565
docs: Improve documentation for InvariantCheck ( #6518 )
2026-03-12 21:50:35 +00:00
Vito Tumas
2b14ee3018
refactor: Split combined transactor files into individual classes ( #6495 )
...
DID, Escrows, PaymentChannels, and Credentials previously contained multiple unrelated transactor classes in a single header/implementation pair. This change splits each into one class per file, following the same pattern established by the rest of the codebase.
2026-03-12 17:19:29 +00:00
Vito Tumas
5865bd017f
refactor: Update transaction folder structure ( #6483 )
...
This change reorganizes the `tx/transactors` directory for consistency and discoverability. There are no behavioral changes, this is a pure refactor. Underscores were chosen as the way to separate multi-words as this is the more popular option in C++ projects.
Specific changes:
- Rename all subdirectories to lowercase/snake_case (`AMM` → `amm`, `Check` → `check`, `NFT` → `nft`, `PermissionedDomain` → `permissioned_domain`, etc.)
- Merge `AMM/` and `Offer/` into `dex/`, including `PermissionedDEXHelpers`
- Rename `MPT/` → `token/`, absorbing `SetTrust` and `Clawback`
- Move top-level transactors into named groups: `account/`, `bridge/`, `credentials/`, `did/`, `escrow/`, `oracle/`, `payment/`, `payment_channel/`, `system/`
- Update all include paths across the codebase and `transactions.macro`
2026-03-06 08:25:31 +00:00
Alex Kremer
dde450784d
Add Formats and Flags to server_definitions ( #6321 )
...
This change implements https://github.com/XRPLF/XRPL-Standards/discussions/418 : "System XLS: Add Formats and Flags to server_definitions".
2026-03-05 16:11:27 +00:00
Vito Tumas
1a7f824b89
refactor: Splits invariant checks into multiple classes ( #6440 )
...
The invariant check system had grown into a single monolithic file pair containing 24 invariant checker classes. The large `InvariantCheck.cpp` file was a frequent source of merge conflicts and difficult to navigate. This refactoring improves maintainability and readability with zero behavioral changes.
In particular, this change:
- Splits `InvariantCheck.h` and `InvariantCheck.cpp` into 10 focused header/source pairs organized by domain under a new `invariants/` subdirectory.
- Extracts the shared `Privilege` enum and `hasPrivilege()` function into a dedicated `InvariantCheckPrivilege.h` header, so domain-specific files can reference them independently.
2026-02-27 21:02:39 +00:00
Ayaz Salikhov
2c1fad1023
chore: Apply clang-format width 100 ( #6387 )
2026-02-19 23:30:00 +00:00
Jingchen
0976b2b68b
refactor: Modularize app/tx ( #6228 )
2026-02-17 18:10:07 +00:00