refactor: Retire DepositPreAuth and DepositAuth amendments (#5978)

Amendments activated for more than 2 years can be retired. This change retires the fDepositPreAuth and DepositAuth amendments.
This commit is contained in:
Jingchen
2025-11-11 15:21:07 +00:00
committed by GitHub
parent 03704f712b
commit ff18cfef96
17 changed files with 168 additions and 389 deletions

View File

@@ -3039,8 +3039,6 @@ private:
using namespace jtx;
Account const becky{"becky"};
bool const supportsPreauth = {features[featureDepositPreauth]};
// The initial implementation of DepositAuth had a bug where an
// account with the DepositAuth flag set could not make a payment
// to itself. That bug was fixed in the DepositPreauth amendment.
@@ -3068,15 +3066,11 @@ private:
env(fset(becky, asfDepositAuth));
env.close();
// becky pays herself again. Whether it succeeds depends on
// whether featureDepositPreauth is enabled.
TER const expect{
supportsPreauth ? TER{tesSUCCESS} : TER{tecNO_PERMISSION}};
// becky pays herself again.
env(pay(becky, becky, USD(10)),
path(~USD),
sendmax(XRP(10)),
ter(expect));
ter(tesSUCCESS));
env.close();
}
@@ -3784,9 +3778,7 @@ private:
void
testDepositAuth()
{
auto const supported{jtx::testable_amendments()};
testPayment(supported - featureDepositPreauth);
testPayment(supported);
testPayment(jtx::testable_amendments());
testPayIOU();
}