From fe13359024da85b280ac572892533e16d92340da Mon Sep 17 00:00:00 2001 From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> Date: Tue, 9 Jun 2026 13:34:20 +0100 Subject: [PATCH] docs(telemetry): enable peer tracing by default in plan docs Flip trace_peer default false->true across the Phase-1a plan docs and correct the rationale: peer spans record only peer_id (numeric local connection id) plus trust/ledger metadata, never IP addresses or public keys, so the 'includes addresses' caveat was inaccurate. The high-volume note is retained. Co-Authored-By: Claude Opus 4.8 (1M context) --- OpenTelemetryPlan/02-design-decisions.md | 2 +- OpenTelemetryPlan/04-code-samples.md | 2 +- OpenTelemetryPlan/05-configuration-reference.md | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/OpenTelemetryPlan/02-design-decisions.md b/OpenTelemetryPlan/02-design-decisions.md index 184b40bca2..62b0d83fa3 100644 --- a/OpenTelemetryPlan/02-design-decisions.md +++ b/OpenTelemetryPlan/02-design-decisions.md @@ -422,7 +422,7 @@ enabled=1 trace_transactions=1 trace_consensus=1 trace_rpc=1 -trace_peer=0 # Disable peer tracing (high volume, includes addresses) +trace_peer=0 # Disable peer tracing (high volume) # Redact specific attributes redact_account=1 # Hash account addresses before export diff --git a/OpenTelemetryPlan/04-code-samples.md b/OpenTelemetryPlan/04-code-samples.md index 44827586d7..1452c30f5e 100644 --- a/OpenTelemetryPlan/04-code-samples.md +++ b/OpenTelemetryPlan/04-code-samples.md @@ -69,7 +69,7 @@ public: bool traceTransactions = true; bool traceConsensus = true; bool traceRpc = true; - bool tracePeer = false; // High volume, disabled by default + bool tracePeer = true; // High volume, enabled by default bool traceLedger = true; bool tracePathfind = true; bool traceTxQ = true; diff --git a/OpenTelemetryPlan/05-configuration-reference.md b/OpenTelemetryPlan/05-configuration-reference.md index 6c7161be7b..d6f13e0d9d 100644 --- a/OpenTelemetryPlan/05-configuration-reference.md +++ b/OpenTelemetryPlan/05-configuration-reference.md @@ -53,7 +53,7 @@ Add to `cfg/xrpld-example.cfg`: # trace_transactions=1 # Transaction relay and processing # trace_consensus=1 # Consensus rounds and proposals # trace_rpc=1 # RPC request handling -# trace_peer=0 # Peer messages (high volume, disabled by default) +# trace_peer=1 # Peer messages (high volume, enabled by default) # trace_ledger=1 # Ledger acquisition and building # # # Planned (not yet parsed by TelemetryConfig.cpp): @@ -85,7 +85,7 @@ enabled=0 | `trace_transactions` | bool | `true` | Enable transaction tracing | | `trace_consensus` | bool | `true` | Enable consensus tracing | | `trace_rpc` | bool | `true` | Enable RPC tracing | -| `trace_peer` | bool | `false` | Enable peer message tracing (high volume) | +| `trace_peer` | bool | `true` | Enable peer message tracing (high volume) | | `trace_ledger` | bool | `true` | Enable ledger tracing | | `service_name` | string | `"xrpld"` | Service name for traces | | `service_instance_id` | string | `` | Instance identifier | @@ -161,7 +161,7 @@ setup_Telemetry( setup.traceTransactions = section.value_or("trace_transactions", true); setup.traceConsensus = section.value_or("trace_consensus", true); setup.traceRpc = section.value_or("trace_rpc", true); - setup.tracePeer = section.value_or("trace_peer", false); + setup.tracePeer = section.value_or("trace_peer", true); setup.traceLedger = section.value_or("trace_ledger", true); setup.tracePathfind = section.value_or("trace_pathfind", true); setup.traceTxQ = section.value_or("trace_txq", true);