migrate lending helpers

2026-07-24 15:40:26 +00:00 · 2026-07-09 22:31:58 -04:00
parent 628272a11e
commit fb9b10fc03
16 changed files with 320 additions and 166 deletions
--- a/include/xrpl/ledger/helpers/LendingHelpers.h
+++ b/include/xrpl/ledger/helpers/LendingHelpers.h
@@ -7,6 +7,7 @@
 #include <xrpl/beast/utility/instrumentation.h>
 #include <xrpl/ledger/ApplyView.h>
 #include <xrpl/ledger/ReadView.h>
+#include <xrpl/ledger/helpers/SLEWrappers.h>
 #include <xrpl/protocol/Asset.h>
 #include <xrpl/protocol/LedgerFormats.h>  // IWYU pragma: keep
 #include <xrpl/protocol/Protocol.h>
@@ -48,7 +49,7 @@ namespace xrpl {
 [[nodiscard]] TER
 canApplyToBrokerCover(
    ReadView const& view,
-    SLE::const_ref sleBroker,
+    LoanBrokerEntry<ReadView> const& sleBroker,
    Asset const& vaultAsset,
    STAmount const& amount,
    beast::Journal j,
@@ -214,7 +215,7 @@ adjustImpreciseNumber(
 }

 inline int
-getAssetsTotalScale(SLE::const_ref vaultSle)
+getAssetsTotalScale(VaultEntry<ReadView> const& vaultSle)
 {
    if (!vaultSle)
        return Number::kMinExponent - 1;  // LCOV_EXCL_LINE
@@ -225,7 +226,10 @@ getAssetsTotalScale(SLE::const_ref vaultSle)
 // DebtTotal is a broker-level aggregate maintained at vault scale, so the
 // rounding must also use vault scale — never an individual loan's scale.
 inline Number
-minimumBrokerCover(Number const& debtTotal, TenthBips32 coverRateMinimum, SLE::const_ref vaultSle)
+minimumBrokerCover(
+    Number const& debtTotal,
+    TenthBips32 coverRateMinimum,
+    VaultEntry<ReadView> const& vaultSle)
 {
    XRPL_ASSERT(
        vaultSle && vaultSle->getType() == ltVAULT, "xrpl::minimumBrokerCover : valid Vault sle");
@@ -263,7 +267,7 @@ constructLoanState(
 // Constructs a valid LoanState object from a Loan object, which always has
 // rounded values
 LoanState
-constructRoundedLoanState(SLE::const_ref loan);
+constructRoundedLoanState(LoanEntry<ReadView> const& loan);

 Number
 computeManagementFee(
@@ -545,8 +549,8 @@ std::expected<LoanPaymentParts, TER>
 loanMakePayment(
    Asset const& asset,
    ApplyView& view,
-    SLE::ref loan,
-    SLE::const_ref brokerSle,
+    LoanEntry<ApplyView>& loan,
+    LoanBrokerEntry<ReadView> const& brokerSle,
    STAmount const& amount,
    LoanPaymentType const paymentType,
    beast::Journal j);
--- a/include/xrpl/ledger/helpers/SLEBase.h
+++ b/include/xrpl/ledger/helpers/SLEBase.h
@@ -177,7 +177,10 @@ public:
        return j_;
    }

-protected:
+    // --- Constructors that adopt/resolve an SLE (public so the ReadOnlySLE /
+    //     WritableSLE aliases and the per-type wrappers can be built directly
+    //     from an already-fetched SLE or a keylet). ---
+
    /** Constructor for read-only context */
    explicit SLEBase(
        SLE::const_pointer sle,
@@ -233,6 +236,7 @@ protected:
    {
    }

+protected:
    view_ref_type view_{};

    // Keylet is only meaningful for writable views, but we conditionally
@@ -247,4 +251,15 @@ protected:
    beast::Journal j_;
 };

+/** Generic (any-entry-type) SLE handles.
+ *
+ * Use these when the concrete ledger entry type is not known at a given site;
+ * otherwise prefer the per-type wrappers in SLEWrappers.h.
+ *
+ *   SLE::const_pointer / SLE::const_ref  ->  ReadOnlySLE
+ *   SLE::pointer       / SLE::ref        ->  WritableSLE
+ */
+using ReadOnlySLE = SLEBase<ReadView>;
+using WritableSLE = SLEBase<ApplyView>;
+
 }  // namespace xrpl
--- a/include/xrpl/ledger/helpers/SLEWrappers.h
+++ b/include/xrpl/ledger/helpers/SLEWrappers.h
@@ -14,8 +14,8 @@ namespace xrpl {
 * than translate the entry's "keylet parts" (the arguments to its keylet::
 * function) into a Keylet that the base class resolves against the view:
 *
- *   AccountRoot<ApplyView> acct{id, view};     // peek (writable)
- *   AccountRoot<ReadView>  acct{id, readView}; // read  (read-only)
+ *   AccountRootEntry<ApplyView> acct{id, view};     // peek (writable)
+ *   AccountRootEntry<ReadView>  acct{id, readView}; // read  (read-only)
 *
 * Domain-specific accessors will be layered onto each wrapper over time.
 */
@@ -23,10 +23,14 @@ namespace xrpl {
 // Ordered to match include/xrpl/protocol/detail/ledger_entries.macro.

 template <typename ViewT>
-class NFTokenOffer : public SLEBase<ViewT>
+class NFTokenOfferEntry : public SLEBase<ViewT>
 {
 public:
-    explicit NFTokenOffer(
+    // Inherit base constructors: adopt an existing SLE, or resolve one from a
+    // Keylet against the view.
+    using SLEBase<ViewT>::SLEBase;
+
+    explicit NFTokenOfferEntry(
        AccountID const& owner,
        std::uint32_t seq,
        typename SLEBase<ViewT>::view_ref_type view,
@@ -37,10 +41,14 @@ public:
 };

 template <typename ViewT>
-class Check : public SLEBase<ViewT>
+class CheckEntry : public SLEBase<ViewT>
 {
 public:
-    explicit Check(
+    // Inherit base constructors: adopt an existing SLE, or resolve one from a
+    // Keylet against the view.
+    using SLEBase<ViewT>::SLEBase;
+
+    explicit CheckEntry(
        AccountID const& id,
        std::uint32_t seq,
        typename SLEBase<ViewT>::view_ref_type view,
@@ -51,10 +59,14 @@ public:
 };

 template <typename ViewT>
-class DID : public SLEBase<ViewT>
+class DIDEntry : public SLEBase<ViewT>
 {
 public:
-    explicit DID(
+    // Inherit base constructors: adopt an existing SLE, or resolve one from a
+    // Keylet against the view.
+    using SLEBase<ViewT>::SLEBase;
+
+    explicit DIDEntry(
        AccountID const& account,
        typename SLEBase<ViewT>::view_ref_type view,
        beast::Journal j = beast::Journal{beast::Journal::getNullSink()})
@@ -64,10 +76,14 @@ public:
 };

 template <typename ViewT>
-class NegativeUNL : public SLEBase<ViewT>
+class NegativeUNLEntry : public SLEBase<ViewT>
 {
 public:
-    explicit NegativeUNL(
+    // Inherit base constructors: adopt an existing SLE, or resolve one from a
+    // Keylet against the view.
+    using SLEBase<ViewT>::SLEBase;
+
+    explicit NegativeUNLEntry(
        typename SLEBase<ViewT>::view_ref_type view,
        beast::Journal j = beast::Journal{beast::Journal::getNullSink()})
        : SLEBase<ViewT>(keylet::negativeUNL(), view, j)
@@ -76,10 +92,14 @@ public:
 };

 template <typename ViewT>
-class NFTokenPage : public SLEBase<ViewT>
+class NFTokenPageEntry : public SLEBase<ViewT>
 {
 public:
-    explicit NFTokenPage(
+    // Inherit base constructors: adopt an existing SLE, or resolve one from a
+    // Keylet against the view.
+    using SLEBase<ViewT>::SLEBase;
+
+    explicit NFTokenPageEntry(
        Keylet const& page,
        uint256 const& token,
        typename SLEBase<ViewT>::view_ref_type view,
@@ -90,10 +110,14 @@ public:
 };

 template <typename ViewT>
-class SignerList : public SLEBase<ViewT>
+class SignerListEntry : public SLEBase<ViewT>
 {
 public:
-    explicit SignerList(
+    // Inherit base constructors: adopt an existing SLE, or resolve one from a
+    // Keylet against the view.
+    using SLEBase<ViewT>::SLEBase;
+
+    explicit SignerListEntry(
        AccountID const& account,
        typename SLEBase<ViewT>::view_ref_type view,
        beast::Journal j = beast::Journal{beast::Journal::getNullSink()})
@@ -103,10 +127,14 @@ public:
 };

 template <typename ViewT>
-class Ticket : public SLEBase<ViewT>
+class TicketEntry : public SLEBase<ViewT>
 {
 public:
-    explicit Ticket(
+    // Inherit base constructors: adopt an existing SLE, or resolve one from a
+    // Keylet against the view.
+    using SLEBase<ViewT>::SLEBase;
+
+    explicit TicketEntry(
        AccountID const& id,
        std::uint32_t ticketSeq,
        typename SLEBase<ViewT>::view_ref_type view,
@@ -117,10 +145,14 @@ public:
 };

 template <typename ViewT>
-class AccountRoot : public SLEBase<ViewT>
+class AccountRootEntry : public SLEBase<ViewT>
 {
 public:
-    explicit AccountRoot(
+    // Inherit base constructors: adopt an existing SLE, or resolve one from a
+    // Keylet against the view.
+    using SLEBase<ViewT>::SLEBase;
+
+    explicit AccountRootEntry(
        AccountID const& id,
        typename SLEBase<ViewT>::view_ref_type view,
        beast::Journal j = beast::Journal{beast::Journal::getNullSink()})
@@ -130,10 +162,14 @@ public:
 };

 template <typename ViewT>
-class DirectoryNode : public SLEBase<ViewT>
+class DirectoryNodeEntry : public SLEBase<ViewT>
 {
 public:
-    explicit DirectoryNode(
+    // Inherit base constructors: adopt an existing SLE, or resolve one from a
+    // Keylet against the view.
+    using SLEBase<ViewT>::SLEBase;
+
+    explicit DirectoryNodeEntry(
        AccountID const& id,
        typename SLEBase<ViewT>::view_ref_type view,
        beast::Journal j = beast::Journal{beast::Journal::getNullSink()})
@@ -143,10 +179,14 @@ public:
 };

 template <typename ViewT>
-class Amendments : public SLEBase<ViewT>
+class AmendmentsEntry : public SLEBase<ViewT>
 {
 public:
-    explicit Amendments(
+    // Inherit base constructors: adopt an existing SLE, or resolve one from a
+    // Keylet against the view.
+    using SLEBase<ViewT>::SLEBase;
+
+    explicit AmendmentsEntry(
        typename SLEBase<ViewT>::view_ref_type view,
        beast::Journal j = beast::Journal{beast::Journal::getNullSink()})
        : SLEBase<ViewT>(keylet::amendments(), view, j)
@@ -155,10 +195,14 @@ public:
 };

 template <typename ViewT>
-class LedgerHashes : public SLEBase<ViewT>
+class LedgerHashesEntry : public SLEBase<ViewT>
 {
 public:
-    explicit LedgerHashes(
+    // Inherit base constructors: adopt an existing SLE, or resolve one from a
+    // Keylet against the view.
+    using SLEBase<ViewT>::SLEBase;
+
+    explicit LedgerHashesEntry(
        typename SLEBase<ViewT>::view_ref_type view,
        beast::Journal j = beast::Journal{beast::Journal::getNullSink()})
        : SLEBase<ViewT>(keylet::skip(), view, j)
@@ -167,10 +211,14 @@ public:
 };

 template <typename ViewT>
-class Bridge : public SLEBase<ViewT>
+class BridgeEntry : public SLEBase<ViewT>
 {
 public:
-    explicit Bridge(
+    // Inherit base constructors: adopt an existing SLE, or resolve one from a
+    // Keylet against the view.
+    using SLEBase<ViewT>::SLEBase;
+
+    explicit BridgeEntry(
        STXChainBridge const& bridge,
        STXChainBridge::ChainType chainType,
        typename SLEBase<ViewT>::view_ref_type view,
@@ -181,10 +229,14 @@ public:
 };

 template <typename ViewT>
-class Offer : public SLEBase<ViewT>
+class OfferEntry : public SLEBase<ViewT>
 {
 public:
-    explicit Offer(
+    // Inherit base constructors: adopt an existing SLE, or resolve one from a
+    // Keylet against the view.
+    using SLEBase<ViewT>::SLEBase;
+
+    explicit OfferEntry(
        AccountID const& id,
        std::uint32_t seq,
        typename SLEBase<ViewT>::view_ref_type view,
@@ -195,10 +247,14 @@ public:
 };

 template <typename ViewT>
-class DepositPreauth : public SLEBase<ViewT>
+class DepositPreauthEntry : public SLEBase<ViewT>
 {
 public:
-    explicit DepositPreauth(
+    // Inherit base constructors: adopt an existing SLE, or resolve one from a
+    // Keylet against the view.
+    using SLEBase<ViewT>::SLEBase;
+
+    explicit DepositPreauthEntry(
        AccountID const& owner,
        AccountID const& preauthorized,
        typename SLEBase<ViewT>::view_ref_type view,
@@ -209,10 +265,14 @@ public:
 };

 template <typename ViewT>
-class XChainOwnedClaimID : public SLEBase<ViewT>
+class XChainOwnedClaimIDEntry : public SLEBase<ViewT>
 {
 public:
-    explicit XChainOwnedClaimID(
+    // Inherit base constructors: adopt an existing SLE, or resolve one from a
+    // Keylet against the view.
+    using SLEBase<ViewT>::SLEBase;
+
+    explicit XChainOwnedClaimIDEntry(
        STXChainBridge const& bridge,
        std::uint64_t seq,
        typename SLEBase<ViewT>::view_ref_type view,
@@ -223,10 +283,14 @@ public:
 };

 template <typename ViewT>
-class RippleState : public SLEBase<ViewT>
+class RippleStateEntry : public SLEBase<ViewT>
 {
 public:
-    explicit RippleState(
+    // Inherit base constructors: adopt an existing SLE, or resolve one from a
+    // Keylet against the view.
+    using SLEBase<ViewT>::SLEBase;
+
+    explicit RippleStateEntry(
        AccountID const& id0,
        AccountID const& id1,
        Currency const& currency,
@@ -238,10 +302,14 @@ public:
 };

 template <typename ViewT>
-class FeeSettings : public SLEBase<ViewT>
+class FeeSettingsEntry : public SLEBase<ViewT>
 {
 public:
-    explicit FeeSettings(
+    // Inherit base constructors: adopt an existing SLE, or resolve one from a
+    // Keylet against the view.
+    using SLEBase<ViewT>::SLEBase;
+
+    explicit FeeSettingsEntry(
        typename SLEBase<ViewT>::view_ref_type view,
        beast::Journal j = beast::Journal{beast::Journal::getNullSink()})
        : SLEBase<ViewT>(keylet::feeSettings(), view, j)
@@ -250,10 +318,14 @@ public:
 };

 template <typename ViewT>
-class XChainOwnedCreateAccountClaimID : public SLEBase<ViewT>
+class XChainOwnedCreateAccountClaimIDEntry : public SLEBase<ViewT>
 {
 public:
-    explicit XChainOwnedCreateAccountClaimID(
+    // Inherit base constructors: adopt an existing SLE, or resolve one from a
+    // Keylet against the view.
+    using SLEBase<ViewT>::SLEBase;
+
+    explicit XChainOwnedCreateAccountClaimIDEntry(
        STXChainBridge const& bridge,
        std::uint64_t seq,
        typename SLEBase<ViewT>::view_ref_type view,
@@ -264,10 +336,14 @@ public:
 };

 template <typename ViewT>
-class Escrow : public SLEBase<ViewT>
+class EscrowEntry : public SLEBase<ViewT>
 {
 public:
-    explicit Escrow(
+    // Inherit base constructors: adopt an existing SLE, or resolve one from a
+    // Keylet against the view.
+    using SLEBase<ViewT>::SLEBase;
+
+    explicit EscrowEntry(
        AccountID const& src,
        std::uint32_t seq,
        typename SLEBase<ViewT>::view_ref_type view,
@@ -278,10 +354,14 @@ public:
 };

 template <typename ViewT>
-class PayChannel : public SLEBase<ViewT>
+class PayChannelEntry : public SLEBase<ViewT>
 {
 public:
-    explicit PayChannel(
+    // Inherit base constructors: adopt an existing SLE, or resolve one from a
+    // Keylet against the view.
+    using SLEBase<ViewT>::SLEBase;
+
+    explicit PayChannelEntry(
        AccountID const& src,
        AccountID const& dst,
        std::uint32_t seq,
@@ -293,10 +373,14 @@ public:
 };

 template <typename ViewT>
-class AMM : public SLEBase<ViewT>
+class AMMEntry : public SLEBase<ViewT>
 {
 public:
-    explicit AMM(
+    // Inherit base constructors: adopt an existing SLE, or resolve one from a
+    // Keylet against the view.
+    using SLEBase<ViewT>::SLEBase;
+
+    explicit AMMEntry(
        Asset const& issue1,
        Asset const& issue2,
        typename SLEBase<ViewT>::view_ref_type view,
@@ -307,10 +391,14 @@ public:
 };

 template <typename ViewT>
-class MPTokenIssuance : public SLEBase<ViewT>
+class MPTokenIssuanceEntry : public SLEBase<ViewT>
 {
 public:
-    explicit MPTokenIssuance(
+    // Inherit base constructors: adopt an existing SLE, or resolve one from a
+    // Keylet against the view.
+    using SLEBase<ViewT>::SLEBase;
+
+    explicit MPTokenIssuanceEntry(
        std::uint32_t seq,
        AccountID const& issuer,
        typename SLEBase<ViewT>::view_ref_type view,
@@ -321,10 +409,14 @@ public:
 };

 template <typename ViewT>
-class MPToken : public SLEBase<ViewT>
+class MPTokenEntry : public SLEBase<ViewT>
 {
 public:
-    explicit MPToken(
+    // Inherit base constructors: adopt an existing SLE, or resolve one from a
+    // Keylet against the view.
+    using SLEBase<ViewT>::SLEBase;
+
+    explicit MPTokenEntry(
        MPTID const& issuanceID,
        AccountID const& holder,
        typename SLEBase<ViewT>::view_ref_type view,
@@ -335,10 +427,14 @@ public:
 };

 template <typename ViewT>
-class Oracle : public SLEBase<ViewT>
+class OracleEntry : public SLEBase<ViewT>
 {
 public:
-    explicit Oracle(
+    // Inherit base constructors: adopt an existing SLE, or resolve one from a
+    // Keylet against the view.
+    using SLEBase<ViewT>::SLEBase;
+
+    explicit OracleEntry(
        AccountID const& account,
        std::uint32_t documentID,
        typename SLEBase<ViewT>::view_ref_type view,
@@ -349,10 +445,14 @@ public:
 };

 template <typename ViewT>
-class Credential : public SLEBase<ViewT>
+class CredentialEntry : public SLEBase<ViewT>
 {
 public:
-    explicit Credential(
+    // Inherit base constructors: adopt an existing SLE, or resolve one from a
+    // Keylet against the view.
+    using SLEBase<ViewT>::SLEBase;
+
+    explicit CredentialEntry(
        AccountID const& subject,
        AccountID const& issuer,
        Slice const& credType,
@@ -364,10 +464,14 @@ public:
 };

 template <typename ViewT>
-class PermissionedDomain : public SLEBase<ViewT>
+class PermissionedDomainEntry : public SLEBase<ViewT>
 {
 public:
-    explicit PermissionedDomain(
+    // Inherit base constructors: adopt an existing SLE, or resolve one from a
+    // Keylet against the view.
+    using SLEBase<ViewT>::SLEBase;
+
+    explicit PermissionedDomainEntry(
        AccountID const& account,
        std::uint32_t seq,
        typename SLEBase<ViewT>::view_ref_type view,
@@ -378,10 +482,14 @@ public:
 };

 template <typename ViewT>
-class Delegate : public SLEBase<ViewT>
+class DelegateEntry : public SLEBase<ViewT>
 {
 public:
-    explicit Delegate(
+    // Inherit base constructors: adopt an existing SLE, or resolve one from a
+    // Keylet against the view.
+    using SLEBase<ViewT>::SLEBase;
+
+    explicit DelegateEntry(
        AccountID const& account,
        AccountID const& authorizedAccount,
        typename SLEBase<ViewT>::view_ref_type view,
@@ -392,10 +500,14 @@ public:
 };

 template <typename ViewT>
-class Vault : public SLEBase<ViewT>
+class VaultEntry : public SLEBase<ViewT>
 {
 public:
-    explicit Vault(
+    // Inherit base constructors: adopt an existing SLE, or resolve one from a
+    // Keylet against the view.
+    using SLEBase<ViewT>::SLEBase;
+
+    explicit VaultEntry(
        AccountID const& owner,
        std::uint32_t seq,
        typename SLEBase<ViewT>::view_ref_type view,
@@ -406,10 +518,14 @@ public:
 };

 template <typename ViewT>
-class LoanBroker : public SLEBase<ViewT>
+class LoanBrokerEntry : public SLEBase<ViewT>
 {
 public:
-    explicit LoanBroker(
+    // Inherit base constructors: adopt an existing SLE, or resolve one from a
+    // Keylet against the view.
+    using SLEBase<ViewT>::SLEBase;
+
+    explicit LoanBrokerEntry(
        AccountID const& owner,
        std::uint32_t seq,
        typename SLEBase<ViewT>::view_ref_type view,
@@ -420,10 +536,14 @@ public:
 };

 template <typename ViewT>
-class Loan : public SLEBase<ViewT>
+class LoanEntry : public SLEBase<ViewT>
 {
 public:
-    explicit Loan(
+    // Inherit base constructors: adopt an existing SLE, or resolve one from a
+    // Keylet against the view.
+    using SLEBase<ViewT>::SLEBase;
+
+    explicit LoanEntry(
        uint256 const& loanBrokerID,
        std::uint32_t loanSeq,
        typename SLEBase<ViewT>::view_ref_type view,
@@ -433,18 +553,4 @@ public:
    }
 };

-template <typename ViewT>
-class Sponsorship : public SLEBase<ViewT>
-{
-public:
-    explicit Sponsorship(
-        AccountID const& sponsor,
-        AccountID const& sponsee,
-        typename SLEBase<ViewT>::view_ref_type view,
-        beast::Journal j = beast::Journal{beast::Journal::getNullSink()})
-        : SLEBase<ViewT>(keylet::sponsorship(sponsor, sponsee), view, j)
-    {
-    }
-};
-
 }  // namespace xrpl
--- a/include/xrpl/protocol/Indexes.h
+++ b/include/xrpl/protocol/Indexes.h
@@ -13,7 +13,6 @@
 #include <xrpl/protocol/Protocol.h>
 #include <xrpl/protocol/STXChainBridge.h>
 #include <xrpl/protocol/UintTypes.h>
-#include <xrpl/protocol/jss.h>

 #include <array>
 #include <cstdint>
@@ -363,20 +362,10 @@ struct KeyletDesc
 };

 // This list should include all of the keylet functions that take a single
-// AccountID parameter.
-std::array<KeyletDesc<AccountID const&>, 6> const kDirectAccountKeylets{
-    {{.function = &keylet::account, .expectedLEName = jss::AccountRoot, .includeInTests = false},
-     {.function = &keylet::ownerDir, .expectedLEName = jss::DirectoryNode, .includeInTests = true},
-     {.function = &keylet::signerList, .expectedLEName = jss::SignerList, .includeInTests = true},
-     // It's normally impossible to create an item at nftpage_min, but
-     // test it anyway, since the invariant checks for it.
-     {.function = &keylet::nftokenPageMin,
-      .expectedLEName = jss::NFTokenPage,
-      .includeInTests = true},
-     {.function = &keylet::nftokenPageMax,
-      .expectedLEName = jss::NFTokenPage,
-      .includeInTests = true},
-     {.function = &keylet::did, .expectedLEName = jss::DID, .includeInTests = true}}};
+// AccountID parameter. Defined in Indexes.cpp so that this header does not
+// need to include jss.h (which transitively re-includes transactions.macro
+// and breaks headers processed inside the TRANSACTION_INCLUDE machinery).
+extern std::array<KeyletDesc<AccountID const&>, 6> const kDirectAccountKeylets;

 MPTID
 makeMptID(std::uint32_t sequence, AccountID const& account);
--- a/include/xrpl/tx/transactors/lending/LoanManage.h
+++ b/include/xrpl/tx/transactors/lending/LoanManage.h
@@ -4,6 +4,7 @@
 #include <xrpl/core/ServiceRegistry.h>
 #include <xrpl/ledger/ApplyView.h>
 #include <xrpl/ledger/ReadView.h>
+#include <xrpl/ledger/helpers/SLEWrappers.h>
 #include <xrpl/protocol/Asset.h>
 #include <xrpl/protocol/STTx.h>
 #include <xrpl/protocol/TER.h>
@@ -41,9 +42,9 @@ public:
    static TER
    defaultLoan(
        ApplyView& view,
-        SLE::ref loanSle,
-        SLE::ref brokerSle,
-        SLE::ref vaultSle,
+        LoanEntry<ApplyView>& loanSle,
+        LoanBrokerEntry<ApplyView>& brokerSle,
+        VaultEntry<ApplyView>& vaultSle,
        Asset const& vaultAsset,
        beast::Journal j);

@@ -52,8 +53,8 @@ public:
    static TER
    impairLoan(
        ApplyView& view,
-        SLE::ref loanSle,
-        SLE::ref vaultSle,
+        LoanEntry<ApplyView>& loanSle,
+        VaultEntry<ApplyView>& vaultSle,
        Asset const& vaultAsset,
        beast::Journal j);

@@ -62,8 +63,8 @@ public:
    [[nodiscard]] static TER
    unimpairLoan(
        ApplyView& view,
-        SLE::ref loanSle,
-        SLE::ref vaultSle,
+        LoanEntry<ApplyView>& loanSle,
+        VaultEntry<ApplyView>& vaultSle,
        Asset const& vaultAsset,
        beast::Journal j);