From fac3dfccc873d85937b2e7da9c459d83dcbb5078 Mon Sep 17 00:00:00 2001 From: Vito <5780819+Tapanito@users.noreply.github.com> Date: Wed, 22 Jul 2026 11:58:17 +0200 Subject: [PATCH] fix: VaultVersion --- include/xrpl/protocol/Protocol.h | 1 - src/libxrpl/ledger/helpers/VaultHelpers.cpp | 7 +++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/include/xrpl/protocol/Protocol.h b/include/xrpl/protocol/Protocol.h index f387ea56de..9938a9b768 100644 --- a/include/xrpl/protocol/Protocol.h +++ b/include/xrpl/protocol/Protocol.h @@ -324,7 +324,6 @@ constexpr std::uint8_t kVaultMaximumIouScale = 18; */ enum class VaultVersion : uint8_t { Legacy = 0, - Invalid, CashBasis, }; diff --git a/src/libxrpl/ledger/helpers/VaultHelpers.cpp b/src/libxrpl/ledger/helpers/VaultHelpers.cpp index 5b2694250d..1ac4abdca3 100644 --- a/src/libxrpl/ledger/helpers/VaultHelpers.cpp +++ b/src/libxrpl/ledger/helpers/VaultHelpers.cpp @@ -149,10 +149,13 @@ getVaultVersion(SLE::const_ref vault) { case 0: return VaultVersion::Legacy; - case 2: + case 1: return VaultVersion::CashBasis; default: - return VaultVersion::Invalid; + // LCOV_EXCL_START + UNREACHABLE("xrpl::getVaultVersion : invalid vault version"); + return VaultVersion::Legacy; + // LCOV_EXCL_STOP } }