Inject Config:

* Use dependency injections instead
* Remove deprecated fee interfaces

src/ripple/basics/BasicConfig.h

@@ -216,7 +216,7 @@ public:
      *
      *  @param sectionName Retrieve the contents of this section's
      *         legacy value.
-     *  @returun Contents of the legacy value.
+     *  @return Contents of the legacy value.
      */
     std::string
     legacy(std::string const& sectionName) const;

src/ripple/basics/Sustain.h

@@ -26,13 +26,9 @@ namespace ripple {
 
 // "Sustain" is a system for a buddy process that monitors the main process
 // and relaunches it on a fault.
-//
-// VFALCO TODO Rename this and put it in a class.
-// VFALCO TODO Reimplement cross-platform using beast::Process and its ilk
-//
 bool HaveSustain ();
 std::string StopSustain ();
-std::string DoSustain (std::string const& logFile);
+std::string DoSustain ();
 
 } // ripple
 

src/ripple/basics/impl/Sustain.cpp

@@ -70,7 +70,7 @@ std::string StopSustain ()
     return "Terminating monitor";
 }
 
-std::string DoSustain (std::string const& logFile)
+std::string DoSustain ()
 {
     pManager = getpid ();
     signal (SIGINT, stop_manager);
@@ -111,8 +111,6 @@ std::string DoSustain (std::string const& logFile)
 
         auto pc = std::to_string (pChild);
         rename ("core", ("core." + pc).c_str ());
-        if (!logFile.empty()) // FIXME: logFile hasn't been set yet
-            rename (logFile.c_str(), (logFile + "." + pc).c_str ());
     }
 }
 
@@ -123,7 +121,7 @@ bool HaveSustain ()
     return false;
 }
 
-std::string DoSustain (const std::string&)
+std::string DoSustain ()
 {
     return "";
 }