From fa23fb51ea6182904d330ec71d2dfbe4a1098750 Mon Sep 17 00:00:00 2001
From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com>
Date: Thu, 27 Aug 2026 12:13:46 +0100
Subject: [PATCH] fix(telemetry): drop insight keys the OTel collector discards

prefix and service_instance_id are read and thrown away on this path, so
the node's identity label comes from [telemetry] instead. The old comment
claimed the insight copy was required or panels would be empty.
---
 docker/telemetry/xrpld-telemetry-mainnet.cfg | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/docker/telemetry/xrpld-telemetry-mainnet.cfg b/docker/telemetry/xrpld-telemetry-mainnet.cfg
index 720c9a1b6b..88a4a09fb9 100644
--- a/docker/telemetry/xrpld-telemetry-mainnet.cfg
+++ b/docker/telemetry/xrpld-telemetry-mainnet.cfg
@@ -135,15 +135,13 @@ data/logs/mainnet/debug.log
 
 # --- Insight (native OTel metrics via beast::insight) -----------------------
 
+# server is the only key that changes behaviour here. No prefix: formatName()
+# ignores it, so names stay bare (jobq_job_count). service_instance_id is read
+# and discarded (OTelCollector.cpp `(void)instanceId`); the label Prometheus
+# shows comes from [telemetry] service_instance_id below.
 [insight]
 server=otel
 endpoint=http://localhost:4318/v1/metrics
-prefix=xrpld
-# Sets the OTel service.instance.id resource attribute, which Prometheus
-# exposes as the `service_instance_id` label. Dashboards filter on it via the
-# $node template variable, so without this every insight-backed panel is
-# empty. Matches [telemetry] service_instance_id for a single node identity.
-service_instance_id=xrpld-mainnet
 
 # --- OpenTelemetry tracing --------------------------------------------------