chore: Enable clang-tidy v21 new checks (#7031)

This commit is contained in:
Alex Kremer
2026-04-29 16:17:35 +01:00
committed by GitHub
parent 46b997b774
commit f7275b7ad9
259 changed files with 2193 additions and 1888 deletions

View File

@@ -787,7 +787,12 @@ class View_test : public beast::unit_test::suite
BEAST_EXPECT(
USD(0) ==
accountHolds(
*env.closed(), alice, USD.currency, gw, fhZERO_IF_FROZEN, env.journal));
*env.closed(),
alice,
USD.currency,
gw,
FreezeHandling::fhZERO_IF_FROZEN,
env.journal));
// Thaw gw and try again.
env(fclear(gw, asfGlobalFreeze));
@@ -806,14 +811,26 @@ class View_test : public beast::unit_test::suite
// Bob's balance should be zero if frozen.
BEAST_EXPECT(
USD(0) ==
accountHolds(*env.closed(), bob, USD.currency, gw, fhZERO_IF_FROZEN, env.journal));
accountHolds(
*env.closed(),
bob,
USD.currency,
gw,
FreezeHandling::fhZERO_IF_FROZEN,
env.journal));
// gw thaws bob's trust line. bob gets his money back.
env(trust(gw, USD(100), bob, tfClearFreeze));
env.close();
BEAST_EXPECT(
USD(50) ==
accountHolds(*env.closed(), bob, USD.currency, gw, fhZERO_IF_FROZEN, env.journal));
accountHolds(
*env.closed(),
bob,
USD.currency,
gw,
FreezeHandling::fhZERO_IF_FROZEN,
env.journal));
}
{
// accountHolds().
@@ -824,17 +841,32 @@ class View_test : public beast::unit_test::suite
BEAST_EXPECT(
EUR(0) ==
accountHolds(
*env.closed(), carol, EUR.currency, gw, fhZERO_IF_FROZEN, env.journal));
*env.closed(),
carol,
EUR.currency,
gw,
FreezeHandling::fhZERO_IF_FROZEN,
env.journal));
// But carol does have USD.
BEAST_EXPECT(
USD(50) ==
accountHolds(
*env.closed(), carol, USD.currency, gw, fhZERO_IF_FROZEN, env.journal));
*env.closed(),
carol,
USD.currency,
gw,
FreezeHandling::fhZERO_IF_FROZEN,
env.journal));
// carol's XRP balance should be her holdings minus her reserve.
auto const carolsXRP = accountHolds(
*env.closed(), carol, xrpCurrency(), xrpAccount(), fhZERO_IF_FROZEN, env.journal);
*env.closed(),
carol,
xrpCurrency(),
xrpAccount(),
FreezeHandling::fhZERO_IF_FROZEN,
env.journal);
// carol's XRP balance: 10000
// base reserve: -200
// 1 trust line times its reserve: 1 * -50
@@ -851,28 +883,35 @@ class View_test : public beast::unit_test::suite
BEAST_EXPECT(
XRP(0) ==
accountHolds(
*env.closed(), carol, xrpCurrency(), gw, fhZERO_IF_FROZEN, env.journal));
*env.closed(),
carol,
xrpCurrency(),
gw,
FreezeHandling::fhZERO_IF_FROZEN,
env.journal));
}
{
// accountFunds().
// Gateways have whatever funds they claim to have.
auto const gwUSD =
accountFunds(*env.closed(), gw, USD(314159), fhZERO_IF_FROZEN, env.journal);
auto const gwUSD = accountFunds(
*env.closed(), gw, USD(314159), FreezeHandling::fhZERO_IF_FROZEN, env.journal);
BEAST_EXPECT(gwUSD == USD(314159));
// carol has funds from the gateway.
auto carolsUSD =
accountFunds(*env.closed(), carol, USD(0), fhZERO_IF_FROZEN, env.journal);
auto carolsUSD = accountFunds(
*env.closed(), carol, USD(0), FreezeHandling::fhZERO_IF_FROZEN, env.journal);
BEAST_EXPECT(carolsUSD == USD(50));
// If carol's funds are frozen she has no funds...
env(fset(gw, asfGlobalFreeze));
env.close();
carolsUSD = accountFunds(*env.closed(), carol, USD(0), fhZERO_IF_FROZEN, env.journal);
carolsUSD = accountFunds(
*env.closed(), carol, USD(0), FreezeHandling::fhZERO_IF_FROZEN, env.journal);
BEAST_EXPECT(carolsUSD == USD(0));
// ... unless the query ignores the FROZEN state.
carolsUSD = accountFunds(*env.closed(), carol, USD(0), fhIGNORE_FREEZE, env.journal);
carolsUSD = accountFunds(
*env.closed(), carol, USD(0), FreezeHandling::fhIGNORE_FREEZE, env.journal);
BEAST_EXPECT(carolsUSD == USD(50));
// Just to be tidy, thaw gw.