From f4d327fda735a5c65f397d70566e70c6003cb627 Mon Sep 17 00:00:00 2001 From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> Date: Tue, 31 Mar 2026 19:42:43 +0100 Subject: [PATCH] fix(telemetry): fix CI linker errors, check-rename, and docs build - Add ValidationTracker.cpp to xrpl.test.telemetry target sources (implementation lives in src/xrpld/ but has no OTel SDK dependency) - Change BEAST_DEFINE_TESTSUITE namespace from ripple to xrpl - Replace recursive *.md glob with non-recursive GLOB in XrplDocs.cmake to avoid picking up .claude/instructions.md Co-Authored-By: Claude Opus 4.6 --- cmake/XrplDocs.cmake | 6 +++++- src/test/telemetry/MetricsRegistry_test.cpp | 2 +- src/tests/libxrpl/CMakeLists.txt | 6 ++++++ 3 files changed, 12 insertions(+), 2 deletions(-) diff --git a/cmake/XrplDocs.cmake b/cmake/XrplDocs.cmake index 7b3e9b3b30..6f81dcfd5f 100644 --- a/cmake/XrplDocs.cmake +++ b/cmake/XrplDocs.cmake @@ -27,8 +27,12 @@ file( src/*.cpp src/*.md Builds/*.md - *.md ) +# Add only top-level .md files (README, CONTRIBUTING, etc.) without +# recursing into dot-directories like .claude/ whose files are not +# valid Doxygen/CMake sources. +file(GLOB doxygen_top_md CONFIGURE_DEPENDS "*.md") +list(APPEND doxygen_input ${doxygen_top_md}) list(APPEND doxygen_input external/README.md) set(dependencies "${doxygen_input}" "${doxyfile}") diff --git a/src/test/telemetry/MetricsRegistry_test.cpp b/src/test/telemetry/MetricsRegistry_test.cpp index 83b504671c..6b0b02cfce 100644 --- a/src/test/telemetry/MetricsRegistry_test.cpp +++ b/src/test/telemetry/MetricsRegistry_test.cpp @@ -368,7 +368,7 @@ public: } }; -BEAST_DEFINE_TESTSUITE(MetricsRegistry, telemetry, ripple); +BEAST_DEFINE_TESTSUITE(MetricsRegistry, telemetry, xrpl); } // namespace test } // namespace xrpl diff --git a/src/tests/libxrpl/CMakeLists.txt b/src/tests/libxrpl/CMakeLists.txt index 2c2bd64acb..80a8599935 100644 --- a/src/tests/libxrpl/CMakeLists.txt +++ b/src/tests/libxrpl/CMakeLists.txt @@ -57,6 +57,12 @@ endif() xrpl_add_test(telemetry) target_link_libraries(xrpl.test.telemetry PRIVATE xrpl.imports.test) target_include_directories(xrpl.test.telemetry PRIVATE ${CMAKE_SOURCE_DIR}/src) +# ValidationTracker lives in xrpld but has no OTel SDK dependency — +# compile its .cpp directly so the test can link without all of xrpld. +target_sources( + xrpl.test.telemetry + PRIVATE ${CMAKE_SOURCE_DIR}/src/xrpld/telemetry/detail/ValidationTracker.cpp +) if(telemetry) target_link_libraries( xrpl.test.telemetry