From 96a34953284f0e99a06f6af7abfc426888e30afd Mon Sep 17 00:00:00 2001 From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> Date: Wed, 9 Sep 2026 12:01:36 +0100 Subject: [PATCH 1/3] fix(telemetry): brace the direct-apply status branch in TxQ clang-tidy's readability-braces-around-statements exempts statements of at most two lines, but not an if/else chain. Brace both arms. --- src/xrpld/app/misc/detail/TxQ.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/xrpld/app/misc/detail/TxQ.cpp b/src/xrpld/app/misc/detail/TxQ.cpp index d98736e9f2..e6626473e0 100644 --- a/src/xrpld/app/misc/detail/TxQ.cpp +++ b/src/xrpld/app/misc/detail/TxQ.cpp @@ -807,9 +807,13 @@ TxQ::apply( { span.setAttribute(txq_span::attr::terCode, transToken(directApplied->ter).c_str()); if (directApplied->applied) + { span.setAttribute(txq_span::attr::txqStatus, txq_span::val::appliedDirect); + } else + { span.setAttribute(txq_span::attr::txqStatus, txq_span::val::failed); + } } return *directApplied; } From 08a1ab8cd340fd966db1956efd6473ce543281b4 Mon Sep 17 00:00:00 2001 From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> Date: Wed, 9 Sep 2026 12:01:39 +0100 Subject: [PATCH 2/3] fix(telemetry): drop the unused include from NullTelemetry The file names only std::string_view, which already provides. --- src/libxrpl/telemetry/NullTelemetry.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/libxrpl/telemetry/NullTelemetry.cpp b/src/libxrpl/telemetry/NullTelemetry.cpp index 64030b02d7..b1ae7e9e5b 100644 --- a/src/libxrpl/telemetry/NullTelemetry.cpp +++ b/src/libxrpl/telemetry/NullTelemetry.cpp @@ -31,7 +31,6 @@ #endif #include -#include #include namespace xrpl::telemetry { From 302a76f73ea2594f3558ff7e109525c250bcc657 Mon Sep 17 00:00:00 2001 From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> Date: Wed, 9 Sep 2026 12:01:42 +0100 Subject: [PATCH 3/3] fix(telemetry): make the readability probe stream const The stream is only tested for failure, and both operator bool and operator! are const members. --- src/libxrpl/telemetry/TelemetryConfig.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libxrpl/telemetry/TelemetryConfig.cpp b/src/libxrpl/telemetry/TelemetryConfig.cpp index 005be4f18a..681d5c98ec 100644 --- a/src/libxrpl/telemetry/TelemetryConfig.cpp +++ b/src/libxrpl/telemetry/TelemetryConfig.cpp @@ -194,7 +194,7 @@ requireReadableFile(std::string const& path, char const* configKey) { reason = "not a regular file"; } - else if (std::ifstream stream{path, std::ios::in}; !stream) + else if (std::ifstream const stream{path, std::ios::in}; !stream) { reason = std::error_code{errno, std::generic_category()}.message(); }