From f04f03b6b2018752974332655f5ab19195df41de Mon Sep 17 00:00:00 2001 From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> Date: Mon, 14 Sep 2026 20:42:08 +0100 Subject: [PATCH] fix(telemetry): drop the optional dereference the identity change left behind nodeIdentity_ is no longer a std::optional, so setNodeId() must read it directly. The merge could not flag this: phase-8 changed the member's type and this line lives only on phase-9, so neither side of the merge touched the same file region. --- src/xrpld/app/main/Application.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/xrpld/app/main/Application.cpp b/src/xrpld/app/main/Application.cpp index 23b4387884..bda8978034 100644 --- a/src/xrpld/app/main/Application.cpp +++ b/src/xrpld/app/main/Application.cpp @@ -1460,7 +1460,7 @@ ApplicationImp::setup(boost::program_options::variables_map const& cmdline) // xrpl.node.id always carries the node public key. Unlike // service_instance_id it is not configurable, so traces and metrics keep a // stable per-node key whatever [telemetry] says. - telemetry_->setNodeId(toBase58(TokenType::NodePublic, nodeIdentity_->first)); + telemetry_->setNodeId(toBase58(TokenType::NodePublic, nodeIdentity_.first)); // Start tracing here, not in start(). Spans are emitted during the rest of // setup() — the first consensus round in beginConsensus() below — and are