From f031befc6ea3d62d8ffded4460df918f82414e95 Mon Sep 17 00:00:00 2001 From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> Date: Fri, 29 May 2026 16:04:19 +0100 Subject: [PATCH] compilation fixes and levelization fixes Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> --- .github/scripts/levelization/results/ordering.txt | 1 + OpenTelemetryPlan/07-observability-backends.md | 8 ++++---- OpenTelemetryPlan/POC_taskList.md | 12 ++++++------ src/xrpld/app/main/Application.cpp | 2 +- 4 files changed, 12 insertions(+), 11 deletions(-) diff --git a/.github/scripts/levelization/results/ordering.txt b/.github/scripts/levelization/results/ordering.txt index ad9195a04b..eab32d671b 100644 --- a/.github/scripts/levelization/results/ordering.txt +++ b/.github/scripts/levelization/results/ordering.txt @@ -199,6 +199,7 @@ tests.libxrpl > xrpl.protocol tests.libxrpl > xrpl.protocol_autogen tests.libxrpl > xrpl.server tests.libxrpl > xrpl.shamap +tests.libxrpl > xrpl.telemetry tests.libxrpl > xrpl.tx xrpl.conditions > xrpl.basics xrpl.conditions > xrpl.protocol diff --git a/OpenTelemetryPlan/07-observability-backends.md b/OpenTelemetryPlan/07-observability-backends.md index 94124a62fe..a1c303b545 100644 --- a/OpenTelemetryPlan/07-observability-backends.md +++ b/OpenTelemetryPlan/07-observability-backends.md @@ -19,10 +19,10 @@ ```bash # Start Tempo with OTLP support docker run -d --name tempo \ - -p 3200:3200 \ - -p 4317:4317 \ - -p 4318:4318 \ - grafana/tempo:2.6.1 + -p 3200:3200 \ + -p 4317:4317 \ + -p 4318:4318 \ + grafana/tempo:2.6.1 ``` --- diff --git a/OpenTelemetryPlan/POC_taskList.md b/OpenTelemetryPlan/POC_taskList.md index 8cd390ef5b..bd1d6e62e7 100644 --- a/OpenTelemetryPlan/POC_taskList.md +++ b/OpenTelemetryPlan/POC_taskList.md @@ -453,18 +453,18 @@ ```bash # server_info curl -s -X POST http://localhost:5005 \ - -H "Content-Type: application/json" \ - -d '{"method":"server_info","params":[{}]}' + -H "Content-Type: application/json" \ + -d '{"method":"server_info","params":[{}]}' # ledger curl -s -X POST http://localhost:5005 \ - -H "Content-Type: application/json" \ - -d '{"method":"ledger","params":[{"ledger_index":"current"}]}' + -H "Content-Type: application/json" \ + -d '{"method":"ledger","params":[{"ledger_index":"current"}]}' # account_info (will error in standalone, that's fine — we trace errors too) curl -s -X POST http://localhost:5005 \ - -H "Content-Type: application/json" \ - -d '{"method":"account_info","params":[{"account":"rHb9CJAWyB4rj91VRWn96DkukG4bwdtyTh"}]}' + -H "Content-Type: application/json" \ + -d '{"method":"account_info","params":[{"account":"rHb9CJAWyB4rj91VRWn96DkukG4bwdtyTh"}]}' ``` 6. **Verify in Grafana (Tempo)**: diff --git a/src/xrpld/app/main/Application.cpp b/src/xrpld/app/main/Application.cpp index 9ca176dbb5..ac90fe6c96 100644 --- a/src/xrpld/app/main/Application.cpp +++ b/src/xrpld/app/main/Application.cpp @@ -330,7 +330,7 @@ public: config_->section("telemetry"), "", // Updated later via setServiceInstanceId() BuildInfo::getVersionString(), - config_->NETWORK_ID), + config_->networkId), logs_->journal("Telemetry"))) , txMaster_(*this)